DUNGEON CRAWLER(whats the problem?)

[preetpreet2493]

Write your question here.

[code]
#include <iostream>
#include "windows.h"
#include <time.h>

using namespace std;

//variables
const char HEIGHT = 16, WIDTH = 16;
const char enemy = 'X'; //fire enemy
const char enemy_2 = 'Y'; // water enemyy
const char enemy_3 = 'Z'; //earth wnemy
const char hero = 'P'; // player
const char treasure = 'T'; //treasures

char keys; //player input
char ans; // player answers
int score;
char exiting = 'x';

void Format()
{
	cout<<"WELCOME TO THE DONGEON, TRAVELLER!"<<endl;
	cout<<"_________________________________"<<endl<<endl;
	cout<<"Please note that your score increases ad you walk more."<<endl;
	cout<<"Your goal is to find the hidden trasures."<<endl;
	cout<<"Try to move around in every spot. Dont be afraid."<<endl<<endl;
	cout<<"Your SCORE :_"<<score<<endl;
//format for beginning of the game

}

struct enemyTypes 
{
	int x;
	int y;
// enemy position
};

enemyTypes fireEnemy;
enemyTypes earthEnemy;
enemyTypes waterEnemy;
enemyTypes treasureEnemy;
//declare the enemy types. treasure included because need the positiomn to work the same way as enemies

void MazeArray (unsigned char maze[HEIGHT][WIDTH], int HEIGHT, int WIDTH){

	for(int y=0 ; y< HEIGHT ; y++){
	cout<<endl;
	for(int x=0; x< WIDTH ; x++){
		cout<< maze[y][x];
	}
}
//shows the array
}

unsigned char maze[WIDTH][HEIGHT] = {
	
//1  2   3   4   5   6   7   8   9  10  11  12  13  14  15  16
'#','#','#','#','#','#','#','#','#','#','#','#','#','#','#','#',	//1
'#',' ',' ','#',' ','#',' ','#','#',' ',' ',' ',' ',' ',' ','#',	//2
'#',' ','#','#','#',' ',' ',' ',' ',' ','#',' ',' ',' ','#','#',	//3
'#',' ',' ',' ',' ',' ',' ','#',' ','#',' ','#',' ','#',' ','#',	//4
'#',' ',' ',' ',' ','#','#','#',' ','#',' ',' ','#','#',' ','#',	//5
'#',' ','#','#','#','#','#','#',' ','#',' ',' ','#','#',' ','#',	//6
'#',' ',' ',' ',' ',' ',' ',' ',' ','#',' ',' ','#',' ',' ','#',	//7
'#',' ','#','#',' ','#',' ','#',' ',' ','#','#','#',' ',' ','#',	//8
'#',' ',' ','#',' ',' ',' ','#',' ',' ','#',' ','#','#',' ','#',	//9
'#',' ','#','#','#',' ',' ',' ',' ',' ',' ',' ',' ',' ',' ','#',	//10
'#',' ','#',' ',' ',' ','#','#','#','#','#',' ','#','#','#','#',	//11
'#',' ',' ',' ',' ','#',' ',' ',' ',' ','#',' ',' ',' ',' ','#',	//12
'#','#','#',' ','#','#',' ','#','#',' ','#','#','#',' ',' ','#',	//13
'#',' ',' ',' ',' ',' ',' ',' ','#',' ',' ',' ',' ',' ','#','#',	//14
'#',' ',' ','#','#','#',' ',' ','#',' ','#','#',' ',' ',' ','#',	//15
'#','#','#','#','#','#','#','#','#','#','#','#','#','#','#','#',	//16

//maze coordinates
};

struct movingHero{
	int x;
	int y;
};

movingHero player;
//declare structre of player

void playerProperties(){
	
	player,x=1;
	player,y=1;
	maze[player,x][player,y]= hero;
	
	//properties of player and position x and y and adds character to it
}

void clearScreen(){
	
	system("CLS");
	Format();
	maze[player,x][player,y]= hero;
	MazeArray (maze,HEIGHT,WIDTH);
	
	//clears screen when hit enter then call the format function and adds in player in the maze 
}

void addEnemies(){
	
srand(time(NULL));

fireEnemy,x=rand()%14;
	fireEnemy,y=rand()%12;
	
earthEnemy,x=rand()%14;
	earthEnemy,y=rand()%13;
	
waterEnemy,x=rand()%14;
	waterEnemy,y=rand()%10+1;

maze[fireEnemy,x][fireEnemy,y]= enemy;
maze[earthEnemy,x][earthEnemy,y]= enemy_2;
maze[waterEnemy,x][waterEnemy,y]= enemy_3;

//adds enemies and rand postiomn
}

void replaceEnemies(){
	
srand(time(NULL));
maze[fireEnemy,x][fireEnemy,y]= ' ';
maze[earthEnemy,x][earthEnemy,y]= ' ';
maze[waterEnemy,x][waterEnemy,y]= ' ';
//places an enpty space in the spot of enemy when interacts with player

addEnemies();
clearScreen();

//function to replace all enemies once enemy is encountered
//triggered when enemy is attacked
}

void winFunction(){
	
treasure,x=rand()%14+1;
treasure,y=rand()%14+1;

//maze[treasure,x][treasure,y]=treasure
//treasure is invisible; hence player must LOOK FOR THE TREASURE

}

void elseIf(){
	
	cout<<"You've attacked the monster! It teleports to another place. You gained 2 ponts!"<<endl;
		system("PAUSE");
			maze[player,x][player,y]= ' ';
	
			player,x=rand()%14;
			player,y=rand()%14;
		
		clearScreen();
		//pauses game>replaces player positon>calls clearscreen
}
 
void fireEnemy(){
 	
 	cout<<"you've encountered a dragon monster and it is breathing fire!! What's your move?"<<endl;
 	cout<<"Shoot it ( * ) or Scare it away ( ~ )?"<<endl;
 	cin>>ans;
 	
 	if(ans == '*')
 	{
 		cout<<"The creature is dead"<<endl;
 			score += 5;			
 		cout<<"You earned 5 points. Now move along."<<endl;
 		system("PAUSE");
	}
	
	else if (ans == '~')
	{
			score -= 5;
			
		cout<<"You were burned by the monster!"<<endl;
		cout<<"You are injured. However, you managed to escape. You lost 5 points."<<endl;
		system("PAUSE");
		
		//fireEnemy function>ask player>add or minus points
	}
 }
 
void waterEnemy(){
 	
 	cout<<"you've encountered a bee monster! It is trying to sting you! What's your move?"<<endl;
 	cout<<" Punch it! ( * ) or SCREAMMMM!! ( ~ )?"<<endl;
 	cin>>ans;
 	
 	if(ans == '*')
 	{
 		cout<<"The creature got angrier! It stings you in the face!"<<endl;
 			score -= 2;			
 		cout<<"You lost 2 points. Lesson learnt, NEVER PUNCH A BEE."<<endl;
 		system("PAUSE");
	}
	
	else if (ans == '~')
	{
			score += 5;	
		cout<<"The bee monster was shocked!"<<endl;
		cout<<"To Bee or not to Bee? It carried you away to somewhere else. You earned 5 points."<<endl;
		
		elseIf();
		
		//beeEnemy function>ask player>add or minus points>if ans= ~ then player teleports
	}
 }
 
void answer(){
 	
 	cout<<"The dungeon swallows you into the ground and brought you back to the start!";
 		score -= 10;
 		cout<<"Oops! 10points deducted."<<endl;
 		 maze[player,x][player,y]= ' ';
 		 
			 	system("PAUSE");
				 playerProperties();
				 clearScreen();
				 
 }
 
void earthEnemy(){
 	
 	cout<<"The earthworm monster appears! What are you going to do?!"<<endl;
 	cout<<"Slash it with a katana ( * ) or Throw salt ( ~ )"
	cin>>ans;
 	
 	if(ans=='*')
 	{answer();
 	
	}
		
		else if(ans == '~'){
			score += 5;
			
		cout<<"The monster's skin dries out into a pulp of its dehydrated flesh! Eww!"<<endl;
		cout<<"You puked at the disgusting sight of it and left. You gained 5 points"<<endl;
		}
		
//ask player>if * then player sent back to start point
 }
 
void enemyAttack(movingHero a) {
	// function to detect if player hits an enemy or treasure	
	if(maze[fireEnemy,x][fireEnemy,y]== maze[a,x][a,y]) {
	
	FireEnemy();
	replaceEnemies();
	
	//so if enemy hits fire enemy, the FireEnemyy fucntion is called and player is asked a question>something happens depending on player's answer
	//after this part, enemy is replaced/repositioned
	}
	
	if(maze[waterEnemy,x][waterEnemy,y]== maze[a,x][a,y]) {
	
	WaterEnemy();
	replaceEnemies();
	}
	
	if(maze[earthEnemy,x][earthEnemy,y]== maze[a,x][a,y]) {
	
	EarthEnemy();
	replaceEnemies();
	}	
	
	if(maze[treasure,x][treasure,y]== maze[a,x][a,y]) {
	
	cout<<"Something caught your attention..."<<endl;
	cout<<"A metallic shine in the dark and you stepped closer..."<<endl;
	cout<<"The thing that was shining is the treasure. YOU DID IT!"<<endl<<endl;
	cout<<"The treasure is worth "<< score << "in gold"<<endl;
	//treasure is worth player's score
	system("PAUSE");
	exit(1);
	
	}
 }
 
int main(){

Format();
addEnemies();
winFunction();
playerProperties();
MazeArray(maze, HEIGHT, WIDTH);
// calls back all functions

do{
	
enemyAttack(player);
//calls attack function detecting if player hhits enemy
cin>>keys;

switch(keys){
	
case 'd';
{
	if(maze[player,x][player,y+1] != '#' )

	{		
		maze[player,x][player,y]= ' ';
		player,y++;
		clearScreen();
		score++;
	}
break;
	
	}
		
case 'a';
{
	if(maze[player,x][player,y-1] != '#' )

	{		
		maze[player,x][player,y]= ' ';
		player,y--;
		clearScreen();
		score++;
	}
break;
	
	}		

case 's';
{
	if(maze[player,x+1][player,y] != '#' )

	{		
		maze[player,x][player,y]= ' ';
		player,x++;
		clearScreen();
		score++;
	}
break;
	
	}
	
case 'w';
{
	if(maze[player,x-1][player,y] != '#' )

	{		
		maze[player,x][player,y]= ' ';
		player,x--;
		clearScreen();
		score++;
	}
break;
	
	}			
}
}


while(exiting == 'x');

return 0;
}

[/code]

[AbstractionAnon]

What's the problem?

You tell us. Does it not compile? If so, what errors don't you understand? Does it not execute properly? If not, what is happening or not happening?

Lines 18-21: Globals are a bad idea.

Many many places you have player,x (note the comma) . This should palyer.x (note the dot).
This applies all your struct member references.

Line 111,131: Do not call srand() multiple times. srand() sets the RNG to a particular starting point. Calling srand() repeatedly can cause the RNG to return the same random numbers. srand() should be called ONCE at the beginning of main().
http://www.cplusplus.com/reference/cstdlib/srand/

Line 146-147: treasure is not defined.

Line 167,193,232: Your function name is the same as your struct instance.

Line 235: Missing a ;

Line 306,320,334,348: switch cases use a : not a ;