Logic Error

[Calcious]

I'm trying to run a code that does a simple calculation of (x/13.772)* 30 with x being any value but the problem is the code stops prematurely at the point where it asks to rerun the code again. (Calculation works perfectly fine, so it doesn't seem like it's the problem)

ps... I know the names suck :P.

#include <iostream>
#include <string>

void Welcome();
float GeoValue();
void AnswerValue();
bool FightMe();


int main()
{
	bool bPlayAgain = true;

	do
	{
		Welcome();
		AnswerValue();
	} 
	while (bPlayAgain == FightMe());

	return 0;
}


void Welcome()
{
	std::cout << "TO CALCULATE THE TIMESCALE! WELCOME!\n";

	return;
}

float GeoValue()
{
	float value = 0;
	std::cout << "Enter your value." << std::endl;
	std::cin >> value;

	return value;
}

void AnswerValue()
{
	const float TimeScale = 13.772;
	const int LineMeasure = 30;

	float ValueOne = GeoValue();
	float Answer = (ValueOne / TimeScale) * LineMeasure;
	std::cout << "Your answer is " << Answer << "." << std::endl << std::endl;

	return;
}

bool FightMe()
{
	std::cout << "Do you want to do it again?\n";
	std::string PlayAgainPls = "hi";
	getline(std::cin, PlayAgainPls);
	return (PlayAgainPls[0] == 'y') || (PlayAgainPls[0] == 'Y');
}

[48T7M4Gy]

An innovative re-use of somebody's game-code.

PlayAgainPls has a number of problems and the easiest is to make it a char instead of string with the need for additional lines to ignore() stuff etc

bool FightMe()
{
	std::cout << "Do you want to do it again?\n";
	char PlayAgainPls = 'y';
	std::cin >> PlayAgainPls;
	return tolower(PlayAgainPls) == 'y';
}

[JLBorges]

getline(std::cin, PlayAgainPls); is unformatted input; it won't skip leading white space.

Change that to formatted input (which skips leading white space) with:

bool FightMe()
{
	std::cout << "Do you want to do it again?\n";
	std::string PlayAgainPls = "hi";

	// getline(std::cin, PlayAgainPls);
        std::cin >> PlayAgainPls ;

	return (PlayAgainPls[0] == 'y') || (PlayAgainPls[0] == 'Y');
}

and things would work as expected (we ignore input failure for now).

More information: http://www.cplusplus.com/forum/general/113238/#msg618762

[Calcious]

The code works for the tutorial that I'm going through, so I honestly don't know why it runs entirely differently on mine. Is there some kind of hidden interactions that I'm not aware of?

#include<iostream>
#include<string>


void PrintIntro();
void PlayGame();
std::string GetGuess();
bool AskToPlayAgain();

//entry point
int main()
{ 
	bool bPlayAgain = true;

	do 
	{
		PrintIntro();
		PlayGame();
	}
	while (bPlayAgain == AskToPlayAgain());

	return 0; // exit app
}

//introduce game
void PrintIntro()
{
	constexpr int WordLength = 5;
	std::cout << "Welcome to Bulls and Cows!\n";
	std::cout << "Can you guess the " << WordLength << " letter isogram that I'm thinking of?\n";
	std::cout << std::endl;
	return;
}

//iterate 5 times for GetGuess();
void PlayGame()
{
	constexpr int NumberOfTurns = 5;
	for (int GuessIteration = 1; GuessIteration <= NumberOfTurns; GuessIteration++)
	{
		std::string Guess = GetGuess();
		std::cout << "Your guess was " << Guess << "." << std::endl << std::endl;
	}
	return;
}

//get guess from player
std::string GetGuess()
{
	std::string Guess = "";
	std::cout << "Enter your guess: ";
	getline(std::cin, Guess);
	return Guess;
}

bool AskToPlayAgain()
{
	std::cout << "Do you want to play again? (y/n)";
	std::string Response = "";
	getline(std::cin, Response);

	return (Response[0] == 'y') || (Response[0] == 'Y');
}

[48T7M4Gy]

What is the program doing? What do you expect it to do?

[Calcious]

Well, it's an incomplete game because I haven't done the tutorial completely yet but it's supposed to be Bulls and Cows and I'm not good at explaining but it basically lets you say stuff five times then at the end it asks you to whether you want to play it again as of now...

It's the last function that bothers me, it's exactly the same as the one in my previous code but the previous code just halts at the point where it asks you whether you want to play again while this one works perfectly fine.