Variable array size in a class

[neil222]

Hi, I am wondering how to create a variable array called "ValueFilter", the variable size being defined using "LengthFilter".

Thanks in advance

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	int LengthFilter;
	int ValueFilter[];
};

TheFilter::TheFilter() {
	LengthFilter = 0;
	ValueFilter = new int[LengthFilter];
}

TheFilter::~TheFilter() {
	cout << "Filter deleted" << endl;
}

void TheFilter::EnterFilter() {
	cout << "Please enter the number of values in the filter" << endl;
	cout << "-----------------------------------------------" << endl;
	cin >> LengthFilter;
	cout << "Please enter the values of the filter" << endl;
	cout << "-------------------------------------" << endl;
	cin >> ValueFilter[];
	cout << "Filter entered" << endl;
}

[jonnin]

You either need to use the vector class, which is effectively an array replacement class, or a pointer.

the pointer looks like..

ctor
{
pointer = new type[variable];
}

dtor
{
delete[] pointer;
}


vectors take a few min to review before using, its not too hard but its a critical class for modern c++ programming.


so what you did looks like you were trying to use the pointer approach, but you missed.

it should be
int *ValueFilter;
instead of
int ValueFilter[];


and
LengthFilter = 0;
ValueFilter = new int[LengthFilter];

this isn't right. Don't set it to zero, it should be part of the user supplied data.

[Flaze07]

use...vector ?

[gunnerfunner]

ValueFilter should be a pointer to int:

#include <iostream>

constexpr auto LengthFilter = 5;

int main()
{
    int* ValueFilter = new int[LengthFilter];
    delete [] ValueFilter;
}

[Flaze07]

like this

vector <int> ValueFilter;
int LengthFilter;
cin >> LengthFilter;
ValueFilter.resize(LengthFilter);

here, if you dont know how to use vector..
http://www.cplusplus.com/reference/vector/

[neil222]

??

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	int* ValueFilter;
};

TheFilter::TheFilter() {
	int* ValueFilter= new int[LenghtFilter];
}

TheFilter::~TheFilter() {
	cout << "Filter deleted" << endl;
}

void TheFilter::EnterFilter() {
	cout << "Please enter the number of values in the filter" << endl;
	cout << "-----------------------------------------------" << endl;
	cin >> LengthFilter;
	cout << "Please enter the values of the filter" << endl;
	cout << "-------------------------------------" << endl;
	cin >> ValueFilter[];
	cout << "Filter entered" << endl;
}

[neil222]

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	Vector <int> ValueFilter;
	int LengthFilter;
};

//TheFilter::TheFilter() {
//	int* ValueFilter= new int[LenghtFilter];
//}

TheFilter::~TheFilter() {
	cout << "Filter deleted" << endl;
}

void TheFilter::EnterFilter() {
	cout << "Please enter the number of values in the filter" << endl;
	cout << "-----------------------------------------------" << endl;
	cin >> LengthFilter;
	ValueFilter.resize(LengthFilter)
	cout << "Please enter the values of the filter" << endl;
	cout << "-------------------------------------" << endl;
	cin >> ValueFilter;
	cout << "Filter entered" << endl;
}

[gunnerfunner]

If acquiring resources through ctor then release these resources through the dtor:

TheFilter::TheFilter() {
	int* ValueFilter= new int[LenghtFilter];
}

TheFilter::~TheFilter() {
        delete [] ValueFilter;
	cout << "Filter deleted" << endl;
}

[neil222]

"Vector" is an undeclared identifier?

[Hengry]

"Vector" is an undeclared identifier?

Did you #include <vector> ?

If you didn't you have to use std::vector

[AbstractionAnon]

"Vector" is an undeclared identifier?

Line 11: std::vector should not be capitalized.

[neil222]

delete [] ValueFilter;

This line doesn't work, something to do with "delete" and "ValueFilter"

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	int LengthFilter;
	vector <int> ValueFilter;
};

TheFilter::TheFilter() {
	int* ValueFilter = new int [LengthFilter];
}

TheFilter::~TheFilter() {
	delete [] ValueFilter;
	cout << "Filter deleted" << endl;
}

void TheFilter::EnterFilter() {
	cout << "Please enter the number of values in the filter" <<endl;
	cout << "-----------------------------------------------" <<endl;
	cin >> LengthFilter;
	cout << "Please enter the values of the filter" <<endl;
	cout << "-------------------------------------" <<endl;
	cin >> ValueFilter;
	cout << "Filter entered" <<endl;
}

void TheFilter::ShowFilter() {
	cout << "The filter is" << ValueFilter <<endl;
}

[jonnin]

int* ValueFilter = new int [LengthFilter];

this is a local variable to the function, and it should be a class member.

move the
int *ValueFilter; up to the class.
Keep
ValueFilter = new int [LengthFilter];

in the constructor.

[neil222]

Like so?

private:
	int LengthFilter;
	vector <int> ValueFilter;
	int* ValueFilter;
};

[jonnin]

No, you have 2 variables with the same name.

either use the vector,
or use the pointer.

not both.

If you are using vectors, do not do anything special in the constructor and destructor. You only need the allocation and deallocations for a pointer. Vector is a class that will handle its own memory stuff hidden from you.

[neil222]

Better?

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	int LengthFilter;
	vector <int> ValueFilter;
};

TheFilter::TheFilter() {
	 ValueFilter = new int [LengthFilter];
}

TheFilter::~TheFilter() {
	delete [] ValueFilter;
	cout << "Filter deleted" << endl;
}

[Chervil]

neil222 wrote:

Better?

No.
As jonnin said,

jonnin wrote:

either use the vector,
or use the pointer.

not both.

If you use a vector, you don't need the variable LengthFilter either, because the vector maintains its own length - access it as ValueFilter.size() if necessary.

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	vector <int> ValueFilter;
};

TheFilter::TheFilter() {
}

TheFilter::~TheFilter() {
	cout << "Filter deleted" << endl;
}

[Flaze07]

I thought the op wants the user to enter the length of the array(vector)

[jonnin]

still could, just check its size if a vector and if too big, complain or whatever.