Adding at the end of a For loop

[jhb7Djzh]

I can't get the variable netval to add the val variable after each for loop. As it is, the output of this is simply the last value I input into the program

  
#include <iostream>
using namespace std;


int main(){
	
int cardnum,val, netval, counter;
char cards;
	
cout << "How many cards? ";
cin >> cardnum;

cout <<"Input the value of your cards: ";

for(counter = 0; counter < cardnum; counter++){
cin >> cards;

switch(cards)
		{	 	 

		case '2':
			val = 2;
				break;
		
		case '3':
			val = 3;
				break;
		
		case '4':
			val = 4;
				break;
		
		case '5':
			val = 5;
				break;
		
		case '6':
			val = 6;
				break;
		
		case '7':
			val = 7;
				break;
		
		case '8':
			val = 8;
				break;
		
		case '9':
			val = 9;
				break;
		
		case 't':
			val = 10;
				break;
		
		case 'j':
			val = 10;
				break;
		
		case 'q':
			val = 10;
				break;
		
		case 'k':
			val = 10;
				break;
		
		case 'a':
			val = 1;
				break;
		
		default:
			cout << "Enter a valid character.";
				break;

		}
netval =+ val;
	}

cout << netval;
return 0;
}

[whitenite1]

@conzerban

netval =+ val
The above is written incorrectly. It should be..
netval += val

[jhb7Djzh]

Thanks. Though that gives me a very large number.

[whitenite1]

@conzerban

You might want to initialize netval as 0, to begin with, otherwise, who knows what the value starts with when you start adding val to it.

[jhb7Djzh]

That was it! Thanks for the help.

[whitenite1]

You're welcome, conzerban..

[JLBorges]

> Though that gives me a very large number.

Initialise netval

Tip: turn on all compiler warnings (it would have alerted you about the use of an uninitialised variable)

Tip: postpone the declaration of local variables to as late as possible.

#include <iostream>

int main() {

    int cardnum ;
    std::cout << "How many cards? ";
    std::cin >> cardnum;

    int netval = 0 ; // initialised with zero

    std::cout <<"Input the value of your cards: ";
    for( int counter = 0; counter < cardnum; ++counter ) {

        char card ;
        std::cin >> card;

        int value = 0 ;  // initialised with zero
        if( card >= '2' && card <= '9' ) value = card - '0' ; // '3' - '0' == 3 etc.
        else switch(card) {

            case 't' : case 'T' : value = 10 ; break ;
            case 'j' : case 'J' : value = 11 ; break ;
            case 'q' : case 'Q' : value = 12 ; break ;
            case 'k' : case 'K' : value = 13 ; break ;
            case 'a' : case 'A' : value = 1 ; break ;
            default: std::cout << "invalid card '" << card << "' is ignored\n" ;
        }

        netval += value; // note: value remains zero for invalid input
    }

    std::cout << "net value: " << netval;
}