Switch function

[neil222]

Pardon the long code, it is just there to give the question context. The question is why the switch function isn't running the functions in the class??

// Purpose
// A program to demonstrate the application of a simple digital filter
// 
// Overview
// A sequence of data items and digital filter values need to be entered by the
// user. The application of the filter to the data involves a simple convolution 
// operation. The filtered data are stored separately. 
//
// Example
//  before filtering: 
//   data_in = [0 1 3 6 3 1 0]
//   filter = [-0.5 1 -0.5]
//  after filtering:
//   data_out = [-0.5 -0.5 3 -0.5 -0.5]
//  where
//   data_out[0]=data_in[0]*filter[0]+data_in[1]*filter[1]+data_in[2]*filter[2]
//   data_out[1]=data_in[1]*filter[0]+data_in[2]*filter[1]+data_in[3]*filter[2]
//   data_out[2]=data_in[2]*filter[0]+data_in[3]*filter[1]+data_in[4]*filter[2]
//   data_out[3]=data_in[3]*filter[0]+data_in[4]*filter[1]+data_in[5]*filter[2]
//   data_out[4]=data_in[4]*filter[0]+data_in[5]*filter[1]+data_in[6]*filter[2]
//
// The program checks the following
// 1. The data and filter values must have been entered before the filter is 
//    applied
// 2. The filter is not applied if the number of filter values is greater than
//    the number of input data values
// 3. The data and filter values must have been entered and the filter applied 
//    before the filtered data can be displayed

#include <iostream>
#include <fstream>
#include <stdlib.h>
#include <string>
#include <algorithm>
#include <iterator>

using namespace std;

#define FILTER_FILENAME "filter.txt"
#define FILTER_MAX 100

class TheFilter {
public:
	TheFilter();
	~TheFilter();
	void EnterFilter();
	void ShowFilter();
	void Valid();
	void LoadFilter();
	void SaveFilter() const;
private:
	double LengthFilter;
	int ValueFilter;
};

TheFilter::TheFilter() {
	ValueFilter = 0;
	LengthFilter = 0;
}

TheFilter::~TheFilter() {
	cout << "Filter deleted" << endl;
}

void TheFilter::EnterFilter() {
	cout << "Please enter the number of values in the filter" <<endl;
	cout << "-----------------------------------------------" <<endl;
	cin >> LengthFilter;
	cout << "Please enter the values of the filter" <<endl;
	cout << "-------------------------------------" <<endl;
	cin >> ValueFilter;
	cout << "Filter entered" <<endl;
}

void TheFilter::ShowFilter() {
	cout << "The filter is" << ValueFilter <<endl;
}

void TheFilter::LoadFilter() {
//	fstream input_file;
//	input_file.open(FILTER_FILENAME, ios::in);
//	if (input_file.good()) {
//	input_file >>ValueFilter;
//	for (unsigned long i=0; i<ValueFilter; i++) {
//		input_file >>ValueFilter[i];
//	}
//	}
//	input_file.close();
//	cout <<"Filter loaded" <<endl;
}

void TheFilter::SaveFilter() const {
//	fstream output_file;
//	output_file.open(FILTER_FILENAME, ios::out)
//		if (output_file.good()) {
//		output_file <<ValueFilter <<endl <<endl;
//		for (unsigned long i=0; i<ValueFilter; i++) {
//			output_file <<  <<endl;
//		}
//	}
//	output_file.close();
//	cout <<"Filter saved" <<endl;
}

class TheData {
public:
	TheData();
	~TheData();
	void EnterData();
	void ShowData();
	void Valid();
	void LoadData();
	void SaveData();
private:
	unsigned long LengthData;
	char ValueData;
};

TheData::TheData() {
	LengthData = 0;
	ValueData = 0;
}

TheData::~TheData() {
	cout << "Data deleted" << endl;
}

void TheData::EnterData() {
	cout << "Please enter the number of data values" <<endl;
	cout << "--------------------------------------" <<endl;
	cin >> LengthData;
	cout << "Please enter the values of the data" <<endl;
	cout << "-----------------------------------" <<endl;
	cin >> ValueData;
	cout << "Data entered" <<endl;
}

void TheData::ShowData() {
	cout << "The data is" << ValueData <<endl;
}

void TheData::LoadData () {

}

void TheData::SaveData() {

}

class ApplyFilter {
public:
	ApplyFilter();
	~ApplyFilter();
	void FilterData();
	void ShowFinal();
	void SaveFinal();
private:
	unsigned long FinishedData;
};

ApplyFilter::ApplyFilter() {
	FinishedData = 0;
}

ApplyFilter::~ApplyFilter() {
	cout << "Filtered data deleted" << endl;
}

void ApplyFilter::FilterData() {

}

void ApplyFilter::ShowFinal() {
	cout << "The results are " << FinishedData <<endl;
}

void ApplyFilter::SaveFinal() {

}
 
int main() {

	int UserInput;
	std::string SavedFilter;
	std::string SavedData;
	std::string SavedFinal;
	TheData Data;
	TheFilter Filter;
	ApplyFilter Apply;
	fstream FilePointer; 

	while (1) {
		
		cout << "Welcome to this filtering programme, please select your option;" <<endl;
		cout << "---------------------------------------------------------------" <<endl;
		cout << "1. Enter new filter values" <<endl;
		cout <<	"2. Load existing filter values" <<endl;
		cout << "3. Show filter" <<endl;
		cout << endl;
		cout << "4. Enter new data values" <<endl;
		cout << "5. Load existing filter values" <<endl;
		cout << "6. Show data" <<endl;
		cout << endl;
		cout << "7. Apply filter" <<endl;
		cout << "8. Display filtered data" <<endl;
		cout << endl;
		cout << "9. Exit programme" <<endl;
		cout << "-----------------" <<endl;
		cout << endl;
		cout << "Please enter your option: " <<endl;

		cin >> UserInput;
		cout << endl;

		switch (UserInput) {
		case '1':
			Filter.EnterFilter();
			cout << "Would you like to save the new filter? [Y] [N]" <<endl;
			cin >> SavedFilter;

			if (SavedFilter == "Y") {
				Filter.SaveFilter();
			}
			break;

		case '2':
			Filter.LoadFilter();
			break;

		case '3':
			Filter.ShowFilter();
			break;

		case '4':
			Data.EnterData();
			cout << "Would you like to save the new data values? [Y] [N]" <<endl;
			cin >> SavedData;

			if (SavedData == "Y") {
				Data.SaveData();
			}
			break;

		case '5':
			Data.LoadData();
			break;

		case '6':
			Data.ShowData();
			break;

		case '7':
			Apply.FilterData();
			break;

		case '8':
			Apply.ShowFinal();
			cout << "Would you like to save the filtered data? [Y] [N]" <<endl;
			cin >> SavedFinal;

			if (SavedFinal == "Y") {
				Apply.SaveFinal();
			}
			break;

		case '9':
			return 0;

		default:
			cout << "Please select a valid option" << endl;
		}
	}
	
}

[Peter87]

If you input 49 (ASCII code for 1) it will probably run case '1'.

The problem is that UserInput is an int while '1', '2', '3', etc. are characters.

To fix this problem you should use integer literals instead of character literals in the switch.

// wrong
case '1':

// right
case 1:

[neil222]

Perfect, thanks :)