Validation Error

[VX0726]

Hello all, I am having trouble with the following code. It should be validating whether or not the first letter of a name is alphabetic. However, when I enter an invalid name twice in a row, it accepts the answer the second time, but ignores the first letter.

Heres my output:

What would you like to do? 
1. Enter Person information 
1
What is person #1's name? 
(enter the full name)
8l
Name may not start with non-alphabetic letter. Try again: 
!l
What is l's age? 

It is disregarding the ! in the name for some reason.

Here's my code:

#include <iostream>
#include <cstring>
#include <cctype>
using namespace std;

class Person
{
    public:
        Person();
        Person(string pname, int page);
        string getName() const;
        void setName(string& pname);
        void setAge(int& page);
        int getAge() const;
    
    private:
        string name;
        int age;
};

bool validateString (const string & s);

int main()
{
    int input, count = 0, age;
    Person person[30];
    string name;
    bool didPrint = false;
    
    do
    {
        cout << "What would you like to do? " << endl;
        cout << "1. Enter Person information " << endl;
        
        if (count >= 1)
        {
            cout << "2. Print person information " << endl;
            cout << "3. Exit " << endl;
        }
        
        cin >> input;
        
        if (input == 3 && count >= 1)
            break;
        
        while (input != 1 && input != 2)
        {
            cin.clear();
            cin.ignore('1000', '\n');
            cout << "Invalid input. ";
            
            cout << "What would you like to do? " << endl;
            cout << "1. Enter Person information " << endl;
            
            if (count >= 1)
            {
                cout << "2. Print person information " << endl;
                cout << "3. Exit " << endl;
            }
            
            cin >> input;
            
            if (input == 3 && count >= 1)
                break;
        }
        
        if (input == 1)
        {
            cout << "What is person #" << count + 1 << "'s";
            person[count].setName(name);
            
            cout << "What is " << person[count].getName() << "'s age? " << endl;
            person[count].setAge(age);
        }
        
        else if (input == 2 && count >= 1)
        {
            for (int i = 0; i < count; i++)
            {
                cout << "Person #" << i + 1 << ": " << endl;
                cout << "Name: " << person[i].getName() << ". " << endl;
                cout << "Age: " << person[i].getAge() << "\n" << endl;
            }
            didPrint = true;
        }
        
        count++;
    } while (input != 3 && count <= 30);
    
    if (count == 30 || !didPrint)
    {
        for (int i = 0; i < count; i++)
        {
            cout << "Person #" << i + 1 << ": " << endl;
            cout << "Name: " << person[i].getName() << ". " 
                 << endl;
            cout << "Age: " << person[i].getAge() << ". \n" 
                 << endl;
        }
    }
    
    cout << "Bye! " << endl;
}

int Person::getAge() const
{
    return age;
}

string Person::getName() const
{
    return name;
}

void Person::setName(string& pname)
{
    cout << " name? " << endl;
    cout << "(enter the full name)" << endl;
    cin.ignore();
    getline(cin, pname);
    
    while (validateString(pname)==false)
    {
        cout << "Name may not start with non-alphabetic letter." 
             << "Try again: " << endl;
        cin.ignore();
        getline(cin, pname);
    }
    
    name = pname;
}

void Person::setAge(int& page)
{
    cin >> page;
    
    while (cin.fail() || page < 0 || page > 140)
    {
        cin.clear();
        cin.ignore('1000', '\n');
        cout << "Invalid. Try again: " << endl;
        cin >> page;
    }
    
    age = page;
}

Person::Person()
{
    age = 0;
    name = "noname";
}

Person::Person(string pname, int page)
{
    name = pname;
    age = page;
}

bool validateString (const string & s)
{
    if (!isalpha(s[0]))
        return false;
    
    else
        return true;
}

[Chervil]

Line 119:

    cin.ignore();
    getline(cin, pname);

Line 126:

        cin.ignore();
        getline(cin, pname);

The use of ignore() before getline() is not recommended.
That code is dependent on the existing state of the input buffer, which is here assumed to contain a trailing newline '\n' as a result of some previous cin >> operation.

It would be better to remove the cin.ignore() from here, and instead apply it at the point in the program where the newline was put into the buffer. That is to say, in main().

[VX0726]

Ok, it is fixed. What else am I doing wrong?

[Chervil]

What else am I doing wrong?

Is there a specific malfunction which you are asking about? Or is it a request for an assessment/review of the code?

[VX0726]

Actually, I wanted to know how I can make the first letters of the first and last name uppercased. I know I can do

name[0] = toupper(name[0]);

But that only changes the first name to uppercase. How about the last name? I would change the name string into a first name string and last name string, but we are supposed to store it in one string.

I think you could search for the letter after the space and change it to uppercase, but I don't have the experience to do this.

Thanks,
VX

[Chervil]

search for the letter after the space

A combination of finding the first space, then finding the first non-space after that, could work.
http://www.cplusplus.com/reference/string/string/find_first_of/
http://www.cplusplus.com/reference/string/string/find_first_not_of/

[JLBorges]

std::string adjust_case( std::string name )
{
    bool in_word = false ;

    for( char& c : name ) // for each character in name
    {
        if( std::isalpha(c) ) // if alphabet
        {
            if(in_word) c = std::tolower(c) ; // if already in a word, convert to lower case

            else // beginning of a new word
            {
                c = std::toupper(c) ; // convert to upper case
                in_word = true ; // we are in a word now
            }
        }

        else in_word = false ; // not alpha, we are not in a word now
    }

    return name ;
}

http://coliru.stacked-crooked.com/a/bb97aa7db3da12fc

[VX0726]

Thank you both, Chervil and JLBorges. Great inputs!

-VX

[gunnerfunner]

Use std::sregex_token_iterator to tokenize the std::string using whitespace (and any others) as delimiter(s). Manipulate the iterator returned by the std::sregex_token_iterator ctor to uppercase first letters:
(http://en.cppreference.com/w/cpp/regex/regex_token_iterator)

#include <iostream>
#include <regex>
#include <string>
#include <cctype>
#include <string>
#include <locale>

int main()
{
    std::string name;
    std::cout << "Enter name: \n";
    getline(std::cin, name);

    std::regex rgx("\\s+"); // tokenize string by whitespace
    std::sregex_token_iterator iter(name.begin(), name.end(), rgx, -1);
    // "-1" represents the parts that are not matched i.e. the stuff between matches
    std::sregex_token_iterator name_end;
   //An uninitialized regex iterator automatically represents the ending position
    for ( ; iter != name_end; ++iter)
    {
        std::string name =  std::toupper(iter->str()[0], std::locale()) + (iter->str()).substr(1);
        std::cout << name << '\n';
    }
}