C++ Function Help

[Redrover36]

I need this code to work with DoOneSet having only 3 arguments, basically this code needs to be simplified, would appreciate any and all help. Theres a way I can use one function to figure out the amount of correct answers, thats the part I'm stuck on. Thanks.

#include <iostream>
#include <iomanip>
using namespace std;

void doOneset(char symbol, int probsPerSet, int &numCorrect1, int &numCorrect2,
              int &numCorrect3);
void getProbsPerSet (int &probsPerSet);
void checkAnswer(int &answer1, int &sum);
void printReport(int probsPerSet, int numCorrect1, int numCorrect2, int numCorrect3);


int main ()
{
    int probsPerSet;
    int numCorrect1 = 0;
    int numCorrect2 = 0;
    int numCorrect3 = 0;
   
    
    
    srand(static_cast<unsigned>(time(0)));
    getProbsPerSet(probsPerSet);
    doOneset('+', probsPerSet, numCorrect1, numCorrect2, numCorrect3);
    doOneset('-', probsPerSet, numCorrect1, numCorrect2, numCorrect3);
    doOneset('*', probsPerSet, numCorrect1, numCorrect2, numCorrect3);
    printReport(probsPerSet, numCorrect1, numCorrect2, numCorrect3);
    
    
    
}


void generateOperands(int &num1, int &num2, int &maxNum)
{
    
    
    num1 = rand() % (maxNum + 1);
    num2 = rand() % (maxNum + 1);
    
    
}





void checkAnswer(int &answer1, int &sum, int &numCorrect1)
{
    
    
    
    
    
    if (answer1 == sum){
        cout << "correct" << endl;
        numCorrect1++;
        
        
    } else {
        cout << "incorrect" << endl;
    }
    
    
}






void checkAnswer2(int &answer1, int &sum, int &numCorrect2)
{
    
    
    
    
    
    if (answer1 == sum){
        cout << "correct" << endl;
        numCorrect2++;
        
        
    } else {
        cout << "incorrect" << endl;
    }
    
    
}






void checkAnswer3(int &answer1, int &sum, int &numCorrect3)
{
    
    
    
    
    
    if (answer1 == sum){
        cout << "correct" << endl;
        numCorrect3++;
        
        
    } else {
        cout << "incorrect" << endl;
    }
    
    
}





void calculateMultiplication (int &sum, int &num1, int &num2)
{
    sum = num1 * num2;
}





void calculateSubtraction(int &sum, int &num1, int &num2)
{
    sum = num1 - num2;
}





void calculateCorrectAnswer(int &sum, int &num1, int &num2)
{
    
    
    sum = num1 + num2;
    
    
}





void getMaxNum(int &maxNum)
{
   cout << "What is the maximum number for this set? ";
    cin >> maxNum;
}




void doOneProblem(int maxNum, int &numCorrect1)
{
    int num1;
    int num2;
    int answer1;
    int sum;
    
    
    
    
    
    
    
    generateOperands(num1, num2, maxNum);
    calculateCorrectAnswer(sum, num1, num2);
    
    cout << num1 << "+" << num2 << "= ";
    cin >> answer1;
    checkAnswer(answer1, sum, numCorrect1);
   
}





void doOneSubtraction(int maxNum, int &numCorrect2)
{
    int num1;
    int num2;
    int sum;
    int answer1;
    
    
    
    
    
    generateOperands(num1, num2, maxNum);
    calculateSubtraction(sum, num1, num2);
    
    cout << num1 << " - " << num2 << " = ";
    cin >> answer1;
    
    checkAnswer2(answer1, sum, numCorrect2);
    
    
}





void doOneMultiplication(int maxNum, int &numCorrect3)
{
    int num1;
    int num2;
    int sum;
    int answer1;
    
    
    
    
    generateOperands(num1, num2, maxNum);
    calculateMultiplication(sum, num1, num2);
    
    cout << num1 << " * " << num2 << " = ";
    cin >> answer1;
    
    checkAnswer3(answer1, sum, numCorrect3);
    
}





void getProbsPerSet(int &probsPerSet)
{
    
    
    
    cout << "Enter problems per set: ";
    cin >> probsPerSet;
    
    }


void printHeader(char symbol)
{
    if (symbol == '+')
        cout << "Set #1" << endl;
    
    if (symbol == '-')
        cout << "Set #2" <<endl;
   
    if (symbol == '*')
        cout << "Set #3" <<endl;
    
    
}







void doOneset(char symbol, int probsPerSet, int &numCorrect1, int &numCorrect2,
              int &numCorrect3)
{
    
    int count;
    int maxNum;
    
  
    
    
    if (symbol == '+'){
        printHeader('+');
        getMaxNum(maxNum);
        for (count = 0; count < probsPerSet; count++)
        doOneProblem(maxNum, numCorrect1);
        
        
        
        
        
    }
    if (symbol == '-'){
        printHeader('-');
        getMaxNum(maxNum);
        for (count = 0; count < probsPerSet; count++)
            doOneSubtraction(maxNum, numCorrect2);
        
        
        
        
    }
    if (symbol == '*'){
        printHeader('*');
        getMaxNum(maxNum);
        for (count = 0; count < probsPerSet; count++)
            doOneMultiplication(maxNum, numCorrect3);
       
        
        
    }
    
}

void printReport(int probsPerSet, int numCorrect1, int numCorrect2, int numCorrect3)
{
    int percCorrect1, percCorrect2, percCorrect3, TotalPercCorr, TotalCorrect, TotalProbs;
    
    percCorrect1 = numCorrect1/static_cast<double>(probsPerSet) * 100;
    
    percCorrect2 = numCorrect2/static_cast<double>(probsPerSet) * 100;
    
    percCorrect3 = numCorrect3/static_cast<double>(probsPerSet) * 100;
    
    TotalCorrect = numCorrect1 + numCorrect2 + numCorrect3;
    
    TotalProbs = 3*probsPerSet;
    
    TotalPercCorr = TotalCorrect/static_cast<double>(TotalProbs) * 100;
    
    cout <<"Set#1: You got " <<numCorrect1<<" correct out of " <<probsPerSet<< " for "
    << fixed << setprecision(1) << percCorrect1 << "%" << endl;
    
    cout <<"Set#2: You got " <<numCorrect2<< " correct out of " <<probsPerSet << " for "
    << fixed << setprecision(1) << percCorrect2 << "%" << endl;
    
    cout << "Set#3: You got " << numCorrect3 << " correct out of "<< probsPerSet<<" for "
    << fixed << setprecision(1) << percCorrect3 << "%" << endl;
    
    cout << "Overall you got " << TotalCorrect << " correct out of "<<TotalProbs <<" for "
    << fixed << setprecision(1) << TotalPercCorr << "%" << endl;
    
    
   
}

[AbstractionAnon]

Why do you have checkanswer, checkanswer2 and checkanswer3? All three functions are identical. The third argument name is different, but that is irrelevant. Argument names are local to the function and have no bearing on what they are called when called.

[Redrover36]

Because I am checking 3 different correct answers, I know theres a way to make one function call all three, thats why I'm posting on here, I don't know how to make it work with just one function, if it had the same variable name it wouldn't work when I'm adding up all the scores in the printReport function.

[AbstractionAnon]

That's not how argument names work. As I said,

Argument names are local to the function and have no bearing on what they are called in the calling function.

void checkAnswer (int & answer, int &sum, int &numCorrect)
//  Note than answer and numCorrect names do NOT need to be the same as in calling function
{   if (answer == sum)
    {   cout << "correct" << endl;
        numCorrect++;        
    } else 
    {   cout << "incorrect" << endl;
    }        
}

Line 8: Your function prototype for checkAnswer is incorrect. The implementation takes 3 arguments.

doOneSet can be refactored as follows:

void doOneset(char symbol, int probsPerSet, int &numCorrect1, int &numCorrect2,
              int &numCorrect3)
{   int maxNum;
     
    printHeader (symbol);  
    getMaxNum(maxNum); 
    for (int count = 0; count < probsPerSet; count++)
    {   if (symbol == '+')
            doOneProblem(maxNum, numCorrect1);              
        if (symbol == '-')
            doOneSubtraction(maxNum, numCorrect2);                 
        if (symbol == '*')
            doOneMultiplication(maxNum, numCorrect3);                       
    }
}