sorting in link list

[niraj9997]

not getting sorting output need help tomorrow is submission

    void sorting()
      {
	int tid=0,count=0;
	struct node *q;

	q=start;

	while(q!=NULL)
	{
		q=q->next;
		count++;
	}
	q=start;
	for(int j=0;j<count;j++)
	{
		while(q->next=NULL)
		{
			if(q->id > q->next->id)
			{
				tid=q->id;
				q->id=q->next->id;
				q->next->id=tid;
				break;
			}
			q=q->next;

		}
	       //	start=q;
	}

[keskiverto]

We don't know what the struct node has. Only 'next' and 'id'?

Why do you assign a nullptr to a pointer within a condition expression on line 16?

[jlb]

You're really not providing enough information. But as a guess since you're title states you're working with a linked list shouldn't you be swapping the "structures" not the individual struct members?

[dhayden]

Consider using a for loop for iterating through the list:

for (q=start; q != NULL; q = q->next) {
    do_stuff;
}

As for the sort algorithm, move line 13 to jus be fore line 16.

[dhayden]

Consider using a for loop for iterating the list:

for (q = start; q !=NULL; q = q->next) {
    do_stuff;
}

If you do this, you'll probably realize that line 13 is out of place. It belongs with line 16.