Need help on array initializiation (Class attribute)

[Viiarge]

Hi, I recently started a personnal project : A Match-3 type of game (Where you match 3 of the same type and they go away).

I am aware I might not be able to finish the full thing, but I still wanted to give it a shot to learn stuff and practice.

So here's where I have a problem : I have 2 classes for this, one class for the gameBoard if you will and one for the tokens. The gameBoard class has an array of the tokens type, like this , 'Formes' is the tokens class :

 Formes m_gameBoard[5][5];

So when I initialize the tokens into the array, I've made a random constructor that sets a type and a position to each token object in it. Here's my problem :

The types and positions of ALL the objects in the array are the same, and I was expecting each token object to have a random position and type. They do go random, but all the same, if that makes sense.

Anywway, here's the 2 classes (.h and .cpp of each, respectively)

#pragma once
#include "regles.h"


class Formes
{
public:
	// Constructeurs
	Formes();
	// Destructeurs
	~Formes();
	// Méthodes
	bool moveIsValid(Formes p_autreForme);
	void deplacerFormes(Formes& p_autreForme);
	// Getters
	std::string getPosition();
	std::string getType();
	std::string getSymbole();
	static int getNbFormes();
	//Setters
	void setPosition(const std::string& p_nouvellePosition);

private:
	std::string m_position;
	std::string m_type;
	std::string m_symbole;
	static int nbFormes;
	
};

#include "Formes.h"

int Formes::nbFormes = 0;
// Constructeur par default
Formes::Formes()
{
	nbFormes++;

	srand(time(NULL));
	int rand5 = rand() % 5;
	int rand25 = rand() % 25;

	m_symbole = regles::listeFormes[rand5];
	m_position = regles::listeDeplacementsValides[rand25];
}

// Destructeur
Formes::~Formes()
{
	nbFormes--;
}

bool Formes::moveIsValid(Formes p_autreForme)
{
	bool deplacementHorizontal = false;
	bool deplacementVertical = false;

	// Vérification si même Position
	if (m_position == p_autreForme.m_position)
	{
		return false;
	}
	// Mouvement Horizontal
	else if (m_position[0] == p_autreForme.m_position[0])
	{	
		deplacementHorizontal = true;
		
		if ((int)(m_position[1]) == ((int)(p_autreForme.m_position[1]) + 1) || (int)(m_position[1]) == ((int)(p_autreForme.m_position[1]) - 1))
		{
			std::cout << (int)(m_position[1]) << std::endl;
			std::cout << (int)(p_autreForme.m_position[1]) << std::endl;
			return true;
		}
		
	}
	// Mouvement Vertical
	else if (m_position[1] == p_autreForme.m_position[1])
	{
		deplacementVertical = true;

		if ((int)(m_position[0]) == ((int)(p_autreForme.m_position[0]) + 1) || (int)(m_position[0]) == ((int)(p_autreForme.m_position[0]) - 1))
		{
			std::cout << (int)(m_position[0]) << std::endl;
			std::cout << (int)(p_autreForme.m_position[0]) << std::endl;
			return true;
		}
	}
	
	return false;
}

void Formes::deplacerFormes(Formes& p_autreForme)
{
	if (moveIsValid(p_autreForme) == true)
	{
		this->m_position.swap(p_autreForme.m_position);
	}
}

// Getters
std::string Formes::getPosition()
{
	return m_position;
}

std::string Formes::getType()
{
	return m_type;
}

std::string Formes::getSymbole()
{
	return m_symbole;
}

int Formes::getNbFormes()
{
	return nbFormes;
}

// Setters
void Formes::setPosition(const std::string& p_nouvellePosition)
{
	m_position = p_nouvellePosition;
}

#pragma once
#include "Formes.h"

class Tableau
{
public:
	Tableau(std::string p_nomGameBoard);
	~Tableau();

	void afficherGameBoard();

private:
	Formes m_gameBoard[5][5];
	std::string m_nomGameBoard;
	double m_temps;
};

#include "Tableau.h"



Tableau::Tableau(std::string p_nomGameBoard = "Match-3") :  m_nomGameBoard(p_nomGameBoard)
{
	
}


Tableau::~Tableau()
{
}

void Tableau::afficherGameBoard()
{
	system("cls");
	for (int i = 0; i < 5; i++)
	{
		std::cout << " | ";

		for (int j = 0; j < 5; j++)
		{
			std::cout << m_gameBoard[i][j].getSymbole() << " | ";
		}

		std::cout << std::endl;
	}
}

[AbstractionAnon]

formes.cpp line 9: Do not call srand() within a loop or a random number function. srand() sets the RNG to a particular starting point. Calling srand() repeatedly can cause the RNG to return the same random numbers. srand() should be called ONCE at the beginning of main().
http://www.cplusplus.com/reference/cstdlib/srand/

In your case, you're calling srand() from a constructor which is called repeatedly. Each call to rand() (lines 10,11) is going to assign exactly the same numbers to rand5 and rand25 for every Formes object that is constructed.

[Viiarge]

Yeah, that's what I did and It worked, thanks mate !