tic tac toe program
Line 5-6: Globals should be avoided.
Line 13: You're declaring a local named chesboard which goes out of scope when the function exists. You should be using the passed parameter (cb).
Line 22: This is going to cause a trap. You;re referencing an out of bounds location. i.e.
Line 32: You have a redundant term. cb[i][j] appears twice. No harm, but unnecessary.
Line 41: Why are you passing cb, if you insist on using the global chessboard?
Lines 67-85: I don't understand the point of these lines. You've already checked for a winner.
Line 13: You're declaring a local named chesboard which goes out of scope when the function exists. You should be using the passed parameter (cb).
Line 22: This is going to cause a trap. You;re referencing an out of bounds location. i.e.
|
|
Line 32: You have a redundant term. cb[i][j] appears twice. No harm, but unnecessary.
Line 41: Why are you passing cb, if you insist on using the global chessboard?
Lines 67-85: I don't understand the point of these lines. You've already checked for a winner.
Without seeing your updated code, I can't tell you what's wrong.
Line 32: Your condition is wrong.
That statement can only ever be true when i and j are 0.
You want:
Line 32: Your condition is wrong.
|
|
That statement can only ever be true when i and j are 0.
You want:
|
|
Last edited on
Topic archived. No new replies allowed.