vectors and arrays problem

[jamesfarrow]

I have a slight problem with my code! Every time i run it, it completes as its supoosed to do but the last element of the vectors do not match - element number 6 every time. See below!
5570594
Your Numbers: 2 7 10 17 42 47
Draw numbers: 2 7 10 17 42 43

8888795
Your Numbers: 12 29 37 38 44 58
Draw numbers: 12 29 37 38 44 45

428233
Your Numbers: 15 17 18 33 40 54
Draw numbers: 15 17 18 33 40 41

218508
Your Numbers: 18 24 40 46 48 50
Draw numbers: 18 24 40 46 48 52

As you can see element 6 is always not equal but the do-while loop condition must be satisfied for it to stop looping?
The number above the lines is how many times the do-while loop has ran and 6 random numbers have been drawn.

Please can any of you code gurus help - its annoying as i can't find the erorr, plus I am new to C++.

Thank you in advance.

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <vector>


int main()
	{
		int numberOfBalls = 59;//number of balls in lottery draw
		int line = 6;//numbers in a line
		int counter = 1;//variable increment count for vector
		int number = 1;//variable to store random numbers from 1 to 59
		
		bool generateNumbers[59];//array to store random lottery numbers
		
		std::vector <int> firstLine (line);//vector to store lottery line
		
		srand(time(NULL)); // randomise seed
		
		//set all elements of generateNumbers to false in array
		for ( int i = 1; i <= numberOfBalls; i++)
			{
				generateNumbers[i] = false;
			}
			
		//generate 6 random numbers and store them in that particular
		//element of the array, do this 6 time until counter == 6	
		while(counter <= line )
			{
				number = 1 + (rand() % 59);//random number between 1 and 59
				if ( !generateNumbers[number] )
					{
						generateNumbers[number] = true;
						counter++; //increment for stop condition of loop
					}
			}
			
			
		counter = 1;//reset counter to one again so we can use this value to
					//store the random number in that element
		for ( int i = 1; i <= numberOfBalls; i++ )
			{//loop through array to find values then store then in vector
				if ( generateNumbers[i] )
					{
						firstLine[counter] = i;
						counter++;
					}
			}
		//use for loop to print lottery line to screen	
		for ( int i = 1; i <= line; i++ )
			{
				std::cout << firstLine[i] << " ";
			}
			
		std::cout << std::endl;
		
//now generate a draw and compare both vectors for equality
//if both vectors are equal then end loop and lottery won
//use a variable to count how many draws were made before win
// use the same variables and arrays again but this time 
//a different vector to store

	std:: vector <int> lotteryDraw (line);//vector to store drawn numbers

	int numberOfDraws = 0;
	
	do{
		//set all elements of generateNumbers to false in array
		for ( int i = 1; i <= numberOfBalls; i++)
			{
				generateNumbers[i] = false;
			}
		
		//reset counter to one again before using
		counter = 1;
		number = 1;
		//generate 6 random numbers and store them in that particular
		//element of the array, do this 6 time until counter == 6	
		while(counter <= line )
			{
				number = 1 + (rand() % 59);//random number between 1 and 59
				if ( !generateNumbers[number] )
					{
						generateNumbers[number] = true;
						counter++; //increment for stop condition of loop
					}
			}
		
		counter = 1;//reset counter to one again so we can use this value to
					//store the random number in that element
		for ( int i = 1; i <= numberOfBalls; i++ )
			{//loop through array to find values then store then in vector
				if ( generateNumbers[i] )
					{
						lotteryDraw[counter] = i;
						counter++;
					}
			}
			
		//use for loop to print lottery line to screen	
		//for ( int i = 1; i <= line; i++ )
			//{
				//std::cout << lotteryDraw[i] << " ";
			//}
			
		numberOfDraws++;
		
		std::cout << numberOfDraws << std::endl;
			
		}while ( firstLine != lotteryDraw );
		
		if ( firstLine == lotteryDraw )
			{
				std::cout << "Your Numbers: ";
					for ( int i = 1; i <= line; i++ )
						{
							std::cout << firstLine[i] << " ";
						}
				std::cout << "\nDraw numbers: ";
					for ( int i = 1; i <= line; i++ )
						{
							std::cout << lotteryDraw[i] << " ";
						}
				std::cout << std::endl;
			}
		
		
		return 0;
		
	}
		

[Peter87]

Note that array and vector indices start at zero. If the vector has a size of 6 it means you should use index 0-5 to access the elements.

[Moschops]

First thing wrong I see; generateNumbers[0] (the first element) isn't being used, and you are using generateNumbers[59] which doesn't exist.

Arrays start counting at zero.

[jamesfarrow]

Cheers! Thanks very much. I thought tha I could use 1 to 59 for my numbers but clearly i was wrong.
I have altered my code to suit and will give it a try.
What I nee to realise then is that if number 1 is drawn randonly it will be stored inelemnt 0 and therefore number 59 stored in element 58 etc.

Is there no wy i can shift the whole array up by 1 thus making element zero 'redundant' in this application? Will I have to make my arays 60 insteadof 59 for this - or is it simplt too much hassle....

Thanks again

[Peter87]

No. It's just something you have to get used to. All you need to change when looping is to start at 0 and use < instead of <= in the condition.

for (int i = 0; i < numberOfBalls; i++)

[coder777]

If bool generateNumbers[60]; The indexes 1 to 59 are valid.

[jamesfarrow]

Thanks very much for your help! I have taken heed of your advice and made the alterations and it runs fine now - cheers!
I am new to C++ and haven't had any formal training/tuition and I am trying to 'teach myself' lol

I used a boolean array to save having to sort through the random numbers to put them in order, just set that particluar element to true then loop through untill the 6 true elements are then put into the vector for a comparison.

Is this a sound approach or is it better to sort the arrays and not use vectors?

Cheers!!