Simplifying

[ianheinze]

So I just wrote my code for this class and it works great, I was just wondering if there was a way I could simplify this? Just to pick up a few tips and tricks, what would you do to simplify the function?

Thanks!

//CSC150 Lab11
//Ian Heinze
//11/3/2015

#include <iostream>
using namespace std;


void reverse(char[]);

int main()
{

	char s[100];

	cout << "Please input your text: ";

	cin.getline(s, 100);

	cout << "Enter a line : " << s << endl;

	reverse(s);

	cout << "Reversed: " << s << endl;

	return 0;
}

void reverse(char *s) {
	char * i;
	for (i = s; *i; i++) {}
	 	char  temp;
	    while (s < i-1)
    {
	    	temp = *--i;
	        *i = *s;
	        *s++ = temp;
	}
}

[AbstractionAnon]

Your loop at line 31 does nothing. The {} indicate an empty action. Why is it there?

[ianheinze]

Ah, just had them in the wrong spot, here is the revised version

//CSC150 Lab11
//Ian Heinze
//11/3/2015

#include <iostream>
using namespace std;


void reverse(char[]);

int main()
{

	char s[100];

	cout << "Please input your text: ";

	cin.getline(s, 100);

	cout << "Enter a line : " << s << endl;

	reverse(s);

	cout << "Reversed: " << s << endl;

	return 0;
}

void reverse(char *s) 
{
	char * i;
	for (i = s; *i; i++)
        {
	 	char  temp;
	    while (s < i-1)
    {
	    	temp = *--i;
	        *i = *s;
	        *s++ = temp;
	}
}
}

[ianheinze]

I guess what I'm asking is if there's maybe any easier way to write the function?

[cire]

AbstractionAnon wrote:

Your loop at line 31 does nothing. The {} indicate an empty action. Why is it there?

ianheinze wrote:

Ah, just had them in the wrong spot, here is the revised version

The original for loop did what it was supposed to, which was position i to point to the end of string. Now, your code is wrong.

There are certainly different ways to write it, but the (first) implementation of your function is about as straightforward as you can get.

Better consistency with indentation is advised.

[AbstractionAnon]

Oops. Missed that the OP was using it to position i.
Thanks cire