Get the "name" of an element in a vector

[b4r0ck]

Hi, I wrote a very simple code, I want to display the name of the character, but I can't figure it out how I could. Thank you in advance.

class Player{
public:
	Player(string name);
	virtual ~Player();
	virtual void fight() = 0;
private:
	string _name;
};

Player::Player(string name){ _name = name;}
Player::~Player(){}


#include "Player.h"
#include <iostream>
using namespace std;

class Elf : public Player{
public:
	Elf(string elf_name);
	~Elf();
	void fight(){
		cout << "I kill you!" << endl;
	}
protected:
	string _elf_name;
};

Elf::Elf(string elf_name) : Player(elf_name){ _elf_name = elf_name;}
Elf::~Elf(){}

class Dwarf : public Player{
public:
	Dwarf(string dwarf_name);
	virtual ~Dwarf();
	void fight(){
		cout<< "Where's The Arkengem!?" << endl;
	}
protected:
	string _dwarf_name;
};

Dwarf::Dwarf(string dwarf_name) : Player(dwarf_name){_dwarf_name = dwarf_name;}
Dwarf::~Dwarf(){}

#include <iostream>
#include <vector>
#include "Player.h"
#include "Elf.h"
#include "Dwarf.h"
using namespace std;

int main(){
	vector<Player*> playerGroup;
	Elf* aElf = new Elf("Legolas");
	Dwarf* aDwarf = new Dwarf("Gimli");

	playerGroup.push_back(aElf);
	playerGroup.push_back(aDwarf);
	vector<Player*>::const_iterator itr;
	for(itr = playerGroup.begin(); itr != playerGroup.end(); itr++){
		cout << *itr; // FIXME
		(*itr)->fight();
	}

	return 0;
}

[JLBorges]

#include <iostream>
#include <string>
#include <vector>
#include <memory>

struct player
{
    explicit player( std::string n ) : name_(n) {}
    virtual ~player() = default ;

    virtual std::string name() const { return name_ ; }
    virtual void fight() = 0;

    private: std::string name_ ;
};

struct elf : player
{
    explicit elf( std::string elf_name ) : player( elf_name + " (elf)" ) {}

    virtual void fight() override { std::cout << "I kill you!\n" ; }
};

struct dwarf : player
{
    explicit dwarf( std::string dwarf_name ) : player( dwarf_name + " (dwarf)" ) {}

    virtual void fight() override { std::cout << "Where's The Arkengem!?\n" ; }
};

int main()
{
    std::vector< std::unique_ptr<player> > player_group ;
    player_group.push_back( std::make_unique<elf>("Legolas") ) ;
    player_group.push_back( std::make_unique<dwarf>("Gimli") ) ;

    for( const auto& p : player_group )
    {
        std::cout << p->name() << ": " ;
        p->fight() ;
    }

    std::cout << "----------------------------------\n" ;
    for( const auto& p : player_group )
    {
        auto& this_player = *p ;
        std::cout << this_player.name() << ": " ;
        this_player.fight() ;
    }

    std::cout << "----------------------------------\n" ;
    for( auto iter = player_group.begin() ; iter != player_group.end() ; ++iter )
    {
        const auto& p = *iter ;
        std::cout << p->name() << ": " ;
        p->fight() ;
    }

    std::cout << "----------------------------------\n" ;
    for( auto iter = player_group.begin() ; iter != player_group.end() ; ++iter )
    {
        auto& this_player = **iter ;
        std::cout << this_player.name() << ": " ;
        this_player.fight() ;
    }

    std::cout << "----------------------------------\n" ;
    for( std::size_t i = 0 ; i < player_group.size() ; ++i )
    {
        std::cout << player_group[i]->name() << ": " ;
        player_group[i]->fight() ;
    }
    // etc.
}

http://coliru.stacked-crooked.com/a/425686806a955c46

[b4r0ck]

Thank you, I would like to know if there's a way of solving it that doesn't require a change like this

[mutexe]

Don't have name members in your derived classes, and add a getName() to Player class.

[b4r0ck]

Thank you so much, it works!