Inhertiance error help

I am getting this error in my subclass of Monster. What is going on how can I fix it so the error doesn't show up. It says No matching function from call to Enemy::Enemy()
Monster::Monster(int,int) already defined here.

Monster.cpp

#include "Monster.h"

Monster::Monster(int EnemyHealth,int EnemyMana)
{
    //ctor
}


int Monster::dropxp(int enemydropxp){


}

Monster.h

#ifndef MONSTER_H
#define MONSTER_H
#include "Enemy.h"



class Monster : public Enemy
{
     public:
         Monster() {};
         Monster(int EnemyHealth,int EnemyMana):
             Enemy(int EnemyHealth,int EnemyMana);
    void TheenemyHealth()
    {
        int Enemyhealth = 100;
    }
    int EnemyDamage(int EnemyAttack){
    int Attack = EnemyAttack;
    Attack = 5;
    }
    int dropxp(int enemyxpdrop);
    private:

};

#endif // MONSTER_H

Enemy.h

#ifndef ENEMY_H
#define ENEMY_H


 class Enemy
{
public:
    Enemy(int EnemyHealth,int EnemyMana);
    ~Enemy();
      virtual void TheenemyHealth(){}
     virtual int EnemyDamage(int EnemyAttack){
int  Attack = EnemyAttack;
     }
virtual int dropxp(int enemyxpdrop);



private:
  int Attackpower= 0;
  int Strenght = 0;
  int Enemyxp= 0;

};

Enemy.cpp

#include "Enemy.h"

Enemy::Enemy(int EnemyHealth,int EnemyMana)
{
    Attackpower;
    Strenght;
    Enemyxp;

}

Enemy::~Enemy()
{
    //dtor
}

LB (13399)

Blackhart98 wrote:

11
12

         Monster(int EnemyHealth,int EnemyMana):
             Enemy(int EnemyHealth,int EnemyMana);

This is nonsensical. What is this even supposed to mean?

Last edited on

JLBorges (13770)

class Enemy
{
    public:
        Enemy() = default ; // explicitly defaulted

        // see: http://en.cppreference.com/w/cpp/language/initializer_list
        Enemy( int EnemyHealth, int EnemyMana ) : health(EnemyHealth), mana(EnemyMana) {}

    // ...

    private:
        int health = 0 ;
        int mana = 0 ;
};

class Monster : public Enemy
{
    public:
        // http://www.stroustrup.com/C++11FAQ.html#inheriting
        using Enemy::Enemy ; // inheriting constructor

        // ...

    private:
        int whatever = 0 ; // note: has in-class member initialiser
};

class Monster2 : public Enemy
{
    public:
        Monster2() : whatever(0) {} // augmented by the implementation
                                    // to default-construct the base class object

        Monster2( int EnemyHealth, int EnemyMana )
            : Enemy(EnemyHealth,EnemyMana), // initialise base class object
              whatever(0) {} // initialise member object
        // ...

    private:
        int whatever ;
};

Blackhart98 (97)

@LB how please tell me I am still trying to figure this mess out.

LB (13399)

Blackhart98 wrote:
@LB how please tell me I am still trying to figure this mess out.

You want me to say: You are still trying to figure this mess out.

Jokes aside, please either answer my question or ask a question about JLBorges' code.

Blackhart98 (97)

Well I got this code from stackoverflow.

1
2

Monster(int EnemyHealth,int EnemyMana):
             Enemy(int EnemyHealth,int EnemyMana);

What do you think should be here for the inhertiance to work? Like I said the errors keeps coming about I just need to know the right structure to put the Monster class in.

Gamer2015 (810)

You can't write the initializer list in the decleration, you have to make it in the implementation.
Monster(int EnemyHealth,int EnemyMana); // decleration

1
2
3

Monster::Monster(int EnemyHealth,int EnemyMana) // implementation
 : Enemy(int EnemyHealth,int EnemyMana) 
{}

But you could just write it in the header file as well if you want:

class Monster : public Enemy
{
public:
    Monster(int EnemyHealth,int EnemyMana)
     : Enemy(EnemyHealth, EnemyMana) 
    {}
    // ...
};

Last edited on

LB (13399)

This is wrong:

1
2
3

Monster::Monster(int EnemyHealth,int EnemyMana) // implementation
 : Enemy(int EnemyHealth,int EnemyMana) 
{}

This is right:

1
2
3

Monster::Monster(int EnemyHealth,int EnemyMana) // implementation
 : Enemy(EnemyHealth, EnemyMana) 
{}

You do not specify types when passing parameters.

Gamer2015 (810)

Oh yeah, I just copied the stuff above and didn't look, my bad

Blackhart98 (97)

Thanks it work

Last edited on

Topic archived. No new replies allowed.

C++

Forum

Inhertiance error help