Validating if First name & Last Name is Typed Correctly

[Doge1]

I need to write a program that checks if first name and last name are correctly typed in, the program need to checks if first letter of name is uppercase, it return "Correct", if it's not it returns "Incorrect" same for last name.

I managed to write code that does this but only for first name, and i have problem, when i write name for example JOHN it says "correct", same for John. The only correct thing would be ex John Smith.

I searched google a lot but could not find anything on this.

#include <iostream>
#include <string>

using namespace std;

int main ()
{

  std::string str;
  cout << "Type First Name: ";
  cin >> str;

    if(isupper(str[0]))
    {
        cout << "Correct!" <<endl;
    }

    else
    {
        cout << "Incorrect!" <<endl;
    }


  system("pause");
  return 0;
}

[mutexe]

easiest thing would be to ask the user for their first name and perform your test (like you are doing), and then repeat the question but ask for the user's surname and perform the same test. i.e. wrap up the testing code into a function.

[Doge1]

easiest thing would be to ask the user for their first name and perform your test (like you are doing), and then repeat the question but ask for the user's surname and perform the same test. i.e. wrap up the testing code into a function.

Yeah i can do that, but my main problem for now is that this code returns "correct" for JOHN and John when only correct thing would be John, this is just example for a name.

[mutexe]

Then you need to check all characters in your string. That the first one is uppercase and all the rest are lower.
Use a for loop for that.

[Doge1]

I know but how

[mutexe]

i've done this in a very long-winded way so you can see what's going on.

#include <iostream>
#include <string>

using namespace std;

int main ()
{

	string str;
	cout << "Type First Name: ";
	cin >> str;

	

	bool firstCharUpper(false);
	bool theOthersAllLower(true);

	for(int i = 0;i < str.size();++i)
	{	
		if(i==0)
		{
			if(isupper(str[i]))
			{
				firstCharUpper = true;
			}
		}
		else
		{
			if(isupper(str[i]))
			{
				theOthersAllLower = false;
				break;
			}
		}
	}

	bool allGood = firstCharUpper && theOthersAllLower;

	if(allGood)
	{
		cout << "Correct!" <<endl;
	}
	else
	{
		cout << "Incorrect!" <<endl;
	}
	
	return 0;
}

and then stick it in a function;

#include <iostream>
#include <string>

using namespace std;

bool ValidString(string str);

int main ()
{

	string str;
	cout << "Type First Name: ";
	cin >> str;	

	if(ValidString(str))
	{
		cout << "Correct!" <<endl;
	}
	else
	{
		cout << "Incorrect!" <<endl;
	}
	
	return 0;
}

bool ValidString(string str)
{
	bool firstCharUpper(false);
	bool theOthersAllLower(true);

	for(int i = 0;i < str.size();++i)
	{	
		if(i==0)
		{
			if(isupper(str[i]))
			{
				firstCharUpper = true;
			}
		}
		else
		{
			if(isupper(str[i]))
			{
				theOthersAllLower = false;
				break;
			}
		}
	}

	return (firstCharUpper && theOthersAllLower);
}

[keskiverto]

There seems to be a parallel thread on this topic: http://www.cplusplus.com/forum/beginner/167905/

It is more efficient (and polite) to keep discussion (about one topic) in one thread.

[mutexe]

grrr i didnt see his second sneaky post :/