getting error when erasing element from vector

[AmazingBKaiser]

It says that vector erase iterator outside range

Battle.cpp

#include "Battle.h"
#include "SetUp.h"



Battle::Battle(){

	
	SetUp _setUp;

	
	
	p1 = _setUp.getPlayer(1);
	p2 = _setUp.getPlayer(2);
	cur_player = p1;
	p1.setChoosenMove(p1.getPokeman().getMoves()[0]);
	p2.setChoosenMove(p2.getPokeman().getMoves()[0]);
	system("cls");
	cout << "\n**********LET THE BATTLE BEGIN************\n\n\n";
	system("PAUSE");
	system("cls");
	
	while (p1.getPokeman().getHealth() > 0 && p2.getPokeman().getHealth() > 0){
		printBattle();
	}
	cout << "Fight has ended";

	
	return;
}

void Battle::printBattle(){
	system("cls");
	Moves move;
	cout << p1.getName() << " with " << p1.getPokemanName() << "...................................................." << "hp:" << p1.getPokeman().getHealth() << endl << endl << endl << endl << "     [" << move.getName(p1.getChoosenMove()) << "]" << endl << "" << move.getName(p1.getOtherMoves(p1)[0]) << "  " << move.getName(p1.getOtherMoves(p1)[1]) << "  " << move.getName(p1.getOtherMoves(p1)[2]) << endl << endl << endl << endl << endl << endl << endl << endl << p2.getName() << " with " << p2.getPokemanName() << "...................................................." << "hp:" << p2.getPokeman().getHealth() << endl << endl << endl << endl << "     [" << move.getName(p2.getChoosenMove()) << "]" << endl << "" << move.getName(p2.getOtherMoves(p2)[0]) << "  " << move.getName(p2.getOtherMoves(p2)[1]) << "  " << move.getName(p2.getOtherMoves(p2)[2]);;
	//setChoosenMove(cur_player);
	setChoosenMove(p1);

	system("cls");
	return;

}

void Battle::setChoosenMove(Player& pl){
	Moves move;

	string input;
	
	cin >> input;
	
	if (input == "d" || input == "a" || input == "s"){
		if (input == "s"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[1]);
			pl.getOtherMoves(pl).erase(pl.getOtherMoves(pl).begin() + pl.getChoosenMoveNum(pl.getChoosenMove()));
			input = "";
		}
		if (input == "a"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[0]);
			pl.getOtherMoves(pl).erase(pl.getOtherMoves(pl).begin() + pl.getChoosenMoveNum(pl.getChoosenMove()));
			input = "";
		}
		if (input == "d"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[2]);
			pl.getOtherMoves(pl).erase(pl.getOtherMoves(pl).begin() + pl.getChoosenMoveNum(pl.getChoosenMove()));
			input = "";
		}
	}
	else{
		cout << "bad Input";
	}

	
	
	return;
}






Moves.cpp

#include "Moves.h"



Moves::Moves(string name, float acu, int damage)
{
	_name = name;

}
Moves::Moves(){


}

void Moves::setMoves(vector <Moves> moves){

	
	
	_moves = moves;
}

vector<Moves> Moves::getMoves (){
	return _moves;

}


Moves Moves::movesList(int index){
	vector <Moves> movesList;
	Moves WaterBlast("WaterBlast", 100, 50);
	movesList.push_back(WaterBlast);
	Moves Scratch("Scratch", 100, 50);
	movesList.push_back(Scratch);
	Moves Fireball("Fireball", 100, 50);
	movesList.push_back(Fireball);
	Moves Ram("Ram", 100, 50);
	movesList.push_back(Ram);
	Moves SC("Scare", 100, 50);
	movesList.push_back(SC);
	Moves PK("Peck", 100, 50);
	movesList.push_back(PK);
	Moves CnTrT("Consentrate", 100, 50);
	movesList.push_back(CnTrT);
	Moves SA("SandAttack", 100, 50);
	movesList.push_back(SA);
	Moves DdG("Dodge", 100, 50);
	movesList.push_back(DdG);
	Moves LW("LeafWind", 100, 50);
	movesList.push_back(LW);
	Moves ShK("Shock", 100, 50);
	movesList.push_back(ShK);
	Moves Blst("Blast", 100, 50);
	movesList.push_back(Blst);

	return movesList[index - 1];
}

string Moves::getName(Moves move){
	return move._name;
}

bool Moves::areNotMovesEqual(Moves move1, Moves move2){
	if (move1.getName(move1) == move2.getName(move2)){
		return false;
	}
	else{
		return true;

	}
}





Player.cpp

#include "Player.h"


Player::Player(string name)
{
	_name = name;
}
Player::Player(){

}
void Player::setPokeman(Pokemans pokeman){
	_pokeman = pokeman;
}

Pokemans Player::getPokeman(){
	return _pokeman;
}

string Player::getPokemanName(){
	return _pokeman.getName();
}

string Player::getName(){
	return _name;
}

void Player::setPlayerName(string name){


	return;

}


Moves Player::getChoosenMove(){
	return _choosenMove;
}

vector <Moves> Player::getOtherMoves(Player player){
	string name = _choosenMove.getName(_choosenMove);
	Moves move;
	


	if (name == move.getName(player.getPokeman().getMoves()[0])){
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
		

	}
	if (name == move.getName(player.getPokeman().getMoves()[1])){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
		

	}
	if (name == move.getName(player.getPokeman().getMoves()[2])){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
	

	}
	if (name == move.getName(player.getPokeman().getMoves()[3])){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);


	}

	
	
	return _otherMoves;
}

void Player::setChoosenMove(Moves move){
	_choosenMove = move;
	
	return;

}

int Player::getChoosenMoveNum(Moves move){
	int in = 0;
	for (int i = 0; move.areNotMovesEqual(move, _otherMoves[i]); i++){

		in = i;
	}
	return in;
}

It happens rigth after the function areNotMovesEqual return true

[Peter87]

The problem has to do with that getOtherMoves returns a copy of the vector.

[AmazingBKaiser]

I already tried to just erase 1 element by hard codding it and it works.

[AmazingBKaiser]

actually now that you say it, it seems like it only returns a move that has the same name, but not the same stats.
what should i do to make it return the move

[Peter87]

Each time you call the getOtherMoves function, the code of that function will run.

Not sure that function inserts any elements to _otherMoves because the move object that you create on line 203 is a new Moves object with an empty name. If you are not adding anything to _otherMoves elsewhere it probably means it is empty.

Edit: I was a bit confused by your getName function. It doesn't make sense that you have to pass another Moves object as argument to it. Just make it return the name of the current object, like you do for the Player class, and then just call it on the object that you want to get the name of:

Moves move;
if (name == move.getName(player.getPokeman().getMoves()[0])){
if (name == player.getPokeman().getMoves()[0].getName()){

You are doing things like pl.getOtherMoves(pl)[1] which will not work unless the vector has at least 2 elements. Just saying, I don't know if it's always the case.

The vector that is returned is a copy of _otherMoves because the return type of the function is vector<Moves>. If you don't want a copy, then you probably want to return a reference instead (vector<Moves>&).

[AmazingBKaiser]

thanks for the advice, thought I dont knon why I made it that way to begin with :D
Sadly it doesnt fix the errror, so if you have any other ideas I would love to hear them

[AmazingBKaiser]

I noticed that the _otherMoves gets to 9 or 12 element which are the correct ones but looped

[AmazingBKaiser]

fixed the _otherMoves problem, it happend because everytime I called getOtherMoves function it would add more moves to the vector. Now I just clear the vector everytime it goes throught the code.

[AmazingBKaiser]

Fixed!!!!! I didnt even have to erase anything, because I already had a function that updates the _otherMoves and that is getOtherMoves(). here is what I changed


Battle.cpp

#include "Battle.h"
#include "SetUp.h"



Battle::Battle(){

	
	SetUp _setUp;

	
	
	p1 = _setUp.getPlayer(1);
	p2 = _setUp.getPlayer(2);
	cur_player = p1;
	p1.setChoosenMove(p1.getPokeman().getMoves()[0]);
	p2.setChoosenMove(p2.getPokeman().getMoves()[0]);
	system("cls");
	cout << "\n**********LET THE BATTLE BEGIN************\n\n\n";
	system("PAUSE");
	system("cls");
	
	while (p1.getPokeman().getHealth() > 0 && p2.getPokeman().getHealth() > 0){
		printBattle();
	}
	cout << "Fight has ended";

	
	return;
}

void Battle::printBattle(){
	system("cls");
	Moves move;
	cout << p1.getName() << " with " << p1.getPokemanName() << "...................................................." << "hp:" << p1.getPokeman().getHealth() << endl << endl << endl << endl << "     [" << p1.getChoosenMove().getName() << "]" << endl << "" << p1.getOtherMoves(p1)[0].getName() << "  " << p1.getOtherMoves(p1)[1].getName() << "  " << p1.getOtherMoves(p1)[2].getName() << endl << endl << endl << endl << endl << endl << endl << endl << p2.getName() << " with " << p2.getPokemanName() << "...................................................." << "hp:" << p2.getPokeman().getHealth() << endl << endl << endl << endl << "     [" << p2.getChoosenMove().getName() << "]" << endl << "" << p2.getOtherMoves(p2)[0].getName() << "  " << p2.getOtherMoves(p2)[1].getName() << "  " << p2.getOtherMoves(p2)[2].getName();
	//setChoosenMove(cur_player);
	setChoosenMove(p1);

	system("cls");
	return;

}

void Battle::setChoosenMove(Player& pl){
	

	string input;
	
	cin >> input;
	
	if (input == "d" || input == "a" || input == "s"){
		
		if (input == "a"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[0]);
			
			pl.getOtherMoves(pl);
			
			cout << "erased";
			input = "";
		}
		if (input == "s"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[1]);
			
			
			pl.getOtherMoves(pl);
			cout << "erased";
			input = "";
		}
		if (input == "d"){
			pl.setChoosenMove(pl.getOtherMoves(pl)[2]);
			
			
			pl.getOtherMoves(pl);
			cout << "erased";
			input = "";
		}
	}
	else{
		cout << "bad Input";
	}

	
	
	return;
}

Player.cpp

#include "Player.h"


Player::Player(string name)
{
	_name = name;
}
Player::Player(){

}
void Player::setPokeman(Pokemans pokeman){
	_pokeman = pokeman;
}

Pokemans Player::getPokeman(){
	return _pokeman;
}

string Player::getPokemanName(){
	return _pokeman.getName();
}

string Player::getName(){
	return _name;
}

void Player::setPlayerName(string name){


	return;

}


Moves Player::getChoosenMove(){
	return _choosenMove;
}

vector <Moves> Player::getOtherMoves(Player player){
	string name = _choosenMove.getName();
	Moves move;
	
	_otherMoves.clear();

	if (name == player.getPokeman().getMoves()[0].getName()){
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
		

	}
	if (name == player.getPokeman().getMoves()[1].getName()){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
		

	}
	if (name == player.getPokeman().getMoves()[2].getName()){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[3]);
	

	}
	if (name == player.getPokeman().getMoves()[3].getName()){
		_otherMoves.push_back(player.getPokeman().getMoves()[0]);
		_otherMoves.push_back(player.getPokeman().getMoves()[1]);
		_otherMoves.push_back(player.getPokeman().getMoves()[2]);


	}

	
	
	return _otherMoves;
}

void Player::setChoosenMove(Moves move){
	_choosenMove = move;
	
	return;

}

int Player::getChoosenMoveNum(Moves move){
	int in = 0;
	for (in; move.areNotMovesEqual(move, _otherMoves[in]); in++){

		
		
		
	}
	cout << _otherMoves[in].getName();
	return in;
}

Thanks for the help