Need Help With Functions

[E8AXSL3A]

I am writing a code that requires the three functions listed. I keep getting the following error messages and I absolutely do not know what to do. Any help is appreciated!!

Error 6 error C2082: redefinition of formal parameter 'commissionOwed' c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 42 1 Chp 10 Commiss Lab Test
Error 2 error C2440: '==' : cannot convert from 'double (__cdecl *)(double)' to 'double' c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 17 1 Chp 10 Commiss Lab Test
Error 4 error C2440: '==' : cannot convert from 'double (__cdecl *)(void)' to 'double' c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 18 1 Chp 10 Commiss Lab Test
Error 1 error C2446: '==' : no conversion from 'double (__cdecl *)(double)' to 'double' c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 17 1 Chp 10 Commiss Lab Test
Error 3 error C2446: '==' : no conversion from 'double (__cdecl *)(void)' to 'double' c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 18 1 Chp 10 Commiss Lab Test
Error 5 error C3861: 'displayCommission': identifier not found c:\users\alec\documents\visual studio 2013\projects\chp 10 commiss lab test\chp 10 commiss lab test\source.cpp 19 1 Chp 10 Commiss Lab Test
8 IntelliSense: cannot determine which instance of overloaded function "getCommission" is intended c:\Users\Alec\Documents\Visual Studio 2013\Projects\Chp 10 Commiss Lab Test\Chp 10 Commiss Lab Test\Source.cpp 18 20 Chp 10 Commiss Lab Test
7 IntelliSense: operand types are incompatible ("double" and "double (*)(double monthlySales)") c:\Users\Alec\Documents\Visual Studio 2013\Projects\Chp 10 Commiss Lab Test\Chp 10 Commiss Lab Test\Source.cpp 17 14 Chp 10 Commiss Lab Test

--------------------------------------------

#include<iostream>
#include<iomanip>
using namespace std;

//Function Prototype
double getMonthlySales(double);
double getCommission();
void diplayCommission(double commissionOwed);

int main()
{
	//Declare Variables
	double salesAmount = 0.0;
	double commissionOwed = 0.0;

	//Call Functions to Calculate the Employees Commission Owed
	salesAmount == getMonthlySales;
	commissionOwed == getCommission;
	displayCommission(commissionOwed);
	


	system("pause");
	return 0;

}
//End of Main Function


//**Function Definitions**
double getMonthlySales(double monthlySales)
{
	double salesAmount = 0.0;
	cout << "Enter Your Total Monthly Sales :$" << endl;
	cin >> salesAmount;
	return salesAmount;
}
//End of Get Monthly Sales Function

double getCommission(double commissionOwed, double salesAmount)
{
	double commissionOwed = 0.0;

	if (salesAmount > 0 && salesAmount <= 19999)
		commissionOwed = salesAmount*.04;
	else if (salesAmount >= 20000 && salesAmount <= 29999)
		commissionOwed = salesAmount*.05;
	else if (salesAmount >= 30000 && salesAmount <= 39999)
		commissionOwed = salesAmount*.06;
	else if (salesAmount >= 40000 && salesAmount <= 49999)
		commissionOwed = salesAmount*.07;
	else  (salesAmount >= 50000);
	commissionOwed = salesAmount*.08;
	
	return commissionOwed;
}
//End of Get Commission Function

void displayCommission(double commissionOwed)
{
	cout << "Total Commission: $" << fixed << setprecision(2) << commissionOwed << endl;
}
//End of Display Commission Function

[Bdanielz]

Please post your question in code tags
its harder to read the way you have it posted.
Also you are more likely to get help if you do so.
http://www.cplusplus.com/articles/jEywvCM9/

[E8AXSL3A]

I'm sorry I am still new and learning C++, what do you mean by code tags?

[Bdanielz]

http://www.cplusplus.com/articles/jEywvCM9/ <-- look at that link.

[E8AXSL3A]

Sorry thanks, is that the proper way to post questions on forum?

[Bdanielz]

Np. I wouldn't sweat it too much, using code tags will increase your chances of getting help.

[Bdanielz]

you have a few issues. Lets start with one at at time.

double getMonthlySales(double);
double getCommission();
void diplayCommission(double commissionOwed);

the above is wrong.
do you know why?

[E8AXSL3A]

Not too sure, but I can take a guess... should the parentheses be empty? (not say double etc)

[Bdanielz]

look at this.
http://www.cplusplus.com/doc/tutorial/functions/
then guess again. you sound like your on the right track.
it all boils down too what you want to do.

[E8AXSL3A]

I think it has something to do with how I'm naming my variables? I am honestly clueless my brain is fried haha

[E8AXSL3A]

I think I have a problem with updating the variable and it following through the whole code through each function...?

[JLBorges]

#include<iostream>
#include<iomanip>
using namespace std;

//Function Prototype
//double getMonthlySales(double);
int getMonthlySales(); // input: nothing   return: monthly sales amount
                       // sales amount is an integer
                       // (because we have <= 19999 and next >= 20000)

// double getCommission();
double getCommission( int salesAmount ) ; // input: sales amount   return: commission

// void diplayCommission(double commissionOwed);
void displayCommission(double commissionOwed); // input: commission   return: nothing

int main()
{
    /*
	//Declare Variables
	double salesAmount = 0.0;
	double commissionOwed = 0.0;

	//Call Functions to Calculate the Employees Commission Owed
	salesAmount == getMonthlySales;
	commissionOwed == getCommission;
	displayCommission(commissionOwed);
    */

    const int salesAmount = getMonthlySales() ;
    const double commissionOwed = getCommission(salesAmount) ;
    displayCommission(commissionOwed) ;


	// system("pause");
	//return 0;

}
//End of Main Function


//**Function Definitions**
// double getMonthlySales(double monthlySales)
int getMonthlySales()
{
	// double salesAmount = 0.0;
	int salesAmount = 0 ;
	cout << "Enter Your Total Monthly Sales :$" << endl;
	cin >> salesAmount;
	return salesAmount;
}
//End of Get Monthly Sales Function

// double getCommission(double commissionOwed, double salesAmount)
double getCommission( int salesAmount )
{
        double commissionOwed = 0.0;

	if (salesAmount > 0 && salesAmount <= 19999)
		commissionOwed = salesAmount*.04;
	else if (salesAmount >= 20000 && salesAmount <= 29999)
		commissionOwed = salesAmount*.05;
	else if (salesAmount >= 30000 && salesAmount <= 39999)
		commissionOwed = salesAmount*.06;
	else if (salesAmount >= 40000 && salesAmount <= 49999)
		commissionOwed = salesAmount*.07;
	// else  (salesAmount >= 50000);
	else // (salesAmount >= 50000)
	    commissionOwed = salesAmount*.08;

	return commissionOwed;
}
//End of Get Commission Function

void displayCommission(double commissionOwed)
{
	cout << "Total Commission: $" << fixed << setprecision(2) << commissionOwed << endl;
}
//End of Display Commission Function 

[shamieh]

First problem, don't do this.
double getMonthlySales(double); In your function prototype: Name the variable inside your function parameters. For example, instead of

double getMonthlySales(double); use something so that you will know what you are doing i.e. -> getMonthlySales(double monthlySales);

Also there are other problems in your code. Let's start with the first one.

Your code:
salesAmount == getMonthlySales;

You're saying "Is the data in salesAmount equivalent to the getMonthlySales variable's data ? The problem is getMonthlySales isn't a variable, no where have you defined it anywhere in your main function code. I think what you are trying to say is take the result of what the getMonthlySales(double imAVariableName) function returns and store it in the variable salesAmount

If that's the case you will have to use the assignment operator which is =

//Using the assignment operator
int imaVar; //Declares a variable imaVar of type integer
imaVar = 33; //Initializes the variable imaVar with data. i.e. ASSIGNS the number 33 to the
                     //variable imaVar

//Using the equivalent to operator
bool cat = true; //Assignment operator again used to initialize and declare the variables
bool dog = false; // ^
int userinput;

//Assume a user already has a cat (this is just an example)
//Assume the user enters 1 for input
cout << "If you have a dog type 1 "; cin >> userinput;
//If the user has a dog, set dog to be TRUE
  if(userinput == 1)
    dog = true;

//NOTE: Remember that = is NOT THE SAME as ==
//When you say int variableName == 1 you are NOT assigning 1 to that variable! 

//Now using the equivalent to operator
if(dog == cat) //If DOG (true) is equal to CAT(true) then proceed
  cout << "You have a DOG and a CAT!" << endl;


//Since dog = true & cat = true also then True & True evaluates to True
//Therefore the expression will evaluate to true? Make sense?

Instead I think what you are looking for is something like this:

//Declare Variables
	double salesAmount = 0.0;
	double commissionOwed = 0.0;
	double monthlySales = 0.0; //declares a variable for you to pass through your function, you do want to use your function right?

         cout << "What is your monthly sales?"; cin >> monthlySales;
	//Call Functions to Calculate the Employees Commission Owed
	salesAmount = getMonthlySales(monthlySales); //What this will do is set whatever  
       //double you returned from the getMonthlySales(double imaVarName) function to the   
       //variable salesAmount as it looks like you want it to 

Note: There are still more problems in the code. Let me know if you have any questions about what I'm saying.

[E8AXSL3A]

Wow you are the man, I am still reading through the code but could you point out the main changes/errors I had?

[shamieh]

My revisions or JLBorges?

[E8AXSL3A]

@shamieh I can follow your changes since you broke it off into a block, I was referring to JLBorges

[shamieh]

@jrob Also notice that JLBorges took the parameters out of your getMonthlySales function. Not sure if that was a requirement of your teacher or not, but with JLBorges solution you can not do what I proposed above. Nevertheless, his solution is still a valid solution.

[JLBorges]

> could you point out the main changes/errors I had?

Your original code is commented out, and just below it is the changed code.
For example:

//double getMonthlySales(double); *** this was the original code ****

int getMonthlySales(); // input: nothing   return: monthly sales amount
                       // sales amount is an integer
                       // (because we have <= 19999 and next >= 20000) 

In general, when we consider a function, we should be thinking about:
a. What does this function accept as input?
b. What does it do?
c. What does it return as the result?

When we write the function, it would accept the inputs, do what it does and return a result (if any).

When we call the function, we would pass the input arguments, and use the result that it returns.

For example: pass salesAmount as the input to the function, and store the result returned in commissionOwed

const double commissionOwed = getCommission(salesAmount) ;