Impossible-To-Win Tic Tac Toe
Hi,
I am a beginner in c++ (been studying it for 2 and a half months) and I wrote this tic tac toe game. Even though it is unbeatable (at least I believe so), the code seems pretty sloppy and too long to me, so I am curious if someone experienced could tell me what are the examples of bad programming habits in this code, and how I could shrink it.
Thanks in advance :)
I am a beginner in c++ (been studying it for 2 and a half months) and I wrote this tic tac toe game. Even though it is unbeatable (at least I believe so), the code seems pretty sloppy and too long to me, so I am curious if someone experienced could tell me what are the examples of bad programming habits in this code, and how I could shrink it.
Thanks in advance :)
|
|
|
|
| what are the examples of bad programming habits in this code |
1) Use of globals
2) Use of
using namespace std;3) Use of
system("pause");4) The game is not replayable. If you want to play again, you have to restart the program.
Other than the use of cout, this really isn't C++. Consider making your board a class and your functions members of that class. If field were a member of that class, you wouldn't have to pass it to every function.
Ok, I will try to re-write it, but we haven't really got into object-oriented programming on my college, and they haven't yet mentioned classes. Anyway I will look into it and try.
Thank you very much! :)
Thank you very much! :)
i thought it was unbeatable, but i beat it in 2 tries, but not bad the bot got me in first try lol
My compiler told me you didn't initialize varibles in function attack(). I didn't check your code, but you have to be careful with this mistake
Nice job. The code is well organized. I especially want to congratulate you on realizing that something is wrong. That's the sort of intuition that helps beginners become experts.
The same technique to compute the row & column can be used in many places.
You also have a lot of code that basically looks like this:
for each row do foo
for each column do foo
for each diagonal do foo
You can parameterize this by creating a function called foo() and passing it the positions of 3 squares in a row, column or diagonal. PLEASE NOTE: the code below is untested:
Now you can call foo() for each row, column and diagonal like this:
For example, attack() can be done like this:
// attack the group. If you can attack then return true and set i and j to the attack position:
Using these two changes throughout the code should shorten it dramatically.
isTaken() is very inefficient because you count your way up to find the i and j coordinates that correspond to pos. It would be much shorter to compute it instead. Also note that you can return a bool value directly instead of doing if (condition) return true; else return false;: |
|
The same technique to compute the row & column can be used in many places.
You also have a lot of code that basically looks like this:
for each row do foo
for each column do foo
for each diagonal do foo
You can parameterize this by creating a function called foo() and passing it the positions of 3 squares in a row, column or diagonal. PLEASE NOTE: the code below is untested:
|
|
Now you can call foo() for each row, column and diagonal like this:
|
|
For example, attack() can be done like this:
// attack the group. If you can attack then return true and set i and j to the attack position:
|
|
Using these two changes throughout the code should shorten it dramatically.
Topic archived. No new replies allowed.