Fun with Functions, my solution

[Victor89]

Hello all!

I want to share my solution to the beginner problem Fun with Functions.

I hope that someone will find it helpful!

Any suggestion for improvement are welcomed as well!

Requires: variables, data types, and numerical operators
basic input/output
logic (if statements, switch statements)
loops (for, while, do-while)
functions

Write a function titled say_hello() that outputs to the screen "Hello"

★ Modify the function so that it takes an integer argument and says hello a number of times equal to the value passed to it.

★★ Make another function that takes two integers arguments and then returns an integer that is the product of the two integers.
(i.e., integer1: 4, Integer2: 5 returns: 20)

★★★ Make a function called half() that takes an integer argument. The function must print the number it received to the screen, then the program should divide that number by two to make a new number. If the new number is greater than zero the function then calls the function half() passing it the new number as its argument. If the number is zero or less than the function exits

Call the function half() with an argument of 100, the screen output should be
100
50
25
...
...
1.

#include <iostream>
#include <conio.h>

using namespace std;

void say_hello(int);
int product(int, int);
void half(int number);

int main()
{
	int n;
	cout << "n="; cin >> n;
	
	say_hello(n);

	cout << endl;
	int a, b;
	cout << "a="; cin >> a;
	cout << "b="; cin >> b;
	cout << product(a,b);
	cout << endl;

	int number;

	cout << "number="; cin >> number;
	half(number);
	_getch();
}

void say_hello(int n)
{
	for(int i=0; i<n; i++)
	{
	cout << "Hello ";
	}
}

int product(int a, int b)
{
	int result;
	result = a * b;
	return result;
}

void half(int number)
{
	if(number == 0)
	{
		cout << "Program will exit!";
		return;
	}
	do
	{
	cout << number << endl;
	number = number / 2;
	} while(number != 0);
	
}

[LB]

Do not use <conio.h> - it is not part of the C++ standard.
https://en.wikipedia.org/wiki/Conio.h

You have some indentation mistakes (lines 35, 55, 56)

Your result variable on line 41 is useless - you could replace the three lines with one line return a * b;

You should try to complete this exercise without the line using namespace std;

[Victor89]

What is so bad about indentation?

[xenovia12]

@LB

Do not use <conio.h> - it is not part of the C++ standard.

I'm using it for _getch();

[MikeyBoy]

Victor89 wrote:

What is so bad about indentation?

Your indentation needs correcting at lines 35, 55 and 56.

[LB]

Lorence30 wrote:

I'm using it for _getch();

Why do you need that though?
http://www.cplusplus.com/articles/iw6AC542/

[keskiverto]

What is so bad about indentation?

It is not intuitive. The statements within your loop bodies are not indented relative to the loop keywords, which makes it harder to see where the body starts and ends. Your functions and if do have indented bodies. There is no "one right" indentation style, but some are more readable than others.

Lorence30 wrote:

I'm using it [conio.h] for _getch();

That is no excuse. CLI programs can be used perfectly well without any hacks (standard C++ versions included). The hacks are just a lazy workaround for those clickety clack GUI crap users, who do not bother to use a non-closing terminal. If you insist on using such hack, please use one provided by language.