Restart confusion

[LiamSalt]

I am currently making a program that acts as a simple bowling score calculator, it allows for multiple players, each to be names and then shows the score frame by frame, all in command line,
But I have struck up an issue, I am unaware of a way to allow the user to restart the program halfway through the program. say mid-game?

Is there a way I can code in a command e.g. "RESTART" that can be input at any point causing the program to restart?

BowlingGame.h
#ifndef BOWLING_GAME_H
#define BOWLING_GAME_H

#include <string>
#include <vector>
#include "Player.h"

using namespace std;

class BowlingGame
{
public:
	BowlingGame();
	~BowlingGame();

	int initialize();
	int update();
	int shutdown();

	const vector<Player> getPlayers() const { return _players; }
	int getCurrentTurn() const { return _turn; }
	int getGameNumber() const { return _gameNumber; }
	int getLaneID() const { return _laneID; }

private:
	enum NAME_VALIDATION
	{
		NAME_LENGTH_INVALID,
		NAME_ALREADY_TAKEN,
		NAME_IS_VALID
	};
	int nameIsValid(const string &name);
	int _gameNumber;
	int _laneID;
	vector<Player> _players;
	int _turn;
	int _frame;
};

#endif



BowlingGame.cpp
#include "BowlingGame.h"
#include "InterfaceManager.h"

BowlingGame::BowlingGame()
{
	_gameNumber = 1;
	_laneID = 1;
	_turn = 0;
	_frame = 0;
}

BowlingGame::~BowlingGame()
{
}

int BowlingGame::initialize()
{
	SetConsoleTitle(TEXT("Bowling Score Sheet"));
	int playerCount = 0;
	do
	{
		Interface.drawSplashScreen(*this);
		playerCount = Interface.getIntegerValue(" How many players are on your team?(1-6): ");
	}
	while (playerCount < 1 || playerCount > 6);
	for (int i = 0; i < playerCount; i++)
		_players.push_back(Player());
	for (int i = 0; i < playerCount; i++)
	{
		Interface.drawSplashScreen(*this);
		char textBuffer[64];
		_snprintf_s(textBuffer, 64, " Please enter a name for player %d: ", i+1);
		string playerName = Interface.getStringValue(textBuffer);
		int valid = nameIsValid(playerName);
		while (valid != NAME_IS_VALID)
		{
			Interface.drawSplashScreen(*this);
			string msg;
			if (valid == NAME_LENGTH_INVALID)
				msg = " Name must be between 3 and 16 characters long.\n";
			else if (valid == NAME_ALREADY_TAKEN)
				msg = " The name provided already exists.\n";
			msg.append(textBuffer);
			playerName = Interface.getStringValue(msg);
			valid = nameIsValid(playerName);
		};
		_players[i].setName(playerName);
	}
	_turn = _players.size()-1;
	_frame = 0;
	return 1;
}

int BowlingGame::update()
{
	_turn = (_turn + 1) % _players.size();
	if (_turn == 0)
		_frame++;
	if (_frame > 10)	//end of game, all players have been through ten frames
	{
		Interface.drawGameOverScreen(*this);
		bool replay = Interface.getBooleanValue(" Would you like to play again? ");
		if (replay)
		{
			_gameNumber++;
			_players.clear();
			return initialize();
		}
		else
			return 0;	//quit the game
	}
	bool turnEnded = false;
	while (!turnEnded)
	{
		Interface.drawScoreTable(*this);
		turnEnded = _players[_turn].bowlBall(_frame);
	}
	return 1;
}

int BowlingGame::shutdown()
{
	_players.clear();
	return 1;
}

int BowlingGame::nameIsValid(const string &name)
{
	if (name.length() < 3 || name.length() > 16) return NAME_LENGTH_INVALID;
	for (int i = 0; i < (int)_players.size(); i++)
		if (name == _players[i].getName())
			return NAME_ALREADY_TAKEN;
	return NAME_IS_VALID;
}


InterfaceManager.cpp
#include "InterfaceManager.h"
#include "GameUtil.h"
#include "BowlingGame.h"
#include "Player.h"
#include <Windows.h>

InterfaceManager::InterfaceManager()
{
}

InterfaceManager::~InterfaceManager()
{
}

int InterfaceManager::getIntegerValue(const string &message)
{
	cout << message;
	string input;
	cin >> input;
	return GameUtil::stringToInteger(input.c_str(), true);	//strict input
}

string InterfaceManager::getStringValue(const string &message)
{
	cout << message;
	string input;
	cin >> input;
	return input;
}

bool InterfaceManager::getBooleanValue(const string &message)
{
	cout << message;
	string input;
	cin >> input;
	return GameUtil::stringToBoolean(input.c_str());
}

void InterfaceManager::drawSplashScreen(const BowlingGame &game)
{
	vector<Player> players = game.getPlayers();
	console.setSize(84, 28 + (players.size() * 3), true);
	console.clear();
	cout << "                        .! ! ! ! /\n";
	cout << "                      .  ! ! !  /\n";
	cout << "                    .    ! !   /\n";
	cout << "                  .      !    /\n";
	cout << "                .            /\n";
	cout << "              .      o      /\n";
	cout << "            .              /\n";
	cout << "          .     . '.      /\n";
	cout << "        .     '     '    /\n";
	cout << "      .     0 |         /\n";
	cout << "            |/\n";
	cout << "           /|\n";
	cout << "           / |\n\n";
	
	for (int i = 0; i < (int)players.size(); i++)
	{
		cout << " Player " << i+1 << ": " << players[i].getName() << "\n";
	}
	cout << "\n";
}

void InterfaceManager::drawScoreTable(const BowlingGame &game)
{
	vector<Player> players = game.getPlayers();
	int currentTurn = game.getCurrentTurn();
	console.clear();
	print(" _______________________________________________________________________________ \n");
	print("| Lane: %d, Game: %d |__1__|__2__|__3__|__4__|__5__|__6__|__7__|__8__|__9__|__10__|\n",
		game.getLaneID(), game.getGameNumber());
	int cursorPosY = console.getCurPosY();
	for (int i = 0; i < (int)players.size(); i++)
	{
		print("|                  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |   |\n");
		print("|                  |     |     |     |     |     |     |     |     |     |      |\n");
		if (i < (int)players.size()-1)
			print("|------------------|-----|-----|-----|-----|-----|-----|-----|-----|-----|------|\n");
		else
			print("`------------------'-----'-----'-----'-----'-----'-----'-----'-----'-----'------'\n");
	}
	for (int i = 0; i < (int)players.size(); i++)
	{
		if (currentTurn == i)
		{
			console.save();
			//console.setFgColour(_yellow);
		}
		console.setCurPosY(cursorPosY);
		Player player = players[i];
		vector<Score> scores = player.getScores();
		for (int j = 0; j < (int)scores.size(); j++)
		{
			console.setCurPosX(21 + (j*6));
			print(scores[j].getScore(Score::FIRST).c_str());
			console.setCurPosX(23 + (j*6));
			print(scores[j].getScore(Score::SECOND).c_str());
			if (j == 9)
			{
				console.setCurPosX(25 + (j*6));
				print(scores[j].getScore(Score::THIRD).c_str());
			}
		}
		console.setCurPosY(cursorPosY+1);
		int space = 18 - player.getName().length();
		console.setCurPosX(space);
		print(player.getName().c_str());
		int totalScore = 0;
		for (int j = 0; j < (int)scores.size(); j++)
		{
			if (!scores[j].isOpen() || j == 9)
			{
				totalScore += scores[j].total;
				char buffer[4];
				_snprintf_s(buffer, 4, "%d", totalScore);
				console.setCurPosX(21 + (j*6));
				print(buffer);
			}
		}
		cursorPosY += 3;
		if (currentTurn == i)
		{
			console.restore();
		}
	}
	console.setCurPosXY(0, 3 + players.size() * 3);
	print(" Current player's turn: %s\n\n", players[currentTurn].getName().c_str());
}

void InterfaceManager::drawGameOverScreen(const BowlingGame &game)
{
	drawScoreTable(game);
	vector<Player> players = game.getPlayers();
	int topScore = 0, totalScore = 0;
	vector<Player> topPlayers;
	for (int i = 0; i < (int)players.size(); i++)
	{
		int score = players[i].calculateScore();
		totalScore += score;
		if (score > topScore)
		{
			topPlayers.clear();
			topScore = score;
			topPlayers.push_back(players[i]);
		}
		else if (score == topScore)
		{
			topPlayers.push_back(players[i]);
		}
	}
	if (topPlayers.size() == 1)
		cout << " The winner for this game is " << topPlayers[0].getName();
	else
	{
		cout << " The game resulted in a tie between ";
		for (int i = 0; i < (int)topPlayers.size() - 1; i++)
		{
			cout << topPlayers[i].getName();
			if (i < (int)topPlayers.size() - 2)
				cout << ", ";
		}
		cout << " and " << topPlayers.back().getName();
	}
	cout << " with " << topScore << " points!\n";
	cout << " The team scored a total of " << totalScore << " points.\n\n";
}

[Aceix]

Of course, there should be a way to go about that, but it greatly depends on the structure and style of your program.

Aceix.

[AbstractionAnon]

There are a couple of ways to handle this.

1) Any place you accept input from the user, check for the keyword "RESTART" and exit out of any nested functions you're in with an indicator that the main() should go back to the start of the program.

2) Any place you accept input from the user, check for the keyword "RESTART", then throw an exception. Your main can then have a catch handler for that exception that takes it back to the beginning of the program.

[LiamSalt]

How would I check for the keyword? using if( ==) and I don't quit understand what you mean by exception?

[admkrk]

if(input == "RESTART") would work if input was a string and the user typed it all in capitals. I assume in your case that input would be an int (pins knocked down?) so you would need to use an integer for the keyword, something like -1 that would not be entered normally.

Exceptions are for error handling and not appropriate for something like this.

[LiamSalt]

I did attempt to do that I wrote something similar to

if(input == "Restart")
{
BowlingGame.intialise;
}

But it seemed to get caught in a loop while working in which you it would send you back to the start but as soon as you tried to restart it again it wouldn't clear the screen, but would just print the next cout

[LiamSalt]

Do I need to do it with a pointer to the main? or would that still not clear the memory and arrays?

[admkrk]

You can clear the screen and reset any arrays or anything else you need to do before starting over.

if(input == "Restart")
{
    // Clear screen
    // Clear arrays
    // What ever else
    BowlingGame.intialise;
}

I do not understand what you mean by "a pointer to main"? This should all be happening inside the game loop in main.

[LiamSalt]

My main is very small

#include <string>
#include "BowlingGame.h"

int main (int argc, char *argv[])
{   
	BowlingGame Game;

    Game.initialize ();  //Run initialise method from BowlingGame
    while (Game.update());   // continue until false is returned
    Game.shutdown ();	//Run shutdown method in BowlingGame to clear player names
    return 0;
}

As it is only used to intialize methods in other classes

[codekiddy]

I know a lot of people will says how bad is this but why not using goto?

int main (int argc, char *argv[])
{   
    BowlingGame Game;

restart:
    Game.initialize ();
    while (Game.update());
    Game.shutdown ();
    goto restart;

    return 0;
}

[LB]

Or you could use a while loop...
http://www.cplusplus.com/forum/beginner/140703/#msg743371

[admkrk]

I expected some kind of loop like LB pointed out. Your code is hard to follow also with unneeded functions like:

int InterfaceManager::getIntegerValue(const string &message)
{
	cout << message;
	string input;
	cin >> input;
	return GameUtil::stringToInteger(input.c_str(), true);	//strict input
}

You could just as easily print the message, get the input and cast to an int(assuming that is what stringToInteger() does) and get rid of both functions.

[LiamSalt]

I'm not trying to get the game to restart at the end, It already does that, I just ask if the user wants to reply at the end of the program and it restarts it, what I want to be able to do is allow the user to type in a keyword e.g. "RESTART" at any point and the program will go back to the start, I don't know how or where to code this./

[LB]

That depends entirely on how you're processing input.

[codekiddy]

you mean something like this? :

int main(int argc, char *argv[])
{
	BowlingGame Game;

	Game.initialize();
	while (Game.update())
	{
		std::cout << "restart the game?";
		char answer;
		std::cin >> answer;

		if (answer == 'Y')
		{
			Game.shutdown();
			Game.initialize();
		}
	};
	Game.shutdown();

	return 0;
}

[admkrk]

The problem is with the way your game is structured. One way to clean it up would be like I suggested earlier.

playerCount = Interface.getIntegerValue(" How many players are on your team?(1-6): ");

// could easily be written without any functions as:
cout << " How many players are on your team?(1-6): "
string input;
cin >> input;
playerCount = (int) input;

In the code that you posted, Interface.getIntegerValue() is called once and it calls another function. A function should only do one thing, but one thing should not be split into two or more functions and there is no reason to write a function to do a simple thing one time. Your code jumps around so much you might as well be using goto.

In a GUI program, main() might only initialization the main window and all the rest is handled in the main window class and other classes. A console program works differently and main() is the equivalent of the main window class.

If you do not understand what I am trying to say, try writing a flowchart for your game.

[LiamSalt]

That's almost what I want, but that would omit the naming of the players, there are 4 points to the program

1 How Many players

2 The Names of the players

3 How many pins did (player) knock down [in the way you've coded it, it asks after every frame is complete]

4 would you like to replay

I just want to be able to type in a keyword at any of these four input prompts that will allow me to functionally restart the program

[LiamSalt]

okay I understand that, it is very messy, unfortunatley GameUtil::stringToInteger() is where the parameters are passed stopping invalid input

[admkrk]

In that case, if it was me, I would combine that and GameUtil::stringToBoolean() into one function called something like GameUtil::validateInput() and pass the string as an argument. If it passes, continue or if it fails do whatever you do to get correct input.

As for number 4, if the user wants to replay, it starts over anyway so you do not really need a keyword there. Of the other 3, 2 are integer inputs so making the keyword an integer that is out of bounds (input < 0 || input > 10) like -1 or 100 would probably work best then just use.

if(input == keyword)
    replay();

[LiamSalt]

Yes, but the program HAS to be able to restart at any point, I can't just rely on it restarting at the end, its a requirement that I can restart it and because I'm a freaking idiot that decided to use console instead of GUI I can't work this out for shit.