paranthesis count

[mehak]

i am trying to implement balancing of braces by using stacks however i dont get the correct output,please help!

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#define STACKSIZE 100
struct stackk
{
    int top;
    int item[STACKSIZE];
};
 struct stackk s;

void push(char c)
{
    if(s.top==STACKSIZE-1)
    {
        printf("Stack overflow");
        exit(0);
    }
    s.item[++(s.top)]=c;
}
char pop()
{
    if(s.top==-1)
    {
        printf("Stack underflow");
        exit(0);
    }
    return s.item[(s.top)--];
}
int empty()
{
    if(s.top==-1)
        return 1;
    else return 0;
}
int main()
{
    s.top=-1;
    int valid=1;
    char str[100],c,p;
    int len,i;
    printf("Enter string\n");
    scanf("%s",str);
    len=strlen(str);
    for(i=0;i<len;i++)
    {
        c=str[i];
        if(c=='{')
            push(c);
        if(c=='}')
        {
            if(empty)
                valid=0;
            else
            {
               p=pop();
               if(p!='{')
                    valid=0;
            }
        }
    }
    if(!empty())
        valid=0;
    if(valid)
        printf("string is valid");
    else
        printf("not valid");
}

[AbstractionAnon]

One obvious problem:
Line 52: You're attempting to call empty, but don;t include the () to indicate a function call. You're going to get the address of the function instead, which will always be non-zero (true).

Other than that, your program seems to work for the few trivial examples I tried.

[mehak]

thnx alot:)