Help Please

[awatt92]

Having a problem with my code,

If I enter more than 1 customer with the same name the function only returns the most recent update. Am I missing anything?

  void add_new_customer()
{
	string first_name;
	string last_name;
	unsigned long long phone_no;
	string city;
	string size;
	string notes;

	ofstream newcustomer ("Customer List2.txt", ios::app); 
	
	cout<<"--------------------------"<<endl;
	cout<<"First Name:\t";
	cin>>first_name;
	cout<<"\nLast Name:\t";
	cin>>last_name;
	cout<<"\nPhone Number:\t";
	cin>>phone_no;
	cout<<"\nPrefered City:\t";
	cin>>city;
	cout<<"\nProperty Size:\t";
	cin>>size;
	cout<<"Customer Notes:\t\n";
	cin>>notes;

	newcustomer << first_name <<"  "<< last_name <<"   "<< phone_no <<"   "<<city<<"  "<<size<<"  "<< notes<<endl;
	newcustomer.close();
	
	main();










void search_customer_name()
{
	ifstream customer ("Customer list2.txt");
	string first_name;
	string last_name;
	unsigned long long phone_no;
	string city;
	string size;
	string notes;
	string input_first_name;
	string input_second_name;

	system("cls");
	cout<<"--------------------------"<<endl;
	cout<<"Search\n\n"<<endl;
	cout<<"First Name:\t";
	cin>>input_first_name;
	cout<<"--------------------------"<<endl;

	while (customer >>first_name>>last_name>>phone_no>>city>>size>>notes)
	{
		if (input_first_name == first_name)
		{
			system ("cls");
			cout<<"--------------------------"<<endl;
			cout<<"Customer(s) found"<<endl;
			cout<<"--------------------------"<<endl;
			cout<<"First Name\tSecond Name\tPhone Number\tCity\t\tProperty Size\t"<<endl;
			cout<<first_name<<"\t\t"<<last_name<<"\t\t"<<phone_no<<"\t"<<city<<"\t\t"<<size<<endl;
			cout<<"--------------------------"<<endl;
			system ("pause");
			main();

		}

		else if (!(input_first_name == first_name))
		{
			cout<<"--------------------------"<<endl;
			system ("cls");
			cout<<"No Customer(s) Match Your Search"<<endl;
			cout<<"--------------------------"<<endl;
		}
	}

	system("pause");
	cin.get();
	main();
	
	

	}

[Yay295]

Yeah, if you want to find every customer with that name you have to go through the entire file instead of calling main to..

WHAT ARE YOU DOING CALLING MAIN!? YOU SHOULD NEVER CALL MAIN! EVER! Use return like a sensible human being!

[ResidentBiscuit]

Yeahh never call main(). You shouldn't even be able to, as the standard forbids it. Does your program ever even end?

[awatt92]

I've removed main, yet i'm still having the same problem.

FYI this isn't the entire program just the two functions I figured caused the issue.

The data is saving to my Customer list2.txt without any issues.

void search_customer_name()
{
	ifstream customer ("Customer list2.txt");
	string first_name;
	string last_name;
	unsigned long long phone_no;
	string city;
	string size;
	string notes;
	string input_first_name;
	string input_second_name;

	system("cls");
	cout<<"--------------------------"<<endl;
	cout<<"Search\n\n"<<endl;
	cout<<"First Name:\t";
	cin>>input_first_name;
	cout<<"--------------------------"<<endl;

	while (customer >>first_name>>last_name>>phone_no>>city>>size>>notes)
	{
		if (input_first_name == first_name)
		{
			system ("cls");
			cout<<"--------------------------"<<endl;
			cout<<"Customer(s) found"<<endl;
			cout<<"--------------------------"<<endl;
			cout<<"First Name\tSecond Name\tPhone Number\tCity\t\tProperty Size\t"<<endl;
			cout<<first_name<<"\t\t"<<last_name<<"\t\t"<<phone_no<<"\t"<<city<<"\t\t"<<size<<endl;
			cout<<"--------------------------"<<endl;
			system ("pause");
			

		}

		else if (!(input_first_name == first_name))
		{
			cout<<"--------------------------"<<endl;
			system ("cls");
			cout<<"No Customer(s) Match Your Search"<<endl;
			cout<<"--------------------------"<<endl;
		}
	}

	system("pause");
	cin.get();
	
	
	

	}

[Yay295]

It's probably because you're clearing the screen.

You find a name, print their information to the screen, and on the next pass through you clear the screen again.

[AbstractionAnon]

Line 36: There is no need for the if here. else is adequate since you've already tested if they're the same (although this whole else if probably shouldn't be here, see below).

You don't want to display "No customer(s) match" for each record read that doesn't match. You want to keep a count of the number of matches found, then after the read loop, check the counter and display "No customer(s) match" if count is zero.