Bad random number generation

[hinesro]

I'm trying to generate some random numbers using the rand function in the following member function. For some reason, it is giving all 0's for attack values, but then giving huge numbers like 312981231123 for the defense values. I know this is probably a stupid error located somewhere in the code, but I can't seem to find it. Can anyone help?

void Character::dieRoll(Character attacker, Character defender)
{
	srand (time(0));

	// attacker
	if(attacker.attackDieSides == 6)
	{
		attacker.die1 = rand() % 6 + 1;
		attacker.die2 = rand() % 6 + 1;
		attacker.die3 = rand() % 6 + 1;

		if(attacker.attackDie == 3)
		{
			attack = attacker.die1 + attacker.die2 + attacker.die3;
		}
		else if(attacker.attackDie == 2)
		{
			attack = attacker.die1 + attacker.die2;
		}
	}
	else if(attacker.attackDieSides == 10)
	{
		attacker.die1 = rand() % 10 + 1;
		attacker.die2 = rand() % 10 + 1;

		attack = attacker.die1 + attacker.die2;
	}	

	// defender
	defender.die1 = rand() % 6 + 1;
	defender.die2 = rand() % 6 + 1;
	defender.die3 = rand() % 6 + 1;

	if(defender.defenseDie == 3)
	{
		defense = defender.die1 + defender.die2 + defender.die3;
	}
	else if(defender.defenseDie == 2)
	{
		defense = defender.die1 + defender.die2;
	}
	else if(defender.defenseDie == 1)
	{
		defense = defender.die1;
	}
}

For reference, here is another member function of the same class that also uses random, but works just fine!

void Character::startRoll()
{
	srand (time(0));

	cout << "Roll the die to see who attacks first!\n\n";

	continuePlay();

	playerStartRoll = rand() % 6 + 1;
	enemyStartRoll = rand() % 6 + 1;

	cout << "You rolled a " << playerStartRoll << endl
		 << "The enemy rolled a " << enemyStartRoll << endl << endl;

	continuePlay();
}

[Codermik]

srand should only be called once at the start of your program, dont call it each time you call your function.

[hinesro]

Thanks. I removed it from the functions and just placed it once in the main file. However, I'm still getting the same kind of numbers.

[Peter87]

The Character objects (attacker and defender) in dieRoll are copies of the Character objects that you passed to the function. If you want dieRoll to modify the objects that you passed to the function you can pass them by reference.

void Character::dieRoll(Character& attacker, Character& defender)

Note the extra &