Boolean Function to search Vector Elements??

[Stephenpoole4]

I'm trying to make a Boolean function that will search the elements of a vector of strings and return true if the user-inputted string is present. For instance, if the vector contains the strings "red," "yellow," and "blue" and the user inputs the value "green," the function returns false.

bool appears_in_vector(vector<string>vec, string input)
{
	for (int i = 0; i < vec.size(); i++)
	{
		if (input == vec[i])
		{
			return true;
		}
		else
		{
			return false;
		}
	}
		
}

This function gives me run-time errors. What is the correct way to do this?

[AbstractionAnon]

I don't see anything that would cause run time errors, but your logic is flawed and will not give you the results you want.

Your logic is guaranteed to exit on the first comparison and will not check all the members of the vector.

Try this instead:

bool appears_in_vector(vector<string>vec, string input)
{   for (int i = 0; i < vec.size(); i++)
    {   if (input == vec[i])
           return true;
     }
    return false; // no matches found		
}

[Stephenpoole4]

Thanks!