While loop is a bit off...

[Ryan5920]

I have a dat file I'm trying to read and produce output from. When all the numbers are added together I'm supposed to get 199 boys, 198 girls, and 397 total students. But I end up getting 217 boys, 215 girls, and 432 total students. My dat file is formatted as January 9 8 all the way to December. I'm thinking my December is getting added twice, but I do not see how. Shouldn't it read all 12 lines of data and terminate due to the Infile.eof condition?

/*-------------------------------------------------------------------------------------------------------
Program: E41.cpp
Author: Ryan Youngen
Purpse: Stream I/O
-------------------------------------------------------------------------------------------------------*/
#include<iostream>
#include<iomanip>
#include<fstream>
#include<assert.h>
#include<string>

using namespace std;
using namespace System;


 
 
 

const char* AUTHOR  = "Ryan Youngen     Assignment 1 P01.cpp \n\n"; 
const char* LINE    = "----------------------------------------";

void main()
{ 
int total;
int totalboys = 0;
int totalgirls = 0;
int totalstudent = 0;
int boys;
int girls;


string Name;
char month[80], subString[80];
int strLength;
Console::Clear();


cout << AUTHOR << LINE << endl;

ifstream Infile("P01.DAT");
assert(Infile);


while( !Infile.eof() )
{
Infile >> month >> boys >> girls;

strncpy(subString, month, 3);
  strLength = strlen(month);
  if(strLength <= 3) subString[strLength] = '\0';
  else subString[3] = '\0';
   cout << subString << setw(5); 
totalboys += boys;
totalgirls += girls;
total = boys + girls;
totalstudent = totalboys + totalgirls;
  for(int stars = 0; stars <= total; stars++) 
cout << "*";
cout << endl;


}


cout << endl;
Infile.close();
cout << "Total Number of Boys = " << totalboys << endl;
cout << "Total Number of Girls = " << totalgirls <<endl;
cout << "Total Number of Students = " << totalstudent << endl;
cout << endl << endl;
}

[Peter87]

Using eof() as a loop condition is almost always wrong.

Read: http://www.parashift.com/c++-faq/istream-and-eof.html