For Loop and Arrays : Displaying a list from greatest to least

[Lynst]

I seem to be having some trouble of understanding the concept of switching around array values and displaying them in greatest to least with a for loop.

Update: For some reason this code works for two people but nothing more than two people??

#include <iostream>
using namespace std;

int main() {
    int personNumber = 1;
    int pancakeAmount;
    int person[3] = {};
    int greatestToLeast[3] = {};
    int listOfPeople[3] = {};
    cout << "Pancake Glutton 1.0 \n\n"; //State program's title
    cout << "10 Different people ate pancakes for breakfast.. \n\n";
    while(personNumber !=4) {
        cout << "How many did Person " << personNumber << " eat? > ";
        cin >> pancakeAmount;
        if(personNumber == 1) {
            person[personNumber] = pancakeAmount;
            greatestToLeast[personNumber] = pancakeAmount;
            listOfPeople[personNumber] = personNumber;
        }
        else if(pancakeAmount > person[personNumber - 1]) {
            person[personNumber] = pancakeAmount; //Next person gets assigned the number of pancakes
            listOfPeople[personNumber] = personNumber;
            greatestToLeast[personNumber] = pancakeAmount;
            int storePancakeValue = person[(personNumber - 1)]; //Variable used to store the amount of pancakes of the person before
            greatestToLeast[(personNumber - 1)] = pancakeAmount;
            greatestToLeast[personNumber] = storePancakeValue;
            int storePersonNumber = listOfPeople[(personNumber - 1)];
            listOfPeople[(personNumber - 1)] = personNumber;
            listOfPeople[personNumber] = storePersonNumber;
        }
        else {
            person[personNumber] = pancakeAmount;
            greatestToLeast[personNumber] = pancakeAmount;
            listOfPeople[personNumber] = personNumber;
        }
        personNumber++;
    }
    int x;
    cout << "\n\n";
    for(x=1; x<4; x++) {
        cout << "Person " << listOfPeople[x] << " ate " << greatestToLeast[x] << " pancakes! \n";
    }
}

[Yanson]

int personNumber = 1; needs to be int personNumber = 0;

arrays start at array element 0 so

if(personNumber == 1) {
            person[personNumber] = pancakeAmount;

is actually storing pancakeAmount in the second array element

[keskiverto]

The array indexing starts from 0. Therefore, valid indices of three-element array are 0, 1, and 2. You use indices 1, 2, and 3 in your program. That is an error.

[Lynst]

I'm unfortunately still not getting this to work. :/

#include <iostream>
using namespace std;

int main() {
    int personNumber = 1;
    int greatestToLeastPancakeAmount[9] = {};
    int greatestToLeastPersonNumber[9] = {};
    int pancakeAmount;
    cout << "Pancake Glutton 1.0 \n\n"; //State program's title
    cout << "10 Different people ate pancakes for breakfast.. \n\n";
    int x;
    for(x=0;x<10;x++) {
            cout << "How many pancakes did person " << (x + 1) << " eat? > ";
            cin >> pancakeAmount;
            greatestToLeastPersonNumber[x] = x;
            greatestToLeastPancakeAmount[x] = pancakeAmount;
            if(greatestToLeastPersonNumber[x] > greatestToLeastPersonNumber[(x-1)]) {
                int storeGreatestToLeastPersonNumber = greatestToLeastPersonNumber[(x-1)];
                greatestToLeastPersonNumber[(x-1)] = x;
                greatestToLeastPersonNumber[x] = storeGreatestToLeastPersonNumber;
            }
            if(pancakeAmount > greatestToLeastPancakeAmount[(x - 1)]) {
                int storeGreatestToLeastPancakeAmount = greatestToLeastPancakeAmount[(x-1)];
                greatestToLeastPancakeAmount[(x-1)] = pancakeAmount;
                greatestToLeastPancakeAmount[x] = storeGreatestToLeastPancakeAmount;
            }
    }
    cout << "\n\n";
    for(x=0;x<11;x++) {
        cout << "Person " << greatestToLeastPersonNumber[x] << " ate " << greatestToLeastPancakeAmount << " pancakes!\n";
    }
}

[admkrk]

This is what this part looks like if you replace x with the value of x

 int x;
    for(x=0;x<10;x++) {
            cout << "How many pancakes did person " << (0 + 1) << " eat? > ";
            cin >> pancakeAmount;
            greatestToLeastPersonNumber[0] = 0;
            greatestToLeastPancakeAmount[0] = pancakeAmount;
            if(greatestToLeastPersonNumber[0] > greatestToLeastPersonNumber[(0-1)]) {
                int storeGreatestToLeastPersonNumber = greatestToLeastPersonNumber[(0-1)];
                greatestToLeastPersonNumber[(0-1)] = 0;
                greatestToLeastPersonNumber[0] = storeGreatestToLeastPersonNumber;
            }
            if(pancakeAmount > greatestToLeastPancakeAmount[(0 - 1)]) {
                int storeGreatestToLeastPancakeAmount = greatestToLeastPancakeAmount[(0-1)];
                greatestToLeastPancakeAmount[(0-1)] = pancakeAmount;
                greatestToLeastPancakeAmount[0] = storeGreatestToLeastPancakeAmount;
            }
    }

I should say just on the first pass.

[keskiverto]

personNumber on line 5 is an unused variable. Not an error.

Lines 6 and 7 reserve arrays for 9 elements, but loop on line 12 iterates over 10 elements (plus that -1 when x==0) and loop on line 29 accesses 11 elements.

Line 30 prints value of element and address of an array.

[Lynst]

I restarted, and working on getting it to just display the order of people I input, for some reason instead of saying "Person 1 ate..." it says "Person 10 ate.." so it comes out as;

Person 10 ate..
Person 2 ate..
Person 3 ate..
Person 4 ate..
Person 5 ate..
Person 6 ate..
Person 7 ate..
Person 8 ate..
Person 9 ate..
Person 10 ate..

#include <iostream>
using namespace std;

int main() {
    int greatestToLeastPancakeAmount[9] = {};
    int greatestToLeastPersonNumber[9] = {};
    int pancakeAmount;
    int x;
    cout << "Pancake Glutton 1.0 \n\n"; //State program's title
    cout << "10 Different people ate pancakes for breakfast.. \n\n";
    for(x=0;x<10;x++) {
        cout << "How many pancakes did person " << (x + 1) << " eat? > ";
        cin >> pancakeAmount;
        greatestToLeastPersonNumber[x] = (x + 1);
        greatestToLeastPancakeAmount[x] = pancakeAmount;
        /*if(pancakeAmount > greatestToLeastPancakeAmount[(x - 1)]) {
            int storeGreatestToLeastPancakeAmount = greatestToLeastPancakeAmount[(x-1)];
            int storeGreatestToLeastPersonNumber = greatestToLeastPersonNumber[(x-1)];
            greatestToLeastPancakeAmount[(x-1)] = pancakeAmount;
            greatestToLeastPersonNumber[(x-1)] = x;
            greatestToLeastPancakeAmount[x] = storeGreatestToLeastPancakeAmount;
            greatestToLeastPersonNumber[x] = storeGreatestToLeastPersonNumber;
        }*/
    }
    cout << "\n\n";
    for(x=0;x<10;x++) {
        cout << "Person " << greatestToLeastPersonNumber[x] << " ate " << greatestToLeastPancakeAmount[x] << " pancakes!\n";
    }
}