calling a member function, unintended returns

[philbertfour]

I'm working on a project that has several banking menu options and calls all the accountID, passcode, balance, etc. from an object defined in the header.
Here's the thing I can call the accountID and passcode and accurately check them for validity but when I try to call GetBalance it runs but returns and updates a crazy long number that I definitely never put in the account Balance.
I need help calling the accurate account balance.
I think that even though I'm declaring an account variable that it isn't the one found with the code below from accountID and passcode.
I'll be checking in all night that s just partial code below if you want the whole thing in three parts : bankingSystem.h, bankingSystemDriver.cpp, and bankingSystem.cpp. just let me know. The header and driver are small and working fine.
Thanks!

 void BankingSystem::Deposit()
{
	Account     account;
	size_t   index;
    unsigned accountID;
    unsigned passcode;
	double deposit;
	double balance;


	std::cout << "\nEnter the account ID: ";
	std::cin >> accountID;
	if (FindAccount(accountID) == current_num_accounts_)
	{
		std::cout << "\nAccount not found!" << std::endl;
	}
		else
		{
			index = FindAccount(accountID);
			std::cout << "\nEnter the passcode: ";
			std::cin >> passcode;
			if (MatchPasscode(passcode, index) == 1)
			{
				std::cout << "\nHow much would you like to deposit? ";
				std::cin >> deposit;
				if (deposit > 0)
				{
					balance = account.GetBalance();
					balance = balance + deposit;
					account.SetBalance(balance);
					std::cout << std::setprecision(2) << std::fixed << "\nSuccess! The new balance is " << balance << "!" << std::endl;
				}
				else

[N36fSL3A]

We'll need more code. I'm guessing that your balance variable is uninitialized.

[jae]

Yes, the other codes would be useful. You could initialize the value in the default constructor. You declare it and define it just like any other function. It helps to prevent uninitialized variables.

BankingSystem(){

balance = 0;
deposit = 0;
//... and so on. You define every variable in the class here. 
//If your variables contain another class, you have to define those too.
}

[philbertfour]

So this is all of the banking system.cpp. There's also a bankingsystemdriver.cpp but that's mostly just a menu and switch between menu items and there's also a bankingsystem.h header that mostly defines an Account class and a banking system class but the account is just getters and setters for accountid, passcode, first and last names, and balance and the banking system class implementation is all mostly fleshed out right here.
I feel like calling account.Getbalance is right but that it's calling them goofily.
I'll try initializing balance and deposit to zero though just in case they are having residual values.
Thanks!

*/

#ifndef _BANKINGSYSTEM_CPP
#define _BANKINGSYSTEM_CPP

#include <iostream>
#include <iomanip>
#include <string>
#include <cstdlib>
#include "bankingSystem.h"

void Account::SetAccountID(unsigned accountID)
{

    accountID_ = accountID;

}

unsigned Account::GetAccountID()
{

    return accountID_;

}

//*** TO DO:  Add the rest of your Account function implementations here. *NS* I'm doing void Account instead of Void
//Passcode because I know that all of these are supposed to go under one element of an array. Not sure of the necessity of that?
//Same for the following Account function implementations.
void Account::SetPasscode(unsigned int passcode)
{
	passcode_ = passcode;
}

unsigned Account::GetPasscode()
{
	return passcode_;
}

void Account::SetFirstName(const std::string& firstName)
{
	firstName_ = firstName;
}

std::string Account::GetFirstName()
{
	return firstName_;
}

void Account::SetLastName(const std::string& lastName)
{
	lastName_ = lastName;
}

std::string Account::GetLastName()
{
	return lastName_;
}

void Account::SetBalance(double balance)
{
	balance_= balance;
}

double Account::GetBalance()
{
	return balance_;
}

//Default constructor just initializes
//current number of accounts to 0;

BankingSystem::BankingSystem() : current_num_accounts_(0)
{}

//Find an account by accountID.
//Return the array index if found, current_num_accounts_ otherwise.

size_t BankingSystem::FindAccount(size_t accountID)
{

    for (size_t i = 0; i < current_num_accounts_; ++i)
        if (accounts_[i].GetAccountID() == accountID)
            return i;

    return current_num_accounts_;

}

//Match the passcode at a given index with the given passcode.
//Return true for a match, false otherwise.

bool BankingSystem::MatchPasscode(unsigned passcode, size_t index)
{

    return accounts_[index].GetPasscode() == passcode;

}

//Add an account.

void BankingSystem::CreateAccount()
{

    Account     account;
    unsigned    accountID;
    unsigned    passcode;
    std::string firstName;
    std::string lastName;
    double      balance;

    //Get the account ID and make sure it doesn't already exist.

    std::cout << "\nEnter the account ID:  ";
    std::cin >> accountID;

    if (FindAccount(accountID) != current_num_accounts_)
	{

        std::cout << "\nAccount already exists!\n";

        return;
	}
  
	
	account.SetAccountID(accountID);
	std::cout << "\nEnter the passcode: ";
	std::cin >> passcode;
	account.SetPasscode(passcode);
	std::cout << "\nEnter the first name: ";
	std::cin >> firstName;
	account.SetFirstName(firstName);
	std::cout << "\nEnter the last name: ";
	std::cin >> lastName;
	account.SetLastName(lastName);
	std::cout << "\nEnter the starting balance: ";
	std::cin >> balance;
	account.SetBalance(balance);

	//Set this info into your Account object.
    //Add the account to your array and increment the count of accounts.

    accounts_[current_num_accounts_] = account;
    ++current_num_accounts_;

    std::cout << "\nAccount added successfully!\n";

}

//Delete an account.
void BankingSystem::DeleteAccount()
{

    size_t   index;
    unsigned accountID;
    unsigned passcode;

    //*** TO DO:  Get the account ID and verify it exists.
	std::cout << "\nEnter the account ID: ";
	std::cin >> accountID;
	if (FindAccount(accountID) == current_num_accounts_)
	{
		std::cout << "\nAccount not found!" << std::endl;
	}
	else
	{
	index = FindAccount(accountID);
	std::cout << "\nEnter the passcode: ";
	std::cin >> passcode;
	if (MatchPasscode(passcode, index) == 1)
	{
	for (size_t i = index; i < current_num_accounts_ - 1; ++i)
        accounts_[i] = accounts_[i + 1];
	--current_num_accounts_;
	std::cout << "\nAccount erased!\n";
	}
	else
	{
		std::cout << "\nInvalid passcode!" << std::endl;
	}
	}
}

//*** TO DO:  Add your remaining BankingSystem function implementations here.

void BankingSystem::PrintAccounts()

{
	

	std::cout << "nope";
}

void BankingSystem::Deposit()
{
	Account     account;
	size_t   index;
    unsigned accountID;
    unsigned passcode;
	double deposit;
	double balance;


	std::cout << "\nEnter the account ID: ";
	std::cin >> accountID;
	if (FindAccount(accountID) == current_num_accounts_)
	{
		std::cout << "\nAccount not found!" << std::endl;
	}
		else
		{
			index = FindAccount(accountID);
			std::cout << "\nEnter the passcode: ";
			std::cin >> passcode;
			if (MatchPasscode(passcode, index) == 1)
			{
				std::cout << "\nHow much would you like to deposit? ";
				std::cin >> deposit;
				if (deposit > 0)
				{
					balance = account.GetBalance();
					balance = balance + deposit;
					account.SetBalance(balance);
					std::cout << std::setprecision(2) << std::fixed << "\nSuccess! The new balance is " << balance << "!" << std::endl;
				}
				else
				{
					std::cout << "\nYou must deposit at least a penny!" << std::endl;
				}
			}
			else
			{
				std::cout << "\nInvalid passcode!" << std::endl;
			}
	}

}

void BankingSystem::Withdraw()

{
	Account     account;
	size_t   index;
    unsigned accountID;
    unsigned passcode;
	double withdraw;
	double balance;


	std::cout << "\nEnter the account ID: ";
	std::cin >> accountID;
	if (FindAccount(accountID) == current_num_accounts_)
	{
		std::cout << "\nAccount not found!" << std::endl;
	}
		else
		{
			index = FindAccount(accountID);
			std::cout << "\nEnter the passcode: ";
			std::cin >> passcode;
			if (MatchPasscode(passcode, index) == 1)
			{
				std::cout << "\nHow much would you like to withdraw? ";
				std::cin >> withdraw;
					balance = account.GetBalance();
					balance = balance - withdraw;
				if (balance < 0)
				{
					std::cout << "\nSorry!  You don't have that much money to withdraw!" << std::endl;
				}
				else
				{
					account.SetBalance(balance);
					std::cout << std::setprecision(2) << std::fixed << "\nSuccess! The new balance is " << balance << "!" << std::endl;
				}
			}
			else
			{
				std::cout << "\nInvalid passcode!" << std::endl;
			}
	}

}

#endif 

[philbertfour]

So I just tried initializing deposit and balance to zero at the beginning of the deposit implementation and I'm still getting the crazy long negative number.

[ne555]

> I think that even though I'm declaring an account variable
> that it isn't the one found with the code below from accountID and passcode.
Exactly.
You never set `account' to anything meaningful.

[philbertfour]

I realize that but I'm also unsure of exactly how to set it correctly to correspond with the other info. I've tried using FindAccount to correspond with account like it does for accountID but so far it's a no go.

[AbstractionAnon]

You have a couple of choices.

1) you can set the local account instance from accounts_[index], but then you have to store it back the modified instance.

  Account account; 

  index = FindAccount (accountID);
  if (index == current_num_accounts_)
  { /* not found */ 
  }
  else
  {  account = accounts_[index];  // Copy the account instance
      /* modifiy local account */ 
     accounts_[index] = account;  // Copy it back
  }

2) Or simply use a pointer

  Account *   acct; 

  acct = FindAccount (accountID);  // Returns a pointer or NULL if not found
  if (! acct)
  { /* not found */ 
  }
  else
  {  /* modifiy account via ptr */ 
      acct->SetBalance (newbalance);
  }

BTW, you don't need include guards around a .cpp file. A .cpp file should never be included.

[Albo Coder]

[

[AbstractionAnon]

Since the OP has included member functions for Account (Account::SetAccountID), we can infer it is a class or a struct.