While loop

[nhrnjic]

Can someone help me with this.You said that for repeating program I use do-while,and when I say at the end of the program

cout << " Do you want to continue y/n : ";

I put that inside of while() but every time that program repeats like milion times ? HELP

[Ivan Sidarau]

Please copy full cycle code to codepad.org and give us a link

[nhrnjic]

http://codepad.org/Xxui5eNQ

[Zapeth]

you have the condition in the while loop wrong.

"ope = 'n' " writes the character into the variable so its always true/possible and therefore an infinite loop.

you need to use either the operator "==" (which should work for chars but not sure now) or if you are using Strings the strcmp() method.

edit: also you have a strange method of putting the brackets, its hard to locate them in your code so maybe you can make them more visible by putting them in an own line.

[nhrnjic]

Thanks for that and one more question. In that link why does it say "Line 7: error: '_TCHAR' has not been declared " don't get that ?

[Zapeth]

do you have that error in your compiler or was it automatically added when you uploaded the file? (dont know much about codepad)

if its in your compiler, what OS are you using and what IDE (if you are using one)

[nhrnjic]

Its shows when I put it in codepad

[mcupryk]

Sometimes in certain editors there are invisible characters.

Becareful.

[Zapeth]

well then I can only assume that codepad has something like a built in compiler which doesnt recognize the datatype _TCHAR for whatever reason.

I would suggest that you ignore that as long as it is working fine on your PC.

[jzp253]

do it like this

do{
cout << "How are you?\n";
getline(cin, a);


cout << a << "thats cool"\n;
system("pause");
cout << " Do you want to continue y/n : ";
cin >> a;
}
while(a == y);

if(a == n){
return 0;
}

[nhrnjic]

and why does it say that var ope is being used without initialization,how to fix that

[Moschops]

how to fix that

char ope; // What is the value of ope? Who knows. It could be anything. It is uninitialised

char ope = 'z'; // What is the value of ope? The value is 'z'. It has been initialised

[jzp253]

have you declared it as int ope, or long ope, char ope, string ope, float ope?

[jzp253]

Tried to help you out. Has a flaw where ervything comes out to -54 or 54. lol im pretty sure 1+1=2 not 54.

#include <iostream>

using namespace std;
int main()
{
    int a, b;
    int Choice;
    int r;

    cout << "Choose a operation.\n";
    cout << "1) Addition\n";
    cout << "2) Subtraction\n";
    cout << "3) Multiplication\n";
    cout << "4) Division\n";
    cin >> Choice;
    
    if(Choice == 1){
              cout << "Enter a number:";
              cin >> Choice;
              cout << endl;
              cout << "Enter a second number:";
              cin >> Choice;
              cout << endl;
              r = a + b;
              cout << "The number = " << r;
              system("pause");
              }
    else if(Choice == 2){
         cout << "Enter a number:";
         cin >> Choice;
         cout << endl;
         cout << "Enter a second number:";
         cin >> Choice;
         cout << endl;
         r = a - b;
         cout << "The number = " << r;
         system("pause");
         }

}

[nhrnjic]

Thank you people,my program finnaly works as I wanted :)