WinAPI button not appearing

[wonopon]

Hey I've read over my code several times but I can't seem to find the problem. My button doesn't appear when I run the program.

#include <windows.h>
#define ID_BUTTON 100

/*  Declare Windows procedure  */
LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM);

/*  Make the class name into a global variable  */
char szClassName[ ] = "CodeBlocksWindowsApp";

HINSTANCE instance;

int WINAPI WinMain (HINSTANCE hThisInstance,
                     HINSTANCE hPrevInstance,
                     LPSTR lpszArgument,
                     int nCmdShow)
{
    HWND hwnd;               /* This is the handle for our window */
    MSG messages;            /* Here messages to the application are saved */
    WNDCLASSEX wincl;        /* Data structure for the windowclass */

    HBRUSH bg = CreateSolidBrush(RGB(10, 20, 30));

    /* The Window structure */
    instance = hThisInstance;
    wincl.hInstance = hThisInstance;
    wincl.lpszClassName = szClassName;
    wincl.lpfnWndProc = WindowProcedure;      /* This function is called by windows */
    wincl.style = CS_DBLCLKS;                 /* Catch double-clicks */
    wincl.cbSize = sizeof (WNDCLASSEX);

    /* Use default icon and mouse-pointer */
    wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hCursor = LoadCursor (NULL, IDC_ARROW);
    wincl.lpszMenuName = NULL;                 /* No menu */
    wincl.cbClsExtra = 0;                      /* No extra bytes after the window class */
    wincl.cbWndExtra = 0;                      /* structure or the window instance */
    /* Use Windows's default colour as the background of the window */
    wincl.hbrBackground = (HBRUSH) bg;

    /* Register the window class, and if it fails quit the program */
    if (!RegisterClassEx (&wincl))
        return 0;

    /* The class is registered, let's create the program*/
    hwnd = CreateWindowEx (
           0,                   /* Extended possibilites for variation */
           szClassName,         /* Classname */
           "Phone Number Converter",       /* Title Text */
           WS_OVERLAPPEDWINDOW, /* default window */
           CW_USEDEFAULT,       /* Windows decides the position */
           CW_USEDEFAULT,       /* where the window ends up on the screen */
           544,                 /* The programs width */
           250,                 /* and height in pixels */
           HWND_DESKTOP,        /* The window is a child-window to desktop */
           NULL,                /* No menu */
           hThisInstance,       /* Program Instance handler */
           NULL                 /* No Window Creation data */
           );

    /* Make the window visible on the screen */
    ShowWindow(hwnd, SW_SHOW);
    UpdateWindow(hwnd);

    /* Run the message loop. It will run until GetMessage() returns 0 */
    while (GetMessage (&messages, NULL, 0, 0))
    {
        /* Translate virtual-key messages into character messages */
        TranslateMessage(&messages);
        /* Send message to WindowProcedure */
        DispatchMessage(&messages);
    }

    /* The program return-value is 0 - The value that PostQuitMessage() gave */
    return messages.wParam;
}


/*  This function is called by the Windows function DispatchMessage()  */

LRESULT CALLBACK WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    HWND Convert;
    switch (message)                  /* handle the messages */
    {
        case WM_DESTROY:
            PostQuitMessage (0);       /* send a WM_QUIT to the message queue */
            break;
        case WM_COMMAND:
            if(((HWND)lParam) && (HIWORD(wParam) == BN_CLICKED))
            {
                int thing = LOWORD(wParam);
                switch (thing)
                {
                    case ID_BUTTON:
                        MessageBox(hwnd, "Hello World!", "Test", MB_OK);
                        break;
                    default:
                        break;
                }
            }
            break;
        case WM_CREATE:
        {
            Convert = CreateWindowEx(
                0,
                TEXT("Button"),
                TEXT("Convert"),
                WS_VISIBLE | WS_TILED | BS_DEFPUSHBUTTON,
                100,
                100,
                5,
                5,
                hwnd,
                (HMENU) ID_BUTTON,
                instance,
                NULL);
                break;
        }
        default:                      /* for messages that we don't deal with */
            return DefWindowProc (hwnd, message, wParam, lParam);
    }

    return 0;
}

[freddie1]

Why don't you try just WS_CHILD | WS_VISIBLE for your button style, and increase the size to something reasonable instead of the width of 5 and height of 5 (try 80, 30)?

[wonopon]

thanks but it still doesn't work

[freddie1]

It looks to me like you are trying to mix up dialog box coding styles with CreateWindow standard Sdk coding style. I don't think BS_DEFPUSHBUTTON has any effect (not positive, anyway) in standard CreateWindow type windows. Anyway, that's the only thing that jumped out at me in your code. Rather than me trying to fix it, will you just try this instead. It should work...

#include <windows.h>
#include <tchar.h>
#define IDC_BUTTON   1500

LRESULT CALLBACK fnWndProc(HWND hwnd, unsigned int msg, WPARAM wParam, LPARAM lParam)
{
 switch(msg)
 {
  case WM_CREATE:
    {
       HINSTANCE hIns=((LPCREATESTRUCT)lParam)->hInstance;
       DWORD dwStyle=WS_CHILD|WS_VISIBLE;
       HWND hButton=CreateWindow(_T("button"),_T("Click Me!"),dwStyle,90,80,160,40,hwnd,(HMENU)IDC_BUTTON,hIns,0);
       return 0;
    }
  case WM_COMMAND:
    {
       if(LOWORD(wParam)==IDC_BUTTON && HIWORD(wParam)==BN_CLICKED)
          MessageBox(hwnd,_T("Thanks!  I Needed That!"),_T("AAAhhhh!"),MB_OK);
       return 0;
    }
  case WM_DESTROY:
    {
       PostQuitMessage(0);
       return 0;
    }
 }

 return (DefWindowProc(hwnd, msg, wParam, lParam));
}


int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszArgument, int iShow)
{
 TCHAR szClassName[]=_T("Form1");
 WNDCLASSEX wc;
 MSG messages;
 HWND hWnd;

 wc.lpszClassName=szClassName,                wc.lpfnWndProc=fnWndProc;
 wc.cbSize=sizeof (WNDCLASSEX),               wc.style=0;
 wc.hIcon=LoadIcon(NULL,IDI_APPLICATION),     wc.hInstance=hInstance;
 wc.hIconSm=LoadIcon(NULL, IDI_APPLICATION),  wc.hCursor=LoadCursor(NULL,IDC_ARROW);
 wc.hbrBackground=(HBRUSH)COLOR_BTNSHADOW,    wc.cbWndExtra=0;
 wc.lpszMenuName=NULL,                        wc.cbClsExtra=0;
 RegisterClassEx(&wc),
 hWnd=CreateWindowEx(0,szClassName,szClassName,WS_OVERLAPPEDWINDOW,350,250,350,300,HWND_DESKTOP,0,hInstance,0);
 ShowWindow(hWnd,iShow);
 while(GetMessage(&messages,NULL,0,0))
 {
    TranslateMessage(&messages);
    DispatchMessage(&messages);
 }

 return messages.wParam;
}

[S G H]

What about using resources? Ms visual studio has some nice features for form designing if you use resources.