Window opens, then closes

(Continued)
---"Game Engine.h"---

#ifndef GAMEENGINE_H
#define GAMEENGINE_H

//Include files
#include <windows.h>

// Windows function declarations
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, PSTR szCmdLine, int iCmdShow);
LRESULT CALLBACK WndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam);

/* Game Engine function declarations
These functions are game-specific and must be specified per game */
BOOL GameInitialize(HINSTANCE hInstance);
void GameStart(HWND hWindow);
void GameEnd();
void GameActivate(HWND hWindow);
void GameDeactivate(HWND hWindow);
void GamePaint(HDC hDC);
void GameCycle();

// GameEngine Class
class GameEngine
{
      protected:
                //Member variables
                static GameEngine* m_pGameEngine;
                HINSTANCE          m_hInstance;
                HWND               m_hWindow;
                TCHAR              m_szWindowClass[32];
                TCHAR              m_szTitle[32];
                WORD               m_wIcon, m_wSmallIcon;
                int                m_iWidth, m_iHeight;
                int                m_iFrameDelay;
                BOOL               m_bSleep;
                
      public:
             //Constructor(s), Destructor
             GameEngine(HINSTANCE hInstance, LPTSTR szWindowClass, LPTSTR szTitle, WORD wIcon, WORD wSmallIcon,
                                  int iWidth = 640, int iHeight = 480);
             //For different sizes, change this ^^^       and this  ^^^
             virtual ~GameEngine();
             
             // General methods
             static GameEngine* GetEngine() { return m_pGameEngine; };
             BOOL               Initialize(int iCmdShow);
             LRESULT            HandleEvent(HWND hWindow, UINT msg, WPARAM wParam, LPARAM lParam);
             
             //Accessor methods
             HINSTANCE GetInstance() { return m_hInstance; };
             HWND      GetWindow()   { return m_hWindow; };
             void      SetWindow(HWND hWindow) { m_hWindow = hWindow; };
             LPTSTR    GetTitle() { return m_szTitle; };
             WORD      GetIcon() { return m_wIcon; };
             WORD      GetSmallIcon() { return m_wSmallIcon; };
             int       GetWidth() { return m_iWidth; };
             int       GetHeight() { return m_iHeight; };
             int       GetFrameDelay() { return m_iFrameDelay; };
             void      SetFrameRate(int iFrameRate) { m_iFrameDelay = 1000 / iFrameRate; };
             BOOL      GetSleep() { return m_bSleep; };
             void      SetSleep(BOOL bSleep) { m_bSleep = bSleep; };
};

#endif

Last edited on

For the love of... I have never been one to refuse to help people because they didn't use code blocks. But this has no code blocks, no indentation, multiple declerations of the same stuff as far as I can tell, inadequate spacing, non-standard notation... The list just keeps going. How can you even read this?

@OP Your code would indeed be more readable if, for a start, you used code tags:
[code]int main()[/code] = int main()
As for indentation, most common IDEs will do that for you these days... Which one are you using?

@Computergeek:

because they didn't use code blocks

Lol, at first I thought you meant the IDE!

Ah! Code Tags, yes I did mean Code Tags. Brain Fart.

Still, Code::Blocks is good too :P
EDIT: I assumed then that by code blocks (no scope resolution operator), you meant splitting code segments with frequent vertical white space - also a good idea ;)

Last edited on

webJose (2948)

@Xander: How in the wooooorld do you manage to write [ code ] without making it a code block!?? LOL. It kills me not to know!

I use Teletype when ever it comes up. [tt][/tt]

Hehe I saw someone else do it - and I worked out how from seeing the unformatted summary on the "My Topics" page.

I do this:
[co[i][/i]de]...[/co[i][/i]de]

And I have now done the same thing for italic tags :)

EDIT: It was 58 characters unformatted!

PS: @OP I feel bad we haven't provided any help yet and have started chatting on your thread. I'm just about to go out now, so I can't look now, but if you add code tags, and preferably indentation, I'll take a closer look at your code later if I get the chance :)

Last edited on

Sorry about that. This was my first post ever on cplusplus.com, so I didn't know how to use the code tag.
As for my IDE, I'm using Bloodshed Dev-C++, but I'd be inclined to use a different one if someone suggested another. I've tried Microsoft Visual C++ 2010 already, though, and it's not as straightforward as Dev-C++.

Null (957)

You can try CodeBlocks (http://www.codeblocks.org )

and read why you shouldn't use Dev-C++: http://www.cplusplus.com/forum/articles/36896/

wxDev-C++ is sort of the succesor to Bloodshed: http://wxdsgn.sourceforge.net/
There's nothing wrong with Code::Blocks but with wx you'll have less of a learning curve.

It seems that Code::Blocks is pretty straightforward. Now that I run the GameEngine Test file with Code::Blocks, I get a different error message:
"Warning `x -c' after last input file has no effect
no resources"
I'll post the rest of the code for the GameEngine Test project soon.

Sorry about that. This was my first post ever on cplusplus.com

Don't worry about it - it takes a while for any of us to get used to the conventions of any new forum :)

Code that I promised:

//Game Engine Test.cpp file
#include "GameEngine Test.h"

BOOL GameInitialize(HINSTANCE hInstance)
{
       g_pGame = new GameEngine(hInstance, TEXT("GameEngine Test"), TEXT("GE Test"),
               IDI_SMILEY, IDI_SMILEY_SM);
       if (g_pGame == NULL)
       return FALSE;
       
       g_pGame->SetFrameRate(1);
       
       return TRUE;
}

void GameStart(HWND hWindow)
{
}

void GameEnd()
{
     delete g_pGame;
}

void GameActivate(HWND hWindow)
{
}

void GameDeactivate(HWND hWindow)
{
}

void GamePaint(HDC hDC)
{
}

void GameCycle()
{
}

//GameEngineTestResources
//A.K.A. GETRes.h

#ifndef GETRES_H
#define GETRES_H

#define IDI_SMILEY       1000
#define IDI_SMILEY_SM    1001

#endif

//GameEngine Test.h Header file

#ifndef GAMEENGINETEST_H
#define GAMEENGINETEST_H

#include <windows.h>
#include "Game Engine.h"
#include "GETRes.h"

GameEngine* g_pGame;

#endif

//GameEngine Test.rc

#include "GETRes.h"

IDI_SMILEY         ICON     "SkelRes\\Skeleton.ico"
IDI_SMILEY_SM      ICON     "SkelRes\\SkeletonSm.ico"

I very much doubt any of that code is causing the error you still have. If anything, it sounds like something to do with Code::Blocks configuration.

That last warning you mentioned sounds like you have some stray commands in your linking section of the IDE.

EDIT: Also if your window is opening and imediatly closing then This may be caused by Line 19 + 20 in your WinMain function. You have return FALSE; on Line 20 which would quite the program immediatly when that condition is met.

Last edited on

The If statement closes the window if the game engine cannot be initialized, so as long as the game engine is initialized, it won't need to return FALSE. Besides that, I only had the opening/closing problem on Dev-C++.
Any ideas what I might need to change in Code::Blocks so the project runs correctly? I'm using the default specifications. To make the file, I used New Project > Win32 GUI Application, and ticked the "Do not create any files" box.

Did you find any stray commands in your linker section?