EnumProcesses: program crashes.

[Obj3ct]

Hello, why does the program below crash?

#include <windows.h>
#include <tchar.h>
#include <psapi.h>
#include <iostream>

int main()
{

    DWORD nProcess[1024], bN, bR;
    bN = sizeof(nProcess);
    int NrProcess;

    if(EnumProcesses(nProcess, bN, &bR) != 0)
    {
        std::cout << "EnumProcesses failed: " << GetLastError() << ".\n";
    }
    else
    {
        std::cout << "EnumProcesses has been called!\n";
        NrProcess = (bR/sizeof(DWORD));
        std::cout << "Processes currently running: " << NrProcess << ".\n";
    }

    return 0;
}

[kbw]

The Microsoft docs say

If the function succeeds, the return value is nonzero.

bN is incorrect, causing EnumProcess to overwrite parts of the stack.

bN = sizeof(nProcess) / sizeof(DWORD);

[Obj3ct]

Thanks.
I changed bN and and 0 to 1 but it still doesn't work.

[Kiana]

What's the error-code returned by GetLastError?

[Obj3ct]

Nothing, since it crashes.

[firedraco]

When does it crash?

[hanst99]

You can leave the != part completely out. Nonzero values are true.

Programs that must run on earlier versions of Windows as well as Windows 7 and later versions should always call this function as EnumProcesses. To ensure correct resolution of symbols, add Psapi.lib to the TARGETLIBS macro and compile the program with –DPSAPI_VERSION=1. To use run-time dynamic linking, load Psapi.dll.

Not sure, but might that be a problem?

[kbw]

I'm back on Windows. I've just compiled it with my recomended fixes and it works.

I'm not sure what you think NrProcess does, but it's wrong.