Array Return

[G26pX9L8]

I have made a function for receiving data on a socket connection. Now what I want is that function returns the received data. The data could be anything so that's the reason why I chose for a char.

char* FuncRecv(SOCKET sock)
{
    char buffer[256]="";
    ZeroMemory(buffer, sizeof(buffer));

    if(recv(sock,buffer,sizeof(buffer),0) == SOCKET_ERROR)
    {
        closesocket(client);
        WSACleanup();
    }
    //MessageBox(NULL, buffer, "QRecv", MB_OK);

    return (char*) buffer;
}

But this code only returns one character and that is logical because buffer is declared as a char instead of a char*, but by doing that I get a runtime error. Any solutions how to solve this?

[simo110]

Your variable named "buffer" is the stack area.When your program run out this function,the stack area will be destroyed.
You can use a global array for "buffer".
e.g:

char buffer[256];
char * FuncRecv(SOCKET sock)
{
     ...
}

[carlsum1986]

use a global array or pass in a buffer as a parameter and let the function set the buffer data

[G26pX9L8]

tnx both, its working now, I am using a global array.

[Kiana]

Don't pollute the global scope. It's bad.
And why are you closing the socket inside your recv wrapper?

inline int FuncRecv(SOCKET sock, char* buffer, int size)
{
  return recv(sock, buffer, size, 0);
}

[simo110]

For some C complier,there are no inline.You have to define global scope to transfer data.
Especially in embeded system.almost 80% of them use the standard C or cutted C.
How to solve this bug depend the situation.All rules may have to change for special situation.