Access Violation when calling Class Function from WndProc

[NoobCpp1]

Greetings,

I receive an access violation error when calling a Class Function from WM_MOVE in the WindowProc function.

If I instead call this Class Function from WinMain, or certain other WM_* in WindowProc, I do not get the error.

An explanation for this error would be much appreciated. My source with comment is below:

#include <Windows.h>
#define WINDOW_NAME L"Application"
#define WINDOW_CLASSNAME L"WindowClass1"
LRESULT WINAPI WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);

class CTestClass
{
private:
    int Number;
public:
    CTestClass();
    virtual ~CTestClass();
    void TestFunction();
};

CTestClass::CTestClass()
{
    Number = 100;
}

CTestClass::~CTestClass()
{
}

void CTestClass::TestFunction()
{
    if (Number == 100) // Access violation here, after calling this function from WindowProc
    {
        MessageBox(NULL, L"Test", NULL, NULL);
    }
}

CTestClass* g_TestClass;

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow)
{
    WNDCLASS WindowClass;
    ZeroMemory(&WindowClass, sizeof(WNDCLASS));
    WindowClass.style = CS_DBLCLKS;
    WindowClass.lpfnWndProc = WindowProc;
    WindowClass.cbClsExtra = 0;
    WindowClass.cbWndExtra = 0;
    WindowClass.hInstance = hInstance;
    WindowClass.hIcon = NULL;
    WindowClass.hCursor = LoadCursor(NULL, IDC_ARROW);
    WindowClass.hbrBackground = (HBRUSH)GetStockObject(BLACK_BRUSH);
    WindowClass.lpszMenuName = NULL;
    WindowClass.lpszClassName = WINDOW_CLASSNAME;

    RegisterClass(&WindowClass);

    HWND hWnd;

    hWnd = CreateWindow(WINDOW_CLASSNAME, WINDOW_NAME, WS_OVERLAPPEDWINDOW,
                        10, 10, 800, 600, NULL, NULL, hInstance, NULL);

    ShowWindow(hWnd, nCmdShow);

    g_TestClass = new CTestClass(); // Initialize the Test Class

    MSG Message;
    Message.message = NULL;

    while (Message.message != WM_QUIT)
    {
        if (PeekMessage(&Message, NULL, 0, 0, PM_REMOVE))
        {
            TranslateMessage(&Message);
            DispatchMessage(&Message);
        }
    }

    delete g_TestClass;

    return Message.wParam;
}

LRESULT WINAPI WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    switch (message)
    {
    case WM_DESTROY:
        PostQuitMessage(0);
        break;

    case WM_MOVE:
        g_TestClass->TestFunction(); // Call the Test Function --> Leads to Access Violation
        return DefWindowProc(hWnd, message, wParam, lParam);    
        break;
    }

    return DefWindowProc(hWnd, message, wParam, lParam);
}

The value of "Number" variable is unknown in the debugger output.

[thmm]

The problem is that g_TestClass is still NULL when WM_MOVE is called.
The easiest solution is not to use a pointer, it works without pointer.

#include <Windows.h>
#define WINDOW_NAME L"Application"
#define WINDOW_CLASSNAME L"WindowClass1"
LRESULT WINAPI WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);

class CTestClass
{
private:
  int Number;
public:
  CTestClass();
  virtual ~CTestClass();
  void TestFunction();
};

CTestClass::CTestClass()
{
  Number = 100;
}

CTestClass::~CTestClass()
{
}

void CTestClass::TestFunction()
{
  if (Number == 100) // Access violation here, after calling this function from WindowProc
  {
    MessageBox(NULL, L"Test", NULL, NULL);
  }
}

CTestClass g_TestClass;

int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow)
{
  WNDCLASS WindowClass;
  ZeroMemory(&WindowClass, sizeof(WNDCLASS));
  WindowClass.style = CS_DBLCLKS;
  WindowClass.lpfnWndProc = WindowProc;
  WindowClass.cbClsExtra = 0;
  WindowClass.cbWndExtra = 0;
  WindowClass.hInstance = hInstance;
  WindowClass.hIcon = NULL;
  WindowClass.hCursor = LoadCursor(NULL, IDC_ARROW);
  WindowClass.hbrBackground = (HBRUSH)GetStockObject(BLACK_BRUSH);
  WindowClass.lpszMenuName = NULL;
  WindowClass.lpszClassName = WINDOW_CLASSNAME;

  RegisterClass(&WindowClass);

  HWND hWnd;

  hWnd = CreateWindow(WINDOW_CLASSNAME, WINDOW_NAME, WS_OVERLAPPEDWINDOW,
    10, 10, 800, 600, NULL, NULL, hInstance, NULL);

  ShowWindow(hWnd, nCmdShow);

  MSG Message;
  Message.message = NULL;

  while (Message.message != WM_QUIT)
  {
    if (PeekMessage(&Message, NULL, 0, 0, PM_REMOVE))
    {
      TranslateMessage(&Message);
      DispatchMessage(&Message);
    }
  }
  return Message.wParam;
}

LRESULT WINAPI WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
{
  switch (message)
  {
  case WM_DESTROY:
    PostQuitMessage(0);
    break;

  case WM_MOVE:
    g_TestClass.TestFunction(); // Call the Test Function --> Leads to Access Violation
    return DefWindowProc(hWnd, message, wParam, lParam);
    break;
  }

  return DefWindowProc(hWnd, message, wParam, lParam);
}

[NoobCpp1]

Thx. I previously thought that the WM_MOVE could only happen after the DispatchMessage call but I was mistaken.

[deleted account xyzzy]

If you are so enamored of using a pointer and manual memory management for your class, move g_TestClass = new CTestClass(); BEFORE your ShowWindow call.

When an app's window is created and shown for the first time there are multiple messages sent to the message queue, one of those messages sent is WM_MOVE.

[deleted account xyzzy]

An alternative to using a global variable pointer is to use the either of the cbClsExtra or cbWndExtra struct members to store the pointer to your allocate heap memory. Instead of initializing both to zero use one to reserve extra space for holding the pointer. Assign the member with new in WinMain before registering the window class, retrieve the pointer in WndProc with GetClassLongPtr.

Or set the pointer to heap memory with SetClassLongPtr before showing the window in WinMain.

You could then free the heap memory allocated either when your message pump ends WinMain as you are currently doing, or in your WM_DESTROY case in WndProc.

After all that is what those two data members are for, potentially reserving extra space for class or individual window instance custom uses.

https://stackoverflow.com/questions/13330225/cbclsextra-and-cbwndextra

Do remember the size of a pointer can be different when compiled for a 32-bit target vs. 64-bit.

[deleted account xyzzy]

cbClsExtra or cbWndExtra could conceivably be used to hold an instance of your custom class, no need to use heap memory. No heap memory, no need to delete, the extra assigned memory goes buh-bye when the app is destroyed.

[seeplus]

I previously thought that the WM_MOVE could only happen after the DispatchMessage call but I was mistaken.

Messages are queued as soon as any API is used that can generate a message. They are only processed once the message loop is running and processing messages.