look the code

[PXP]

Hi. Can someone look this code and say mistakes ?

#include <iostream.h>
#include <fstream.h>
#include <string.h>
#include <time.h>
#include <stdlib.h>
#include <windows.h>
#include "pp.h"
using namespace std;
///////////////////////////////////////////////////////
class zaidimas {
 public:
  void LoadFile();
  void kartuves(int State);
  void RunGame();

 private:
  typedef char String[MAX_WORD_SIZE];
  String Words[MAX_WORDS - 1];
  char C;
  int Count;

  char Word;
  int Size;
  int State;
  int Subscript;
  char Guess[MAX_WORD_SIZE];
  char Copy[MAX_WORD_SIZE];
  char Letter;
  int Correct;
};
///////////////////////////////////////////////////////
void zaidimas::LoadFile()
{
  char C;
  int Count =0;
  ifstream Datfile;
  Datfile.open("words.dat");

  while((C=Datfile.peek()) !=EOF)
   {
     Datfile>>Words[Count++];

     if(Count > MAX_WORDS - 1)
     {
       cout<<endl<<"Too many words"
       <<MAX_WORDS<<" words."<<endl;

       Count = MAX_WORDS;
       break;
     }
   }

   Count--;
   Datfile.close();
////////////////////////////////////////////////////////
void zaidimas::kartuves(int State)
{
  if(State==6)
  {
		cout<<endl<<endl
			<<"   +----+     "<<endl
			<<"   |    |     "<<endl
			<<"   |    O     "<<endl
			<<"   |   /|\\   "<<endl
			<<"   |   / \\   "<<endl
			<<"   |Your Dead "<<endl
			<<"  ============"<<endl<<endl;
	}
	else if(State==5)
	{
		cout<<endl<<endl
			<<"   +----+  "<<endl
			<<"   |    |  "<<endl
			<<"   |    O  "<<endl
			<<"   |   /|\\ "<<endl
			<<"   |     \\ "<<endl
			<<"   |       "<<endl
			<<"  ============"<<endl<<endl;
	}
	else if(State==4)
	{
		cout<<endl<<endl
			<<"   +----+  "<<endl
			<<"   |    |  "<<endl
			<<"   |    O  "<<endl
			<<"   |   /|\\ "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"  ============="<<endl<<endl;
	}
	else if(State==3)
	{
		cout<<endl<<endl
			<<"   +----+  "<<endl
			<<"   |    |  "<<endl
			<<"   |    O  "<<endl
			<<"   |   /|  "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"  ============="<<endl<<endl;
	}
	else if(State==2)
	{
		cout<<endl<<endl
			<<"   +----+  "<<endl
			<<"   |    |  "<<endl
			<<"   |    O  "<<endl
			<<"   |    |  "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"  ============="<<endl<<endl;
	}
	else if(State==1)
 {
		cout<<endl<<endl
			<<"   +----+  "<<endl
			<<"   |    |  "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"   |       "<<endl
			<<"  ============="<<endl<<endl;
	}


}
///////////////////////////////////////////////////////
void zaidimas::RunGame()
{
  int State=1;
  int Subscript=0;
  int Correct=0;

     // Seed and create a random number
    srand((unsigned)time(NULL));	// use time as a seed
    Word = rand() % Count;

	// kopijuoja zodi
	strcpy(Copy,Words[Word]);

	Size = strlen(Words[Word]); // gaunamas zodio ilgis

 	// Create a null terminated string to represent the word as the
  	// Create a null terminated string to represent the word as the
	// player knows it.
	for(; Subscript < Size; Subscript++)
	{
		Guess[Subscript] = '-';
	}

	// insert the null charachter
	Guess[Subscript] = '\0';

	// Cilklas vyksta, kol zaidejas pakariamas
	while(State!=6)
	{
		kartuves(State);	//piesia kartuves
		cout<<Guess<<endl;	// uzraso spejama zodi

		cout<<"Guess a letter :";
		cin>>Letter;

		// We will use only lower case letters
	    //Letter = tolower(Letter);
		
		// Loop through the word
		for(Subscript = 0; Subscript < Size; Subscript++)
		{

			//jei spejimas geras, apie tai informuojamas zaidejas ir spejimas uzrasomas
			if(Copy[Subscript] == Letter)
			{
				Guess[Subscript] = Letter;
				Correct = 1;
				cout<<endl<<"Good Guess!";

				//Jei spejimas = spejamam zodziui, zaidejas laimi ir programa baigia sawo darba.
				if(strcmp(Words[Word],Guess) == 0)
				{
					cout<<endl<<"Yea, You survived and won!";
					return;
				}
			}
		}

		//Jei raides neatspeja.
		if(Correct == 0)
		{
			cout<<endl<<"Sorry, bad guess!";
			State++;
		}

		Correct = 0;	// reset Correct

	}

	kartuves(State);	//Zaidimo pabaigoje nupiesiamos kartuves.
	//Zaidejas pralose, todel jam parodomas spejamas zodis.
	cout<<"The word was : "<<Words[Word]<<endl<<endl;	

}
//////////////////////////////////////////////////////
int main()
{
     SetConsoleTitle("HANKGMAN");
     zaidimas z1, z2;
     cout<<"Hi.LET'S START...!"<<endl;
     z1.LoadFile();
     z2.RunGame();






 system("PAUSE");
}

and pp.h:

#define MAX_WORD_SIZE 15	
#define MAX_WORDS 255

[Zaita]

Line 139: strcpy(Copy,Words[Word]);
You should use strncpy(). strcpy doesn't do any checks prior to copy and is subject to buffer overflows :)

Line 205: in English it's "HANGMAN". Not sure if thats what you meant.

  typedef char String[MAX_WORD_SIZE];
  String Words[MAX_WORDS - 1];

This concerns me. You should be using the string type.

e.g

#include <string>

using namespace std;

int main() {
 string sHello = "Hello";
 cin >> sHello;
 // etc
}

[bnbertha]

...and I would suggest changing your includes

#include <iostream.h>
#include <fstream.h>
#include <string.h> 

to

#include <iostream>
#include <fstream>
#include <string> 

[PXP]

thanks...