(Win32) Button ID problem?

the ID's only register whichever is first, it doesnt matter what the button's id (or textbox's) is,
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
#include <windows.h>
//namespace System::Windows::Forms;


/*  Declare Windows procedure  */
LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM);

//start enum
enum {ID_EXIT,ID_TEST,ID_MISC,};


//end
//start hinstance
HINSTANCE g_hInst;
//end

//start HWND
HWND btn;
HWND txt;
//end

/*  Make the class name into a global variable  */
char szClassName[ ] = "CodeBlocksWindowsApp";

int WINAPI WinMain (HINSTANCE hThisInstance,
                     HINSTANCE hPrevInstance,
                     LPSTR lpszArgument,
                     int nCmdShow)
{
    HWND hwnd;               /* This is the handle for our window */
    MSG messages;            /* Here messages to the application are saved */
    WNDCLASSEX wincl;        /* Data structure for the windowclass */

    /* The Window structure */
    wincl.hInstance = hThisInstance;
    wincl.lpszClassName = szClassName;
    wincl.lpfnWndProc = WindowProcedure;      /* This function is called by windows */
    wincl.style = CS_DBLCLKS;                 /* Catch double-clicks */
    wincl.cbSize = sizeof (WNDCLASSEX);

    /* Use default icon and mouse-pointer */
    wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hCursor = LoadCursor (NULL, IDC_ARROW);
    wincl.lpszMenuName = NULL;                 /* No menu */
    wincl.cbClsExtra = 0;                      /* No extra bytes after the window class */
    wincl.cbWndExtra = 0;                      /* structure or the window instance */
    /* Use Windows's default colour as the background of the window */
    wincl.hbrBackground = (HBRUSH) COLOR_WINDOW;

    /* Register the window class, and if it fails quit the program */
    if (!RegisterClassEx (&wincl))
        return 0;

    /* The class is registered, let's create the program*/
    hwnd = CreateWindowEx (
           0,                   /* Extended possibilites for variation */
           szClassName,         /* Classname */
           "Blackm33k",       /* Title Text */
           WS_OVERLAPPEDWINDOW, /* default window */
           CW_USEDEFAULT,       /* Windows decides the position */
           CW_USEDEFAULT,       /* where the window ends up on the screen */
           300,                 /* The programs width */
           300,                 /* and height in pixels */
           HWND_DESKTOP,        /* The window is a child-window to desktop */
           NULL,                /* No menu */
           hThisInstance,       /* Program Instance handler */
           NULL                 /* No Window Creation data */
           );

    /* Make the window visible on the screen */
    ShowWindow (hwnd, nCmdShow);

    /* Run the message loop. It will run until GetMessage() returns 0 */
    while (GetMessage (&messages, NULL, 0, 0))
    {
        /* Translate virtual-key messages into character messages */
        TranslateMessage(&messages);
        /* Send message to WindowProcedure */
        DispatchMessage(&messages);
    }

    /* The program return-value is 0 - The value that PostQuitMessage() gave */
    return messages.wParam;
}


/*  This function is called by the Windows function DispatchMessage()  */

LRESULT CALLBACK WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    switch (message)                  /* handle the messages */
    {
        //GUI/API CREATION
        case WM_CREATE:
            btn = CreateWindow("Button", "&Exit", BS_DEFPUSHBUTTON | WS_CHILD | WS_VISIBLE, 247, 3, 45, 20, hwnd, (HMENU) ID_EXIT, g_hInst, 0);
            btn = CreateWindow("Button", "Test2", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE, 100, 100, 45, 20, hwnd, (HMENU) ID_EXIT, g_hInst, 0);
            txt = CreateWindow("Edit","Modify me",WS_BORDER | WS_VISIBLE | WS_CHILD | ES_MULTILINE | WS_VISIBLE ,10,50,170,50,hwnd , (HMENU) ID_MISC, g_hInst, 0);

        break;
        //END
        //ID VARIABLE
        case WM_COMMAND:
            case ID_EXIT:
               MessageBox(hwnd ,"You must enter a name.", "Name Entry Error", 0);
          break;
            case ID_MISC:
                MessageBox(hwnd ,"You must enter a name.", "Name Entry Error", 0);
           break;
       break;
       //END
            case WM_DESTROY:
                PostQuitMessage (0);       /* send a WM_QUIT to the message queue */
            break;
        default:                      /* for messages that we don't deal with */
            return DefWindowProc (hwnd, message, wParam, lParam);
    }

    return 0;
}
Last edited on
In your CreateWindow() calls to create your child window controls you specified ID_EXIT for all three controls. Not much good will come of that.
ive tried with ID_MISC and ID_ TEST all it does is register ID_EXIT
Why don't you just try this instead of the enum...

1
2
3
#define ID_EXIT    1500
#define ID_TEST    1505
#define ID_MISC    1510 
Last edited on
Without looking over the rest of your code, this declaration of yours is probably throwing things off -

enum {ID_EXIT,ID_TEST,ID_MISC,};

You should remove the comma after ID_MISC.
Yea, I saw that too Lamblion, and wasn't sure what effect that would have. I even wondered if it was some syntactic variation of the enum keyword I wasn't familiar with!

You just can't be TOO careful coding. I'll tell you that!
In the original code there is a problem with the switch - You are testing the WM_COMMAND incorrectly:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
       
 case WM_COMMAND:
//  Error here - The IDs of child windows are given (if I remember correctly) in the wparam
//of the WM_COMMAND message.
//So the following two checks should be in a nested switch block switch (wparam)
//
     case ID_EXIT:            
     MessageBox(hwnd ,"You must enter a name.", "Name Entry Error", 0);
     break;

     case ID_MISC:
     MessageBox(hwnd ,"You must enter a name.", "Name Entry Error", 0);
     break;


  break;
 

Last edited on
Guestgulgan is correct, i.e., you need to nest your IDs in a switch statement under WM_COMMAND, so that it would start like this --

1
2
3
4
5
6
case WM_COMMAND:
switch(LOWORD(wParam))
{
       case ID_MISC:
       etc.
}
Last edited on
Topic archived. No new replies allowed.