Help editing my C++ Program

[Shadow Kurimeki]

Hey I posted this once already but twas gone the next day
My problem is that when ever I enter the correct answer for my Cin statement it will still go to the next cout statement and wont cut the the next question

#include<iostream>
#include<string>
using namespace std;
int main()
{
string char1, char2, char3, char4, char5, char6;
    
cout<<"Hello this is your standard True and False quiz"<<endl;
cout<<"Please enter 'T' or 'F'"<<endl;
cout<<"No#1 George Washington invented the toilet?"<<endl;
cin>>char1;


if ( char1 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char1;
};
if ( char1 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char1;
};
if ( char1 == "T" )
{
cout<<"You entered the incorrect answer. The answer is False"<<endl;
};


cout<<"No#2 The Squareroot of 3136 is 56?"<<endl;      
cin>>char2;
if ( char2 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char2;
};
if ( char2 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char2;
};
if ( char2 == "F" )
{
cout<<"You entered the incorrect answer. The answer is True"<<endl;
};


cout<<"No#3 
  system("PAUSE");
  return 0;

} 

I want it to go and skip the you entered the incorrect character

[z05DSL3A]

http://www.cplusplus.com/forum/windows/1678/

[Shadow Kurimeki]

Here is the finished program but with the same problem with the incorrect character issue

#include<iostream>
#include<string>
using namespace std;
int main()
{
string char1, char2, char3, char4, char5, char6;
    
cout<<"Hello this is your standard True and False quiz"<<endl;
cout<<"Please enter 'T' or 'F'"<<endl;
cout<<"No#1 George Washington invented the toilet?"<<endl;
cin>>char1;


if ( char1 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char1;
};
if ( char1 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char1;
};
if ( char1 == "T" )
{
cout<<"You entered the incorrect answer. The answer is False"<<endl;
};



cout<<"No#2 The Squareroot of 3136 is 56?"<<endl;      
cin>>char2;
if ( char2 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char2;
};
if ( char2 == "F" )
{
cout<<"You entered the incorrect answer. The answer is True"<<endl;
};



cout<<"No#3 Do you capitalize the seasons?"<<endl;      
cin>>char3;
if ( char3 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char3;
};

if ( char3 == "T" )
{
cout<<"You entered the incorrect answer. The answer is False"<<endl;
};



cout<<"No#4 Is a drum in the percussion area?"<<endl;      
cin>>char4;
if ( char4 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char4;
};

if ( char4 == "F" )
{
cout<<"You entered the incorrect answer. The answer is True"<<endl;
};



cout<<"No#5 The Egg came before the Chicken?"<<endl;      
cin>>char5;
if ( char5 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char5;
};

if ( char5 == "F" || "T" )
{
cout<<"Ha! trick question the answer depends on if you a "<<endl;
cout<<"Creationist or an Evolutionist "<<endl;
};



cout<<"No#6 Computers help everyday life?"<<endl;      
cin>>char6;
if ( char6 != "T" || "F")
{
cout<<"You entered an incorrect character please reenter True of False"<<endl;
cin>>char6;
};

if ( char6 == "F" )
{
cout<<"You entered the incorrect answer. The answer is True"<<endl;
};



cout<<"Your answers where"<<endl;
cout<<""<<endl;
cout<<char1<<char2<<char3<<char4<<char6<<endl;
cout<<""<<endl;


if (char1 == "T" && char2 == "F" && char3 == "T" && char4 == "F" && char6 == "F" )
{
cout<<"You got 0 correct and 5 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "T" && char4 == "F" && char6 == "F" )
{
cout<<"You got 1 correct and 4 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "T" && char4 == "F" && char6 == "F" )
{
cout<<"You got 1 correct and 4 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "F" && char4 == "F" && char6 == "F" )
{
cout<<"You got 1 correct and 4 incorrect"<<endl;
};

if (char1 == "T" && char2 == "F" && char3 == "T" && char4 == "T" && char6 == "F" )
{
cout<<"You got 1 correct and 4 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "T" && char4 == "F" && char6 == "T" )
{
cout<<"You got 1 correct and 4 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "T" && char4 == "F" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "F" && char4 == "F" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "T" && char4 == "T" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "T" && char4 == "F" && char6 == "T" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "F" && char4 == "F" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};

if (char1 == "T" && char2 == "T" && char3 == "T" && char4 == "T" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "T" && char4 == "F" && char6 == "T" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "F" && char4 == "T" && char6 == "F" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "F" && char4 == "F" && char6 == "T" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "T" && char4 == "T" && char6 == "T" )
{
cout<<"You got 2 correct and 3 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "F" && char4 == "F" && char6 == "F" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "T" && char4 == "T" && char6 == "F" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "T" && char4 == "F" && char6 == "T" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "F" && char4 == "T" && char6 == "F" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "F" && char4 == "F" && char6 == "T" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "T" && char4 == "T" && char6 == "T" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "F" && char4 == "T" && char6 == "F" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "F" && char4 == "F" && char6 == "T" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "T" && char2 == "F" && char3 == "F" && char4 == "T" && char6 == "T" )
{
cout<<"You got 3 correct and 2 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "F" && char4 == "T" && char6 == "F" )
{
cout<<"You got 4 correct and 1 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "F" && char4 == "F" && char6 == "T" )
{
cout<<"You got 4 correct and 1 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "T" && char4 == "T" && char6 == "T" )
{
cout<<"You got 4 correct and 1 incorrect"<<endl;
};


if (char1 == "F" && char2 == "F" && char3 == "F" && char4 == "T" && char6 == "T" )
{
cout<<"You got 4 correct and 1 incorrect"<<endl;
};


if (char1 == "T" && char2 == "T" && char3 == "F" && char4 == "T" && char6 == "T" )
{
cout<<"You got 4 correct and 1 incorrect"<<endl;
};


if (char1 == "F" && char2 == "T" && char3 == "F" && char4 == "T" && char6 == "T" )
{
cout<<"You got 5 correct and 0 incorrect"<<endl;
};









  system("PAUSE");
  return 0;

}

Long isnt it

[Zhuge]

The first few if statements, where you use the logical or (||) need to have the variable specified for each statement. The compiler is reading:

if ( char1 != "T" || "F")
And getting if(char1 != "T") and if("T"). Since if("T") is always true, it always sayings the character is incorrect. You want:

if(char1 != "T" && char != "F")
You want a logical and because no matter what character you put in, it cannot be both T and F.

EDIT: Also you check every combination of true and false answers. This seems very redundant; why not just increment a variable for each correct answer?

[Zaita]

Ahhh my eyes =\ This code needs to be tidied up a lot.

Some comments:
1) use functions. You have A LOT of duplicated code.
2) store your functions in an array, or vector so you can iterate through them.
3) use a parseResponse() or similar function.
4) Dynamically build your response string.
5) If I entered an incorrect response, I am asked to re-enter only once. There is no loop to ensure I enter a valid response.

e.g.

#include <vector>
#include <iostream>

using namespace std;

typdef struct Question {
 bool bIsTrue;
 string sQuestion;
}

int main() {
 vector<Question> vQuestionList;
 
 Question q1;
 q1.sQuestion = "2 + 2 = 4";
 q1.bIsTrue = true;
 
 Question q2;
 q2.sQuestion = "2  + 2 = 5";
 q2.bIsTrue = false;

 vQuestionList.push_back(q1);
 vQuestionList.push_back(q2);

 // Now loop through and ask the questions
 vector<Question>::iterator vPtr = vQuestionList.begin();
 while (vPtr != vQuestionList.end()) {
  cout << (*vPtr).sQuestion << endl;
  string sAnswer = "";
  cin >> sAnswer;

  while ( (sAnswer != "T") && (sAnswer != "F") )
    cout << "Invalid Answer, Please Use 'T' or 'F'" << endl;
    cin >> sAnswer;
  }

  parseResponse( (*vPtr).bIsTrue, sAnswer);

  vPtr++; 
 }
}

The parseResponse() function should return True if the answer was right. False if it was incorrect.

This should save you ALOT of code, and make finding bugs a lot quicker.

[DiptenduDas]

Same Problem with two different heading posted by same person!!!!!!
1. Quiz Help
2. Help editing my C++ Program

[zachlr]

By the way, your true/false questions are a bunch of BOOL!

Ha ha get it it's a pun! I crack myself up.