Snake v1.0 final
closed account (zwA4jE8b)
I dare you to find a bug.
|
|
closed account (zwA4jE8b)
|
|
May I ask why you choose to write this in C, or at least in a C like style? I know that Win32 is in C, but you don't have to restrict yourself just becuase of the API, I know for a fact it works good enough in C++ as well.
Last edited on
closed account (zwA4jE8b)
I just wrote it the only way I knew how. I am using conio.h because I do not understand enough about the windows console to do otherwise.
I am a fairly new programmer and really don't know the difference between c and c++ style.
I am using VS 2010 c++
I am a fairly new programmer and really don't know the difference between c and c++ style.
I am using VS 2010 c++
Last edited on
I'm not saying that any part of your code is wrong, it compiles and runs with a few adjustments and I use wxDev-C++(mingw). As for using "conio.h", contrary to popular belief, that actually doesn't matter because header files are compiled into the executable. The only time it makes a difference is when you start to tell other people to use functions from it on forums, this is because it isn't a standard header file so it isn't always an option. This is different from suggesting a third party API because conio.h is very limited compared to something like Boost.
As for bugs, only because you dared me:
- You aren't checking if the PC this is running on is using multiple monitors. Or for that matter what resolution it's running at.
- Your "snake" struct does not have a destructor, nor does it invoke the destructor for it's vector.
- Because you're already including "windows.h" and because "Kernel32.dll" is automatically imported, you should be using "WaitForSingleObject()" instead of "Sleep()" in your pause function, this will actually be better for your goal of not spiking the processor when your game is idle. This is less of a bug an more of a design consideration though.
EDIT: Your function "end_game()" looks like it's incomplete.
As for bugs, only because you dared me:
- You aren't checking if the PC this is running on is using multiple monitors. Or for that matter what resolution it's running at.
- Your "snake" struct does not have a destructor, nor does it invoke the destructor for it's vector.
- Because you're already including "windows.h" and because "Kernel32.dll" is automatically imported, you should be using "WaitForSingleObject()" instead of "Sleep()" in your pause function, this will actually be better for your goal of not spiking the processor when your game is idle. This is less of a bug an more of a design consideration though.
EDIT: Your function "end_game()" looks like it's incomplete.
Last edited on
| Your "snake" struct does not have a destructor, nor does it invoke the destructor for it's vector. |
Compiler generated destructor will work. >_>
Anyway, too many variables appended with '_' for no apparent reason.
And despite what Computergeek said, I'd still recommend not using conio.h simply because it isn't standard.
closed account (zwA4jE8b)
I thought about the destructor but did not know how to implement it.
how do you invoke the destructor for the vector?
how do you invoke the destructor for the vector?
@ firedraco: You are correct, I thought for some reason that he had made the instance of the snake object global but I was wrong.
@ OP: You're fixed level array's look painful, do you have future plans to dynamically generate these?
@ OP: You're fixed level array's look painful, do you have future plans to dynamically generate these?
closed account (zwA4jE8b)
No, this game was made as a practice, I have never written one before.
The fixed level array was painful but fun. I thought about using iterative loops though.
I began using '_' for var names because I like the style. That is the only reason.
What would I put in the destructor if I manually implemented it? I understand destructing dynamic memory using delete.
The fixed level array was painful but fun. I thought about using iterative loops though.
I began using '_' for var names because I like the style. That is the only reason.
What would I put in the destructor if I manually implemented it? I understand destructing dynamic memory using delete.
First of all regarding the destructor, firedraco is right the default destructor will work. For some reason I thought that you initiated your "snake" object inside of main but had the declaration in the global namespace, probably because I've made that mistake so many times before. But to kick off the destructor for a vector here you go: http://www.cplusplus.com/reference/stl/vector/~vector/ it looks ridiculously simple because it is.
Last edited on
Usually, but if you need to get key presses instantly (like you do here), you'd probably want something like the Curses library. Or you could make your game graphical with SFML (it won't be too difficult, really) and use their functions for the keyboard.
closed account (zwA4jE8b)
Cool.
Graphical was next, I just wanted to get the structure and flow correct.
I know if this is a registered window i can just use a windows message loop to get the keystrokes.
I have downloaded sfml but have yet to use it. :P
Graphical was next, I just wanted to get the structure and flow correct.
I know if this is a registered window i can just use a windows message loop to get the keystrokes.
I have downloaded sfml but have yet to use it. :P
@Computergeek01: ¿When was the last time that you explicit called a destructor?
Last edited on
@ne555: Never personally, and to tell you the truth I only found out a few weeks ago that you could. But the OP did ask. As for why you would do it I don't know, but the OP might run across a reason that I can't think of.
closed account (zwA4jE8b)
no, I was just wondering because you brought it up.
however, I have a binary search tree class that has dynamic elements, so I wrote the destructor to delete all of the elements in the tree.
however, I have a binary search tree class that has dynamic elements, so I wrote the destructor to delete all of the elements in the tree.
However you shouldn't explicitly call it. The destructor is called automatically when the object goes out of scope or when you
The only exception that I can recall it's placement
delete it.The only exception that I can recall it's placement
new closed account (1yR4jE8b)
Other than using placement new, I don't see any other reason you would need to explicitly call the destructor. In my experience, that was the online time I've needed it.
Topic archived. No new replies allowed.