a problem with the memory leaking

[DANNY123]

The following code shows the binary search tree:

#include <iostream>
#include <windows.h>
using namespace std;

struct node
{
int key;
struct node*left;
struct node*right;
};

class BinarySearch
{
public:
BinarySearch();

void insert(int k);
void search(int a);

~BinarySearch()
{}
private:
node*proot;
};
BinarySearch::BinarySearch()
{proot=NULL;}

void BinarySearch::insert(int k)
{
if(!proot)
{
proot=new node;
proot->key=k;
return;
}
node*p=proot;
while(p)
{
if(k>p->key)
{
if(p->right==NULL)
{
p->right=new node;
p->right->key=k;

cout<<"insert element"<<k<<""<<endl;
break;
}//enif
p=p->right;
}//endif
else if(k< p->key)
{
if(p->left==NULL)
{
p->left=new node;
p->left->key=k;

cout<<"insert element"<<k<<""<<endl;
break;
}//enif
p=p->left;
}
else break;
}//endwhile
Sleep(1000);
}
void BinarySearch::search(int a)
{
node*p=new node;
p=proot;
if(a==p->key)
{
cout<<"find out the element a"<<endl;
return;
}
while(p!=NULL)
{
if(a>p->key)
{p=p->right;
}
else if(a<p->key)
{p=p->left;
}
else
cout<<"find out the element"<<a<<"";

break;
}
Sleep(600);
}

int main()
{
    BinarySearch bisearch;
    bisearch.insert(4);
    bisearch.insert(5);
    bisearch.insert(6);
    bisearch.insert(2);
    bisearch.insert(13);
    bisearch.search(5);
    
 system("pause");
 return 0;   
}

the compiler throws out exception at line 39:if(k>p->key)
and line 51.

[writetonsharma]

Its should be kept in mind that struct/class members should be initialized properly rather than left to the compiler to decide.

so, you have to add:

proot->right = NULL;
proot->left = NULL;

at various places like after line 33, 44, 56 etc..

[ne555]

indent your code.

node*p=new node;
p=proot; //memory leak 

[Stewbond]

This sort of thing:

while(p!=NULL)
{
    // ...
    break;
}

doesn't make a whole lot of sense. If you break at the end without any condition, then the while statement really turns into an if statement. That is equivalent to:

if (p != NULL)
{
    // ...
}

[Stewbond]

You use a few new keywords. If you do that, you need to add delete keywords. This is probably most appropriate in the destructor.

BinarySearch::~BinarySearch()
{
    while (proot)
    {
        node* temp = proot->right();        
        delete proot;
        proot = temp;
    }
}

[DANNY123]

thanks, I initialized it by add proot->right = NULL;
proot->left = NULL;

[writetonsharma]

post your updated code if the problem is not fixed by including comments from everyone. We can look further.

[Stewbond]

I think I would have initialized the structure like so:

struct node
{
  int key;
  node* left;
  node* right;

  node() : left(this), right(this)  {  }
};

[DANNY123]

this one looks better:

struct node
{
  int key;
  node* left;
  node* right;

  node() : left(this), right(this)  {  }
};