ERROR MESSAGE: Access violation reading location 0xccccccc8.

[tag104367]

Hi i have been fighting with this for hours now and i can't seem to get it. i am getting the message Access violation reading location 0xccccccc8. when i try to print my dynamic array during the overloaded << function in my Flight class. where the error happens is surrounded by *s

#include<iostream>
#include<vector>
#include<string>

using namespace std;



class Airliner
{
public:
	Airliner();
	int getCrewSize();
	friend ostream& operator <<(ostream& outs, Airliner& output); 
private:
	string ID;
	string type;
	int crewSize;
};

class Person
{
public:
	Person();
	friend ostream& operator <<(ostream& outs, Person& output); 
private:
	string name;
	string phone;
};

class Flight
{
public:
	Flight();
	~Flight();
	friend ostream& operator <<(ostream& outs, Flight& output); 
private:
	Person * crew;
	Person pilot;
	Person copilot;
	vector<Person> souls;
	Airliner planeType;
};
//MAIN//
int main()
{
	Flight myFlight;
	cout << myFlight;

	system("PAUSE");
	return 0;
}

//PERSON CLASS//
Person::Person()
{
	cout << "Name: ";
	cin >> name;
	cout << "Cell Phone Number: ";
	cin >> phone;
}

ostream& operator <<(ostream& outs, Person& output)
{
	cout << "Name: " << output.name << endl;
	cout << "Phone: " << output.phone << endl;
	return outs;
}

//AIRLINER CLASS//
Airliner::Airliner()
{
	cout << "Flight ID: ";
	cin >> ID;
	cout << "Flight Type: ";
	cin >> type;
	cout << "Crew Size: ";
	cin >> crewSize;
}

int Airliner::getCrewSize()
{
	return crewSize;
}
ostream& operator <<(ostream& outs, Airliner& output)
{
	cout << "Flight ID: " << output.ID << endl;
	cout << "Flight Type: " << output.type << endl;
	cout << "Flight Crew Size: " << output.getCrewSize() << endl;
	return outs;
}

//FLIGHT CLASS//
Flight::Flight()
{
	cout << "Crew: " << endl;
	Person * crew = new Person[planeType.getCrewSize()];
	cout << crew[0];
	char c;
	int l = 1;
	do
	{
		cout << "Passanger #" << l << ": " << endl;
		Person i;
		souls.push_back(i);
		cout << "Are there more people?(y/n)" << endl;
		cin >> c;
		l++;

	}while(c != 'n' && c!= 'N');
}

Flight::~Flight()
{
	if(crew != NULL)
	{
		delete[] crew;
	}
}

ostream& operator <<(ostream& outs, Flight& output)
{
	int size = output.planeType.getCrewSize();
	outs << "SIZE: " << size << endl;
	outs << "Pilot: " << output.pilot << endl;
	outs << "Co-Pilot: " << output.copilot << endl;
	outs << "Passangers: " << endl;
	for(unsigned int i = 0; i < output.souls.size(); i++)
	{
		outs << "\t" << output.souls[i] << endl;
	}
	outs << "Crew:" << endl;
	//*******************************************
	for(int n = 0; n < size; n++)
	{
		outs << "\t" << output.crew[n] << endl;
	}
        //*******************************************
	return outs;
}

any help is greatly appreciated

Thank You.

[Cubbi]

Person * crew = new Person[planeType.getCrewSize()];
This creates a new pointer called "crew" in the scope of Flight::Flight(), which is gone at the end of that function. output.crew remains uninitialized, and since output was created on stack, it is 0xccccccc, the uninitialized stack memory in Windows debug builds.

Best way to go about it is to use vectors and initialize them before the opening brace of the constructor where possible.

[tag104367]

This is for a class i would also rather use vectors but my teacher is requiring us to use this is there anyway i can do this using a dynamic array?

[Cubbi]

I hope they will explain why this is a bad thing to do (if they don't, read up on rule of three and exception safety)
The minimal fix is to not make a new crew in the constructor, but instead overwrite the existing one:
crew = new Person[planeType.getCrewSize()];
(it would be better to initialize it in the member initialization list, but to do that you'd have to restructure the class to move planeType before crew)

[tag104367]

Wow i am so dumb. haha by changing the Person * crew = new [planeType.getCrewSize()] in the constructor to crew = new [planeType.getCrewSize()] it worked because i was overwriting the one in the class definition its self. Thank you so much!

working code is as follows:

#include<iostream>
#include<vector>
#include<string>

using namespace std;



class Airliner
{
public:
	Airliner();
	int getCrewSize();
	friend ostream& operator <<(ostream& outs, Airliner& output); 
private:
	string ID;
	string type;
	int crewSize;
};

class Person
{
public:
	Person();
	friend ostream& operator <<(ostream& outs, Person& output); 
private:
	string name;
	string phone;
};

class Flight
{
public:
	Flight();
	~Flight();
	friend ostream& operator <<(ostream& outs, Flight& output); 
private:
	Airliner planeType;
	Person * crew;
	Person pilot;
	Person copilot;
	vector<Person> souls;
	//Airliner planeType;
};
//MAIN//
int main()
{
	Flight myFlight;
	cout << myFlight;

	system("PAUSE");
	return 0;
}

//PERSON CLASS//
Person::Person()
{
	cout << "Name: ";
	cin >> name;
	cout << "Cell Phone Number: ";
	cin >> phone;
}

ostream& operator <<(ostream& outs, Person& output)
{
	cout << "Name: " << output.name << endl;
	cout << "Phone: " << output.phone << endl;
	return outs;
}

//AIRLINER CLASS//
Airliner::Airliner()
{
	cout << "Flight ID: ";
	cin >> ID;
	cout << "Flight Type: ";
	cin >> type;
	cout << "Crew Size: ";
	cin >> crewSize;
	cout << "Pilot and Copilot information please:" << endl;
}

int Airliner::getCrewSize()
{
	return crewSize;
}
ostream& operator <<(ostream& outs, Airliner& output)
{
	cout << "Flight ID: " << output.ID << endl;
	cout << "Flight Type: " << output.type << endl;
	cout << "Flight Crew Size: " << output.getCrewSize() << endl;
	return outs;
}

//FLIGHT CLASS//
Flight::Flight()
{
	cout << "Crew: " << endl;
	crew = new Person[planeType.getCrewSize()]; // here was my problem 
	char c;
	int l = 1;
	do
	{
		cout << "Passanger #" << l << ": " << endl;
		Person i;
		souls.push_back(i);
		cout << "Are there more people?(y/n)" << endl;
		cin >> c;
		l++;

	}while(c != 'n' && c!= 'N');
}

Flight::~Flight()
{
	if(crew != NULL)
	{
		delete[] crew;
	}
}

ostream& operator <<(ostream& outs, Flight& output)
{
	int size = output.planeType.getCrewSize();
	outs << "SIZE: " << size << endl;
	outs << "Pilot: " << output.pilot << endl;
	outs << "Co-Pilot: " << output.copilot << endl;
	outs << "Passangers: " << endl;
	for(unsigned int i = 0; i < output.souls.size(); i++)
	{
		outs << "\t" << output.souls[i] << endl;
	}
	outs << "Crew:" << endl;
	
	for(int n = 0; n < size; n++)
	{
		outs << "\t" << output.crew[n] << endl;
	}
	return outs;
}