Help with a function

[ET21]

I've been having issues trying to figure out how to add a string prompt along with two int values into a function. The program is complete outside of the getValue function (which gives me errors when trying to run with it included)

Code:

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

//Symbolic constant for the value of PI

const float PI = 3.14;

//Function Prototypes

int Menu();
int getValue(string, int, int );
float calcSphere(int );
float calcPrism(int, int, int );
float calcCone(int, int );
float calcPyramid(int, int );

int main()
{
int menuChoice,     //The users choice from the menu
    radius,         //The radius for the sphere and cone
    length,         //The length of the side of the cone, prism, and pyramid
    height,         //The height of the side of the prism and pyramid
    width;          //The width of the side of the prism

float surfArea;     //The surface area of all of the shapes

//Print the surface areas with 4 digits after the decimal points

cout << fixed << showpoint << setprecision(4);

//Display the menu to the user and get their choice

menuChoice = Menu();

//While the user does not want to quit

while( menuChoice != 5 )
  {

  //If the user wants to calculate the surface area of a sphere, get the
  //radius of the sphere and then display the calculated surface area

  if( menuChoice == 1 )
    {
    radius = getValue( "Enter the radius for the sphere", 1, 10 );

    surfArea = calcSphere( radius );

    cout << endl << "The surface area of a sphere with radius " << radius
         << " is " << surfArea;    
    }

  //If the user wants to calculate the surface area of a cone, get the
  //radius of the base and the length of the side of the cone, and then
  //display the calculated surface area

  else if ( menuChoice == 2 )
    {
    radius = getValue( "Enter the radius of the base of the cone", 1, 7 );

    length = getValue( "Enter the length of the side of the cone", 1, 12 );

    surfArea = calcCone( radius, length );

    cout << endl << "The surface area of a cone with radius " << radius
         << " and side length " << length << " is " << surfArea;    
    }

  //If the user wants to calculate the surface area of a prism, get the
  //length, width, and height of the side of the prism, and then display
  //the calculated surface area

  else if ( menuChoice == 3 )
    {
    length = getValue( "Enter the length of the side of the prism", 1, 20 );
    width = getValue( "Enter the width of the side of the prism", 1, 20 );
    height = getValue( "Enter the height of the side of the prism", 1, 20 );

    surfArea = calcPrism( length, width, height );

    cout << endl << "The surface area of the prism with length " << length
         << " width " << width << " and height " << height << " is " << surfArea;    
    }

  //Otherwise, the user wants to calculate the surface area of a pyramid.
  //Get the length of the base and the slant height of the pyramid, and
  //then display the calculated surface area

  else if (menuChoice == 4 )
    {
    length = getValue( "Enter the length of the base of the pyramid", 1, 10 );
    height = getValue( "Enter the slant height of the pyramid", 1, 15 );

    surfArea = calcPyramid( length, height );

    cout << endl << "The surface area of the pyramid with base " << length
         << " and slant height " << height << " is " << surfArea;    
    }

  //Get another menu choice from the user

menuChoice = Menu();
  }

return 0;
}

//********** Code the functions below this line **********

/*********************************************************
Function: Menu

Use: This function asks for the users choice for the menu
(choices 1-5 in this case). 

Arguements: None

Returns: The number entered is the choice on the menu, and
opens up the calculator. 

**********************************************************/

int Menu()
{
int menuChoice;

cout << "1. Surface Area of a Sphere\n"
	 << "2. Surface Area of a Cone\n"
	 << "3. Surface Area of a Prism\n"
	 << "4. Surface Area of a Pyramid\n";

cin >> menuChoice;
return 0;
}

/***********************************************************
Function: Get Value

Use: This function asks the user to enter a value into the 
calculator between certain guidelines. 

Arguements: None

Returns: Whatever calculation is done after entering in the
proper number of values. 

***********************************************************/

int getValue(string, int, int)
{
int value;

value = getValue();
return value; 



}
/************************************************************
Function: Sphere

Use: Calculates the area of a sphere. 

Arguements: Four * value of PI * the radius squared. 

Returns: The surface area of a sphere.

************************************************************/


float calcSphere(int radius)
{

float sa;

cout << "Enter in your radius\n";
cin >> radius;

sa = 4 * PI * (radius*radius);
return sa;
}

/*************************************************************
Function: Prism

Use: Calculates the area of a prism.

Arguements: 2 * length  * width added three times.

Returns: The surface area of a rectangular prism.

*************************************************************/

float calcPrism(int length, int width, int height)
{

float sa2;

cout << "Enter in your length\n";
cin >> length;
cout << "Enter in your width\n";
cin >> width;
cout << "Enter in your height\n";
cin >> height;

sa2 = (2 * length * width) + (2 * width * height) + (2 * length * height);
return sa2;
}
/**************************************************************
Function: Cone

Use: Calculates the surface area of a cone. 

Arguements: PI * radius * length + PI * radius squared. 

Returns: The surface area of a cone. 

**************************************************************/

float calcCone(int radius, int length)
{
float sa3;

cout << "Enter in your radius\n";
cin >> radius;
cout << "Enter in your length\n";
cin >> length;

sa3 = (PI * radius * length) + (PI * (radius*radius));
return sa3;

}

/**************************************************************
Function: Pyramid

Use: Calculates the surface area of a pyramid.

Arguements: 2 * length * height + length squared. 

Returns: The surface area of a pyramid. 

**************************************************************/

float calcPyramid(int length, int height) 
{
float sa4;

cout << "Enter in your length\n";
cin >> length; 
cout << "Enter in your height\n";
cin >> height;

sa4 = (2 * length * height) + (length*length);
return sa4;
}

Any help is appreciated. Please also let me know if there are any mistakes. I believe it works correctly outside of the getValue function issue, but a proofread never hurts from other people :) Thank you!

[chris11757]

Use the code formatting tags when posting code to make it easier to read.

[ET21]

That's better

[chris11757]

I just briefly looked through the code but you just declare the datatypes and don't actually create a variable for the getvalue function.

int getValue(string s, int one, int two)
{
int value;

value = getValue();
return value; 

Try that, although with just skimming your code it could be something else.

[ET21]

Should I set the int values in the function to where it includes numbers between 0 and 20? The string s is just a prompt for the user.

[buffbill]

You could substitute something like this:

int getValue()
{
cout<<"enter a value b/n 1 and 20";
int value;
cin>>value;
return value;
}

[ET21]

I try that and it still is giving me errors for any getValue function in the program.

[cardinals1968]

I am also having a similar issue. Were you able to figure it out? I think I might be in your class

[ET21]

I was able to fix all my other errors. But I could never find the getValue to work the way the instructions wanted it to do.