checker program error

[holywingz]

my checker program can work fine on some place without the checker blocked or on the corner but it has bug when in the corner or blocked on the side.

The main function:

#include <iostream>
#include <cstdlib>
#include "/home/programmer/Desktop/C++/Chapter09/CheckerHeaderFile/SetBoard.cxx"
#include "/home/programmer/Desktop/C++/Chapter09/CheckerHeaderFile/Go.cxx"
using namespace std;

int main()
{
	const int COUNT=8;
	char board[COUNT][COUNT];
	setBoard(board, COUNT);
	int turn=0;
	
	while(++turn)
	{
		showBoard(board, COUNT);
		go(board, COUNT, turn);
		//evaluate(board, COUNT);
	}
}

[holywingz]

The main and showBoard which looks fine to me too

#ifndef SETBOARD_CXX
#define SETBOARD_CXX
#include <iostream>
using namespace std;

void setBoard(char board[][8], const int COUNT)
{
	for(int i=COUNT-1; i>=0; --i)
	{
		for(int j=0; j<COUNT; ++j)
		{
			if((i%2==0 && (j==0
			|| j==2)) || (i%2==1
			&& j==1))
			board[i][j]='w';
			else
			if((i%2==1 && (j==5
			|| j==7)) || (i%2==0
			&& j==6))
			board[i][j]='b';
			else
			board[i][j]='-';
		}
	}
}

void showBoard(char board[][8], const int COUNT)
{
	for(int i=COUNT-1; i>=0; --i)
	{
		cout << i << " ";
		for(int j=0; j<COUNT; ++j)
		{
			cout << board[j][i] << " ";
		}
		cout << endl;
	}
	cout << "  0 1 2 3 4 5 6 7";
}
#endif

[holywingz]

I think the problem is in here:

#include <iostream>
using namespace std;

#ifndef GO_CXX
#define GO_CXX
void whiteGo(char board[][8], const int COUNT);
void blackGo(char board[][8], const int COUNT);
bool blocked(char board[][8], const int COUNT, int x, int y);
// block is checked for if the piece is could not move
void whitePoonGo(char board[][8], const int COUNT, int x, int y, bool &done);
void whiteKingGo(char board[][8], const int COUNT, int x, int y, bool &done);
void blackPoonGo(char board[][8], const int COUNT, int x, int y, bool &done);
void blackKingGo(char board[][8], const int COUNT, int x, int y, bool &done);

void go(char board[][8], const int COUNT, int turn)//see which one go
{
	if(turn%2==1)
	{
		whiteGo(board, COUNT);
	}
	else
	{
		blackGo(board, COUNT);
	}
}

void whiteGo(char board[][8], const int COUNT)
{
	bool done=false;//done is had you gone, false is not gone, true means went already
	int x, y;
	cout << endl << "White's Go!" << endl;
	cout << "Please enter x for white: ";
	cin >> x;
	cout << "Please enter y for white: ";
	cin >> y;
	while((board[x][y]!='w' && board[x][y]!='W')
	|| blocked(board, COUNT, x, y))
	{
		cout << "Please enter correct location for white!" << endl;
		cout << "Please enter x for white again: ";
		cin >> x;
		cout << "Please enter y for white again: ";
		cin >> y;
	}
	if(done==false)
	{
		if(board[x][y]=='w')
		whitePoonGo(board, COUNT, x, y, done);
		else
		whiteKingGo(board, COUNT, x, y, done);
	}
}

void blackGo(char board[][8], const int COUNT)
{
	bool done=false;
	int x, y;
	cout << endl << "Black's Go!" << endl;
	cout << "Please enter x for black: ";
	cin >> x;
	cout << "Please enter y for black: ";
	cin >> y;
	while((board[x][y]!='b' && board[x][y]!='B')
	|| blocked(board, COUNT, x, y))
	{
		cout << "Please enter correct location for black!" << endl;
		cout << "Please enter x for black again: ";
		cin >> x;
		cout << "Please enter y for black again: ";
		cin >> y;
	}
	if(done==false)
	{
		if(board[x][y]=='b')
		blackPoonGo(board, COUNT, x, y, done);
		else
		blackKingGo(board, COUNT, x, y, done);
	}
}

bool blocked(char board[][8], const int COUNT, int x, int y)
{
	bool output=false;
	switch(board[x][y])
	{
		case 'w'://see if four side of 'w' are blocked
		if(((board[x-1][y+1]=='w' || board[x-1][y+1]=='W')
		|| ((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
		&& board[x-2][y+2]!='-'))
		&&
		((board[x+1][y+1]=='w' || board[x+1][y+1]=='W')
		|| ((board[x+1][y+1]=='b' || board[x+1][y+1]=='B')
		&& board[x+2][y+2]!='-')))
		output=true;
		break;
		
		case 'W'://see if four side of 'W' are blocked
		if(((board[x-1][y+1]=='w' || board[x-1][y+1]=='W')
		|| ((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
		&& board[x-2][y+2]!='-'))
		&&
		((board[x+1][y+1]=='w' || board[x+1][y+1]=='W')
		|| ((board[x+1][y+1]=='b' || board[x+1][y+1]=='B')
		&& board[x+2][y+2]!='-'))
		&&
		((board[x+1][y-1]=='w' || board[x+1][y-1]=='W')
		|| ((board[x+1][y-1]=='b' || board[x+1][y-1]=='B')
		&& board[x+2][y-2]!='-'))
		&&
		((board[x-1][y-1]=='w' || board[x-1][y-1]=='W')
		|| ((board[x-1][y-1]=='b' || board[x-1][y-1]=='B')
		&& board[x-2][y-2]!='-')))
		output=true;
		break;
		
		case 'b'://see if four side of 'b' are blocked
		if(((board[x-1][y-1]=='b' || board[x-1][y-1]=='B')
		|| ((board[x-1][y-1]=='w' || board[x-1][y-1]=='W')
		&& board[x-2][y-2]!='-'))
		&&
		((board[x+1][y-1]=='b' || board[x+1][y-1]=='B')
		|| ((board[x+1][y-1]=='w' || board[x+1][y-1]=='W')
		&& board[x+2][y-2]!='-')))
		output=true;
		break;
		
		case 'B'://see if four side of 'B' are blocked
		if(((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
		|| ((board[x-1][y+1]=='w' || board[x-1][y+1]=='w')
		&& board[x-2][y+2]!='-'))
		&&
		((board[x+1][y+1]=='b' || board[x+1][y+1]=='B')
		|| ((board[x+1][y+1]=='w' || board[x+1][y+1]=='W')
		&& board[x+2][y+2]!='-'))
		&&
		((board[x+1][y-1]=='b' || board[x+1][y-1]=='B')
		|| ((board[x+1][y-1]=='w' || board[x+1][y-1]=='W')
		&& board[x+2][y-2]!='-'))
		&&
		((board[x-1][y-1]=='b' || board[x-1][y-1]=='B')
		|| ((board[x-1][y-1]=='w' || board[x-1][y-1]=='W')
		&& board[x-2][y-2]!='-')))
		output=true;
		break;
	}
	return output;
}
	
void whitePoonGo(char board[][8], const int COUNT, int x, int y, bool &done)
{
	int way;
	bool eat=true;
	bool go=false;
	while(eat==true)
	{
		cout << "Please enter you want it to go left front(1) "
		<< "or right front(2) or choose again(5) or stop(6): ";
		cin >> way;
		
		switch(way)
		{
			case 1:
			if((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
			&& (board[x-2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x-1][y+1]='-';
				board[x-2][y+2]=temp;
				x-=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x-1][y+1]=='-')
			{
				board[x-1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 2:
			if((board[x+1][y+1]=='b' || board[x+1][y+1]=='B')
			&& (board[x+2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x+1][y+1]='-';
				board[x+2][y+2]=temp;
				x+=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x+1][y+1]=='-')
			{
				board[x+1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 5:
			if(go==false)
				whiteGo(board, COUNT);
			else
				cout << "You went already!" << endl;
			break;
			
			case 6:
			if(go==true)
				eat=false;
		}
		done=true;
	}
}
			
void whiteKingGo(char board[][8], const int COUNT, int x, int y, bool &done)
{
	int way;
	bool eat=true;
	bool go=false;
	while(eat==true)
	{
		cout << "Please enter you want it to go left front(1) or right front(2) "
		<< "or left back(3) or right back(4) or choose again(5) or stop(6): ";
		cin >> way;
		
		switch(way)
		{
			case 1:
			if((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
			&& (board[x-2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x-1][y+1]='-';
				board[x-2][y+2]=temp;
				x-=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x-1][y+1]=='-')
			{
				board[x-1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 2:
			if((board[x+1][y+1]=='b' || board[x+1][y+1]=='B')
			&& (board[x+2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x+1][y+1]='-';
				board[x+2][y+2]=temp;
				x+=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x+1][y+1]=='-')
			{
				board[x+1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 3:
			if((board[x-1][y-1]=='b' || board[x-1][y-1]=='B')
			&& (board[x-2][y-2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x-1][y-1]='-';
				board[x-2][y-2]=temp;
				x-=2;
				y-=2;
				go=true;
			}
			else 
			if(board[x-1][y-1]=='-')
			{
				board[x-1][y-1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 4:
			if((board[x-1][y+1]=='b' || board[x-1][y+1]=='B')
			&& (board[x-2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x-1][y+1]='-';
				board[x-2][y+2]=temp;
				x-=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x-1][y+1]=='-')
			{
				board[x-1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;
			
			case 5:
			if(go==false)
				whiteGo(board, COUNT);
			else
				cout << "You went already!" << endl;
			break;
			
			case 6:
			if(go==true)
				eat=false;
		}
		done=true;
	}
}

Because of the size I deleted the black poon and black king function, but basicly they are same just like white poon and white king.

[holywingz]

If I choose some ok function like x=0, y=2, It is fine

7 - b - b - b - b 
6 b - b - b - b - 
5 - b - b - b - b 
4 - - - - - - - - 
3 - - - - - - - - 
2 w - w - w - w - 
1 - w - w - w - w 
0 w - w - w - w - 
  0 1 2 3 4 5 6 7
White's Go!
Please enter x for white: 0
Please enter y for white: 2
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 2
7 - b - b - b - b 
6 b - b - b - b - 
5 - b - b - b - b 
4 - - - - - - - - 
3 - w - - - - - - 
2 - - w - w - w - 
1 - w - w - w - w 
0 w - w - w - w - 
  0 1 2 3 4 5 6 7
Black's Go!
Please enter x for black: 

[holywingz]

but x=0, y=0 will mess up the game

7 - b - b - b - b 
6 b - b - b - b - 
5 - b - b - b - b 
4 - - - - - - - - 
3 - - - - - - - - 
2 w - w - w - w - 
1 - w - w - w - w 
0 w - w - w - w - 
  0 1 2 3 4 5 6 7
White's Go!
Please enter x for white: 0
Please enter y for white: 0
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 1
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 2
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 5

White's Go!
Please enter x for white: 0
Please enter y for white: 2
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 1
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 2
Please enter you want it to go left front(1) or right front(2) or choose again(5) or stop(6): 

[TheIdeasMan]

switch(way)
		{
			case 1:
			if((board[x-1][y+1]=='b' || board[x-1][y+1]=='B') // board[x-1] out of bounds for the array
			&& (board[x-2][y+2]=='-'))
			{
				char temp=board[x][y];
				board[x][y]='-';
				board[x-1][y+1]='-';
				board[x-2][y+2]=temp;
				x-=2;
				y+=2;
				go=true;
			}
			else 
			if(board[x-1][y+1]=='-')
			{
				board[x-1][y+1]=board[x][y];
				board[x][y]='-';
				eat=false;
				go=true;
			}
			break;

As you can see by my comment, you are going out of bounds on the array, so the first part is always false making the whole condition false.

So you need to first check the position to see if it is valid for the requested operation.

Another tip - don't do this:

else 
if(board[x-1][y+1]=='-')

Do this - which allows for multiple else if's:

if (/* your condition */) {
//your code
}
else if(/* your condition */) {
//your code
}
else if(/* your condition */) {
//your code
}
else {  //use this for anything else - probably an error situation
//your code
}

Hope all goes well :D