Re-inserting into std::priority_queue

[10oTURfi]

I sometimes need to change the place of the element in the priority_queue. I did it like this:

#include <queue>
#include <algorithm>

struct Vector2i
{
    unsigned x;
    unsigned y;
    // bla bla
};

struct PathfinderNode
{
    PathfinderNode* pParent;
    Vector2i Position;
    unsigned G, H;
};

struct CompareNode : public std::binary_function<PathfinderNode*, PathfinderNode*, bool>
{
    bool operator()(const PathfinderNode* first, const PathfinderNode* second) const
    {
        return((first->G + first->H) > (second->G + second->H));
    }
};

class my_priority_queue :
    public std::priority_queue<PathfinderNode*, std::vector<PathfinderNode*>, CompareNode>
{
public:
    void re_insert(PathfinderNode* what)
    {
        this->c.erase(std::find(this->c.begin(), this->c.end(), what));
        std::make_heap(this->c.begin(), this->c.end(), CompareNode());
        this->push(what);
    }

    void clear()
    {
        this->c.clear();
    }
    
    void reserve(size_t elements)
    {
        this->c.reserve(elements);
    }
};

Now... It is really hard to tell if it works or not (Cause the algorithm which uses this somehow works without std::make_heap call, so I am not sure if it is correct. Is it? Or is there a better way?

[ne555]

¿what is `this->c' ?

You are just putting the new node at the back, as long as that's its place it would be fine.
You could just `make_heap()' without removing that node.

[10oTURfi]

this->c is std::vector which is used by std::priority queue. Works on gcc and msvc++.

Oh yeah, good idea...That *how did i miss that* feeling