problem if finding postfix
Dec 31, 2012 at 2:47pm UTC
hello
my code convert some expression correctly and other not..
Ex:(2+7)*6
RESULT:54 TRUE
BUT 1*4+4*0-3
RESULT:1
but my code out 7
here is my code
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
const char SIZE=100;
class stack
{
public :
stack();
bool isempty()const ;
bool isfull()const ;
void push(char num);
void pop(char &elm);
void cntres();
char topnum()const ;
void print();
void result(stack &post);
private :
char data[SIZE];
int top;
};
#include<iostream>
#include"convert.h"
#include<cstddef>
#include<cstring>
#include<ctype.h>
using namespace std;
stack::stack()
{
top=-1;
}
bool stack::isempty()const
{
return top==-1;
}
bool stack::isfull()const
{
return top==SIZE-1;
}
void stack::push(char elm)
{
if (isfull())
cout<<"Cannot Add New Item , No Free Space ." <<endl;
else
{
top++;
data[top]=elm;
}
}
void stack::pop(char &elm)
{
if (isempty())
cout<<"There's No Data ." <<endl;
else
{
elm=data[top];
top--;
}
}
void stack::print()
{ int i;
cout<<"PostFix Formula : " ;
for (i=0;i<=top;i++)
cout<<data[i];
}
/*void stack::result(stack &post)
{
int a,b,c;
char num;
int res=0;
int loop=strlen(post.data);
for(int i=0;i<loop;i++)
{
if(!(post.data[i]=='+'||post.data[i]=='-'||post.data[i]=='*'||post.data[i]=='/'))
push(post.data[i]);
else
{ char num;
pop(num);
a=num-'0';
pop(num);
b=num-'0';
if(post.data[i]=='+')
c=a+b;
else if (post.data[i]=='-')
c=a-b;
else if (post.data[i]=='*')
c=a*b;
else
c=a/b;
num=c+'0';
push(c);
}
}
pop(num);
res=num-'0';
cout<<res<<endl;
}
*/
char stack::topnum()const
{
return data[top];
}
// main
/*
*/
#include<iostream>
#include"convert.h"
#include<cstring>
using namespace std;
int main()
{
stack op;
stack post;
stack res;
char infex[SIZE];
bool isEx=false ;
cout<<"Please Enter Infex Formula :" ;
cin.get(infex,SIZE);
bool isnum=false ;
char OpValue;
char ch;
int lenght;
lenght=strlen(infex);
for (int i=0;i<lenght;i++)
{
if ((infex[i]>='a' &&infex[i]<='z' )||(infex[i]>='A' &&infex[i]<='Z' ))
isnum=true ;
if (infex[i]=='+' ||infex[i]=='-' ||infex[i]=='*' ||infex[i]=='/' ||infex[i]=='(' ||infex[i]==')' )
{
if (infex[i]=='*' ||infex[i]=='/' ||infex[i]=='(' )
op.push(infex[i]);
else if (infex[i]=='+' ||infex[i]=='-' )
{
if (op.topnum()=='*' ||op.topnum()=='/' )
{
op.pop(ch);
post.push(ch);
op.push(infex[i]);
}
else
op.push(infex[i]);
}
else if (infex[i]==')' )
{
op.pop(ch);
OpValue=ch;
while (OpValue!='(' )
{
post.push(OpValue);
op.pop(ch);
OpValue=ch;
}
}
}
else
post.push(infex[i]);
}
while (!op.isempty())
{
op.pop(ch);
OpValue=ch;
post.push(OpValue);
}
post.print();
cout<<endl;
char out;
stack temp;
while (!post.isempty())
{
post.pop(out);
temp.push(out);
}
while (!temp.isempty())
{
temp.pop(out);
if (out=='+' ||out=='-' ||out=='*' ||out=='/' )
{
char num;
int a,b,c;
res.pop(num);
a=num-'0' ;
res.pop(num);
b=num-'0' ;
switch (out)
{
case '+' :
c=a+b;
break ;
case '-' :
c=a-b;
break ;
case '*' :
c=a*b;
break ;
case '/' :
c=a/b;
break ;
}
res.push(c+'0' );
}
else res.push(out);
}
int res1;
res.pop(out);
res1=out-'0' ;
if (isnum==true )
cout<<"Expresion Whitout value" <<endl;
else {
cout<<"RESULT OF INFIX : " ;
cout<<res1<<endl;}
system("pause" );
return 0;
}
Last edited on Dec 31, 2012 at 2:48pm UTC
Dec 31, 2012 at 4:34pm UTC
It looks like you are not handling operator precedence correctly. Normally you do division and multiplication operations before you do addition and subtraction. Also you don't seem to be allowing grouping with parentheses.
Dec 31, 2012 at 6:49pm UTC
where is the wrong ???
Dec 31, 2012 at 7:55pm UTC
I would start by insuring your if/else clauses are correct. I suggest using braces, even when not technically required. For example:
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
if (infex[i]=='+' ||infex[i]=='-' ||infex[i]=='*' ||infex[i]=='/' ||infex[i]=='(' ||infex[i]==')' )
{
if (infex[i]=='*' ||infex[i]=='/' ||infex[i]=='(' )
op.push(infex[i]);
else if (infex[i]=='+' ||infex[i]=='-' )
{
if (op.topnum()=='*' ||op.topnum()=='/' )
{
op.pop(ch);
post.push(ch);
op.push(infex[i]);
}
else
op.push(infex[i]);
}
What if statement does that last closing brace belong to. Looking at your indentation it may appear to belong to the if(op.topnum()=='*'||op.topnum()=='/') but it actually belongs to the else if.
Topic archived. No new replies allowed.