print function in circular list

[m1m6]

my code dousn't print members of any object
i try another code
it print all members but
will fall in infinite loop...

void LED::print()
{

	if(head=NULL)
		{cout<<"Empty List"<<endl;
	return;
	}
	nodeptr out=head;
	for(int i=1;i<this->cot();i++)
	{
		cout<<out->data<<endl;
		out=out->link;

	}

}
/*////////////////////////*/
int LED::cot()
{
nodeptr temp=head;
int c=0;
if(head==NULL)
	return 0;
else
	c++;
while(temp->link!=head)
{
c++;
temp=temp->link;

}
return c;


}

[TheIdeasMan]

I am no expert in this, but it sounds like you need a sentinel variable in the node class (or struct), which is set in the head node, and each node is checked to see if the sentinel is set, so to prevent infinite traversal .


HTH

[MikeyBoy]

In your LED::print() method, your if statement is incorrect. You're using a single =, which assigns the value NULL to head. Since NULL is equivalent to 0, the expression (head=NULL) evaluates to zero, i.e. false.

You don't show the definition of head, but assuming it's a global variable:

When you call LED::cot(), head has been set to NULL, so it returns 0.

In your for loop you initialise i to 1, and since cot() returns 0, the condition i < this->cot() is never true, so it never enters the loop. Thus nothing is ever output.

You need to change the if statement to use the equality comparison operator, ==.

[m1m6]

thanks

i changed if statment :)

but still the last node doesn't appear

ie:

INPUT:
9
6
8
5
7
4
5
3

OUTPUT:
9
6
8
5
7
4
5

[D80DSL3A]

Maybe i should start at 0 in the for loop in print().

I would not use the cot() and replace the for loop in print() with:

nodeptr out=head;
do
{
	cout<<out->data<<endl;
	out=out->link;
}while( out != head );

[m1m6]

thanks
it's work :)