C++

Forum

 
 
Converting Integers into Words problem.

Yamraj (9)
Hello, I wrote this program, and it runs fine until you go into the thousands. Then things get messed up. Here is the code:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
 
//assign_1_12_numberestowords.cpp
//Dishant Patel
//
//This program will take a number of maximum 5 digits, postive or negative, and display the number written out in words.
#include <iostream>

using namespace std;

int main()
{
    cout << "Please enter an integer" << endl;
    int num, numhund, numthou, numtenthou, numhundthou, numten;//the number is split into different values that represent each digit
    cin>>num;
    if (num<0)//ensures that if num is nugative, then it mentions that
    {
        cout<<"negative ";
        num=-num;
    }
    numhundthou=num/100000;
    num=num%100000;
    numtenthou=num/10000;
    if (numtenthou<2)
    {
      numthou=num%100;
    }
    else
    {
        num=num%10000;
        numthou=num/1000;
    }
    num=num%1000;
    numhund=num/100;
    num=num%100;
    numten=num/10;
    if (numten>2)
    {
        num=num%10;
    }
    if((numthou!=0)||(numhundthou!=0)||(numtenthou!=0))
    {
        if (numhundthou!=0)
        {
            switch (numhundthou)//Case Values begin.
            {
                case 1:
                cout<<"one ";
                break;
                case 2:
                cout<<"two ";
                break;
                case 3:
                cout<<"three ";
                break;
                case 4:
                cout<<"four ";
                break;
                case 5:
                cout<<"five ";
                break;
                case 6:
                cout<<"six ";
                break;
                case 7:
                cout<<"seven ";
                break;
                case 8:
                cout<<"eight ";
                break;
                case 9:
                cout<<"nine ";
                break;
            }
            cout<<"hundred " << endl;
        }
        if ((numtenthou>=1)&&(numtenthou<=9))
        {
            switch (numtenthou)
            {
                case 2:
                cout<<"twenty ";
                break;
                case 3:
                cout<<"thirty ";
                break;
                case 4:
                cout<<"forty ";
                break;
                case 5:
                cout<<"fifty ";
                break;
                case 6:
                cout<<"sixty ";
                break;
                case 7:
                cout<<"seventy ";
                break;
                case 8:
                cout<<"eighty ";
                break;
                case 9:
                cout<<"ninety ";
                break;
                cout<<" ";
                break;
            }
            switch (numthou)
            {
                case 1:
                cout<<"one ";
                break;
                case 2:
                cout<<"two ";
                break;
                case 3:
                cout<<"three ";
                break;
                case 4:
                cout<<"four ";
                break;
                case 5:
                cout<<"five";
                break;
                case 6:
                cout<<"six ";
                break;
                case 7:
                cout<<"seven ";
                break;
                case 8:
                cout<<"eight ";
                break;
                case 9:
                cout<<"nine ";
                break;
                cout<<" ";
                break;
            }
            cout<<"thousand ";
        }
        if ((numtenthou!=0)&&(numtenthou<2))
        {
            switch(numthou)
            {
                case 1:
                cout<<"one ";
                break;
                case 2:
                cout<<"two ";
                break;
                case 3:
                cout<<"three ";
                break;
                case 4:
                cout<<"four ";
                break;
                case 5:
                cout<<"five ";
                break;
                case 6:
                cout<<"six ";
                break;
                case 7:
                cout<<"seven ";
                break;
                case 8:
                cout<<"eight ";
                break;
                case 9:
                cout<<"nine ";
                break;
                case 10:
                cout<<"ten ";
                break;
                case 11:
                cout<<"eleven ";
                break;
                case 12:
                cout<<"twelve ";
                break;
                case 13:
                cout<<"thirteen ";
                break;
                case 14:
                cout<<"fourteen ";
                break;
                case 15:
                cout<<"fifteen ";
                break;
                case 16:
                cout<<"sixteen ";
                break;
                case 17:
                cout<<"seventeen ";
                break;
                case 18:
                cout<<"eighteen ";
                break;
                case 19:
                cout<<"nineteen ";
                break;
                cout<<" ";
                break;
            }
            cout<<"thousand ";
        }
    }
    if(numhund!=0)
    {
        switch (numhund)
        {
            case 1:
            cout<<"one ";
            break;
            case 2:
            cout<<"two ";
            break;
            case 3:
            cout<<"three ";
            break;
            case 4:
            cout<<"four ";
            break;
            case 5:
            cout<<"five ";
            break;
            case 6:
            cout<<"six ";
            break;
            case 7:
            cout<<"seven ";
            break;
            case 8:
            cout<<"eight ";
            break;
            case 9:
            cout<<"nine ";
            break;
            cout<<" ";
        }
        cout<<"hundred ";
    }
    if ((numten>=2)&&(numten<=9))
    {
        switch (numten)
        {
            case 1:
            cout<<"ten ";
            break;
            case 2:
            cout<<"twenty ";
            break;
            case 3:
            cout<<"thirty ";
            break;
            case 4:
            cout<<"forty ";
            break;
            case 5:
            cout<<"fifty ";
            break;
            case 6:
            cout<<"sixty ";
            break;
            case 7:
            cout<<"seventy ";
            break;
            case 8:
            cout<<"eighty ";
            break;
            case 9:
            cout<<"ninety ";
            break;
            cout<<" ";
            break;
        }
        switch (num)
        {
            case 1:
            cout<<"one ";
            break;
            case 2:
            cout<<"two ";
            break;
            case 3:
            cout<<"three ";
            break;
            case 4:
            cout<<"four ";
            break;
            case 5:
            cout<<"five ";
            break;
            case 6:
            cout<<"six ";
            break;
            case 7:
            cout<<"seven ";
            break;
            case 8:
            cout<<"eight ";
            break;
            case 9:
            cout<<"nine ";
            break;
            cout<<" ";
            break;
        }
    }
    if ((num>=10)&&(num<=19))
    {
        switch (num)
        {
            case 10:
            cout<<"ten ";
            break;
            case 11:
            cout<<"eleven ";
            break;
            case 12:
            cout<<"twelve ";
            break;
            case 13:
            cout<<"thirteen ";
            break;
            case 14:
            cout<<"fourteen ";
            break;
            case 15:
            cout<<"fifteen ";
            break;
            case 16:
            cout<<"sixteen ";
            break;
            case 17:
            cout<<"seventeen ";
            break;
            case 18:
            cout<<"eighteen ";
            break;
            case 19:
            cout<<"nineteen ";
            break;

        }
    }
return 0;
}


If someone figures out my mistake, please tell me. This is an assignment and I have been working on it for a day now, and its due tomorrow. Please help.

Thanks in Advance!
Yamraj (9)
Please someone.
Duthomhas (13206)
Er, you need to think harder about your assignment.

The idea that you break a number up into its pieces using the remainder and division operators was smart. However, you missed the part about not repeating code.

When you find yourself doing the same thing over and over again, look into loops, functions, and arrays.


To help you out, try writing out the numbers from one to one hundred and see if you can catch any patterns there. (Hint, the only exceptions occur when the tens place is '1'.)

Once you get the groups of three working, then you can start working on powers of 103. How you do it depends on what scale you are using.
http://en.wikipedia.org/wiki/Names_of_large_numbers

Again, you will need a counter and an array.

Post back with how far you get.
Last edited on
Yamraj (9)
Thank you for your reply Duoas, and I know what you mean, infact, a student asked the same thing, but the teacher wants us to do it this way so we can get our cases, breaks, and if statements pat down. If you could please tell me where the problem exists in line numbers, that would be great, because I looked it over many times, and everything looks good.

Again, thanks in advance
Duthomhas (13206)
Your teacher doesn't belong to be teaching. Give me a little to look your code over.
Yamraj (9)
Haha. I hope you can help me out in the future, because I have the same opinion :/ . I hope we can stay in touch in the future.
Duthomhas (13206)
OK, so you have a couple of simple problems.

The first is all the conditions you are adding to to splitting the number up. Don't do that. Just go through a straightforward assignment of everything:

1
2
3
4
5
 
    numhundthou=num/100000;   num=num%100000;
    numtenthou =num/ 10000;   num=num% 10000;
    numthou    =num/  1000;   num=num%  1000;
    numhund    =num/   100;   num=num%   100;
    numten     =num/    10;   num=num%    10;

At this point, I would do a little processing of your values to help in the switches. Since the special cases occur when the tens place is one, just fix it thus:

1
2
3
4
5
 
    if (numtenthou==1)
    {
        numtenthou=0;
        numthou+=10;
    }

Do you see the trick? Don't forget to handle 'numten' and 'num' the same way.

Now that you have a definite value for each of the decimal places (even if that value is zero), you can go through like you want. You only need to check to see that the item you are printing is not zero.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
 
    switch (numhundthou)
    {
        case 1: cout<<"one hundred ";   break;
        ...
        case 9: cout<<"nine hundred ";  break;
    }
    switch (numtenthou)
    {
        case 2: cout<<"twenty "; break;
        ...
        case 9: cout<<"ninety "; break;
    }
    switch (numthou)
    {
        case  1: cout<<"one ";      break;
        ...
        case  9: cout<<"nine ";     break;
        case 10: cout<<"ten ";      break;
        ...
        case 19: cout<<"nineteen "; break;
    }
    if ((numhundthou != 0) || (numtenthou != 0) || (numthou != 0))
        cout<<"thousand ";

And so on.

Hope this helps.

When you are done with this, let me know and I've got some fun links for you.
Yamraj (9)
OK my friend. Thanks SO MUCH. I finally realized my mistake and it works perfectly. I'll send you a test case in a few, just gotta clean some stuff up.
Duthomhas (13206)
Make sure you test for all the odd cases.
123456
213456
103456
120456
23456
etc

Head on over to my home page for the links I promised you.
http://home.comcast.net/~michaelthomasgreer/links.html
Click on Fun with Numbers.
The "Numbers to Words Challenge" link is where we did this on the forum for really big numbers a while back.
Enjoy!
Yamraj (9)
Here's the test case. I also made an addition of where the numbers can me only 6 digits max. 

1
2
3
4
5
6
7
8
9
10
11
12
 
This program will write a number up to 6 digits in words.
Press Enter to continue.

Please enter the 6 digits.
1000000
That is an invalid entry. Please enter a valid number. Only 6 digits please.
-1000000
This is an invalid entry. Please enter a valid number. Only 6 digits please.
987541
 Nine  Hundred  Eighty  Seven  Thousand  Five  Hundred  Forty  One
Process returned 0 (0x0)   execution time : 17.361 s
Press any key to continue.
Topic archived. No new replies allowed.