Fix issue, compiles fine but random function is acting fishy

[brandonator]

For opponent type, the code works, but for some reason it is coming out with mostly OpponentMonster1 (fire), and OpponentMonster3 (nature), and after compiling about 50 times i only got OpponentMonster2 (water) once, can someone try to fix this issue (if there is one) and explain what you did.

///////////////////////////////////////////////////////////////
// Program: un-named-game.cpp
// Description: this program will send out a creature 
// and battle your opponents creature. The code currently works
// but more is being added to it.
//
// All code is mine unless otherwise stated
///////////////////////////////////////////////////////////////

//LIBRARYS
#include <iostream>
#include <ctime>
#include <string>
#include <sstream>
#include <cstdlib>


//NAMESPACE
using namespace std;
//MY VARIABLES
     string PlayerAge;
     string PlayerName;
     string PlayerGender;
     string CharacterDetails;
     string OpponentCharacterDetails;
     string Continue;
     long Earnings = 10;
     long Money = 0;
     long AmountExp = 10;
     long TotalExp = 0;
     long NewLevel = 0;
     long LevelUp = 10;
     long SkillPoints = 3;
     long TotalSkillPoints = 0;
     long Attack = 8;
     long Defence = 1;
     long Health = 40;
     long Damage;
     long ODamage;
     long OAttack = 8;
     long ODefence = 1;
     long OHealth = 40;
     int TypeOfCharacter;
//CALLS MY FUNCTIONS
void Age();//asks for the players age
void Name();//asks the players name
void Gender();//asks for the players gender
void PlayerCard();//shows the user the thier I'D card
void Program();//introduces them to the program
void CharacterDetail();//decides the character they chose
void Rules();//tells the rules
void YourMonster1();//your-fire-type
void YourMonster2();//your-water-type
void YourMonster3();//your-nature-type
void OpponentMonster1();//opponent-fire-type
void OpponentMonster2();//opponent-water-type
void OpponentMonster3();//opponent-nature-type
void OponentType();//chooses the oponents creature
void Battlephase();//begins the battlephase
void Earned();//states what you earned from combat
void Level();//if you leveled up, what level you are, and exp gained
void pause(int dur);//pauses the program for a set number of seconds

//EXECUTES THE PROGRAM
int main()
{
     //Name();
     //Age();
     //Gender();
     //PlayerCard();
     //Program();
     //CharacterDetail();
     //Rules();
     OponentType();
     //Battlephase();
     //Earned();
     //Level();

     system("PAUSE"); 
	 return 0;
}
//FUNCTION DECLARATIONS


void OponentType()
{ 
/* rand example: guess the number */
#include <stdio.h>

  /* initialize random seed: */
  srand ( time(NULL) );

  /* generate secret number: */
  TypeOfCharacter = rand() % 3 + 1;

    if (TypeOfCharacter == 1)
    {
    OpponentMonster1();
    }
    else if (TypeOfCharacter == 2)
    {
    OpponentMonster2();
    }
    else
    {
    OpponentMonster3();
    }
}

void pause(int dur)
{
int temp = time(NULL) + dur;

while(temp > time(NULL));
}

void Name()
{
          cout << "Welcome to the game! Since you are starting on your journey," << endl;
          cout << "let me know a little bit about you.";

          cout << " What is your full name?" << endl << endl;
          getline(cin,PlayerName);
          cout << "Nice to meet you " << PlayerName << "." << endl;
          pause(5);
          system("CLS");
}
void YourMonster1()
{
     cout << "You chose the fire type." << endl << "It does twice as much damage on nature types and half as much damage on water   types."<< endl << endl;
     pause(5);
     cout << "Your fire type has the following stats" << endl << endl;
     pause(5);
     cout << "Attack:" << Attack << endl;
     cout << "Defense:" << Defence << endl;
     cout << "Health:" << Health << endl;
     cout << "Advantage:Nature" << endl;
     cout << "Disadvantage:Water" << endl;
     pause(5);
//Fire vs Fire
     if(OpponentCharacterDetails == "Fire") 
     { 
     Attack = Attack + 0; 
     } 
//Fire vs Water
     if(OpponentCharacterDetails == "Water") 
     { 
     Attack = OAttack / 2; 
     }
//Fire vs Nature
     if (OpponentCharacterDetails == "Nature")
     { 
     Attack = Attack * 2; 
     }
     system("CLS");
}  


void YourMonster2()
{
     cout << "You chose the water type." << endl << "It does twice as much damage on fire types and half as much damage on nature    types."<< endl << endl;
     pause(5);
     cout << "Your water type has the following stats" << endl << endl;
     pause(5);
     cout << "Attack:" << Attack << endl;
     cout << "Defense:" << Defence << endl;
     cout << "Health:" << Health << endl;
     cout << "Advantage:Fire" << endl;
     cout << "Disadvantage:Nature" << endl;
     pause(5);
//Water vs Fire
     if(OpponentCharacterDetails == "Fire") 
     { 
     Attack = Attack * 2; 
     } 
//Water vs Water
     if(OpponentCharacterDetails == "Water") 
     { 
     Attack = OAttack + 0; 
     }
//Water vs Nature
     if (OpponentCharacterDetails == "Nature")
     { 
     Attack = Attack / 2; 
     }
     system("CLS");     
}

void YourMonster3()
{
     cout << "You chose the nature type." << endl << "It does twice as much damage on water types and half as much damage on fire     types."<< endl << endl;
     pause(5);
     cout << "Your nature type has the following stats"<< endl << endl;
     pause(5);
     cout << "Attack:" << Attack << endl;
     cout << "Defense:" << Defence << endl;
     cout << "Health:" << Health << endl;
     cout << "Advantage:Water" << endl;
     cout << "Disadvantage:Fire" << endl << endl;
     pause(5);
//Nature vs Fire
     if(OpponentCharacterDetails == "Fire") 
     { 
     Attack = Attack / 2; 
     } 
//Nature vs Water
     if(OpponentCharacterDetails == "Water") 
     { 
     Attack = OAttack * 0; 
     }
//Nature vs Nature
     if (OpponentCharacterDetails == "Nature")
     { 
     Attack = Attack + 0; 
     }
     system("CLS");     
}
  
void OpponentMonster1()
{
     OpponentCharacterDetails == "Fire";
     cout << "Your opponent sent out a fire type."<<endl; 
     cout << "Its stats are"<<endl<<endl; 
     cout << "Attack:" << OAttack << endl;
     cout << "Defense:" << ODefence << endl; 
     cout << "Health:" << OHealth << endl << endl;
     cout << "Advantage:Nature" << endl;
     cout << "Disadvantage:Water" << endl; 
     pause(5);
//fire vs fire 
     if(CharacterDetails == "Fire") 
     { 
     OAttack = OAttack + 0; 
     } 
//fire vs water 
     if(CharacterDetails == "Water") 
     { 
     OAttack = OAttack / 2; 
     }
//fire vs nature 
     if (CharacterDetails == "Nature")
     { 
     OAttack = OAttack * 2; 
     }
     system("CLS");
}

void OpponentMonster2()
{
     OpponentCharacterDetails == "Water";
     cout << "Your opponent sent out a water type."<<endl; 
     cout << "Its stats are"<<endl<<endl; 
     cout << "Attack:" << OAttack << endl;
     cout << "Defense:" << ODefence << endl; 
     cout << "Health:" << OHealth << endl << endl;
     cout << "Advantage:Fire" << endl;
     cout << "Disadvantage:Nature" << endl;     
     pause(5);
//water vs fire 
     if(CharacterDetails == "Fire") 
     {
     OAttack = OAttack * 2; 
     } 
//water vs water 
     if(CharacterDetails == "Water") 
     { 
     OAttack = OAttack + 0; 
     }
//water vs nature 
     if (CharacterDetails == "Nature")
     { 
     OAttack = OAttack / 2; 
     }        
}

void OpponentMonster3()
{
     OpponentCharacterDetails == "Nature";
     cout << "Your opponent sent out a nature type."<<endl; 
     cout << "Its stats are"<<endl<<endl; 
     cout << "Attack:" << OAttack << endl;
     cout << "Defense:" << ODefence << endl; 
     cout << "Health:" << OHealth << endl << endl;
     cout << "Advantage:Water" << endl;
     cout << "Disadvantage:Fire" << endl;      
     pause(5); 
//Nature vs Fire 
     if(CharacterDetails == "Fire") 
     { 
     OAttack = OAttack / 2; 
     } 
//Nature vs Water 
     if(CharacterDetails == "Water") 
     { 
     OAttack = OAttack * 2; 
     }
//Nature vs Nature 
     if (CharacterDetails == "Nature")
     { 
     OAttack = OAttack + 0; 
     }
}

[brandonator]

sorry about cutting off my code it only allowed a certain number of characters

[Aceix]

I have not taken a deep look. But is it with rand();?

Then you can't do anything about that(can you?) cause it uses an algorithm to generate pseudo integers

[clanmjc]

You need to initialize the seed only once. Do it in main or something, but don't re-seed it everytime you call opponent.