- Forum
- General C++ Programming
- Experimental Wire Like Game
Experimental Wire Like Game
A very simple console game that places and removes wires.
Not finished(organizing needed)!!
Controls:
Q W E
A S D
Move:ASDW
Place Wire:E
Remove Wire:Q
Bugs(Please Help):
-Wires that are connecting left-Bottom-Right/left-Top-Right stay fixed
Code(copy and paste):
Not finished(organizing needed)!!
Controls:
Q W E
A S D
Move:ASDW
Place Wire:E
Remove Wire:Q
Bugs(Please Help):
-Wires that are connecting left-Bottom-Right/left-Top-Right stay fixed
Code(copy and paste):
|
|
Last edited on
Don't really understand what I am supposed to do in this game. Does remind me of an Etch-A-Sketch, though. I'm able to add a dot, move it, and connect a line from there to another dot. Don't really know what I'm doing, but it is impressive.
Don't know if the program is doing things correctly or not, as it may be getting data that is different than you are trying to program into it.
1 -
That means type[0] to type[11], yet you're initializing it with 13.
2 -
That's pretty much the same as saying
You could get some very strange reactions in this game if it tries accessing some of those memory locations.
Don't know if the program is doing things correctly or not, as it may be getting data that is different than you are trying to program into it.
1 -
int type[12];//types That means type[0] to type[11], yet you're initializing it with 13.
|
|
2 -
int optposy[1];That's pretty much the same as saying
int optposy; since the array is set for 1, optposy[0] remember, arrays start at zero to 1 less than what you declare it to be. So, when you initialize optposy as optposy[1]=0;, the array is out of boundsYou could get some very strange reactions in this game if it tries accessing some of those memory locations.
Last edited on
<whitenite1>
You aren't really supposed to do any thing will this game yet. Im planning to implement pulses, but rewriting it before i do that to fix what you said was wrong.
Thanks i did not notice that.
You aren't really supposed to do any thing will this game yet. Im planning to implement pulses, but rewriting it before i do that to fix what you said was wrong.
Thanks i did not notice that.
Hi CLman94,
Just some style points:
1. You have a lot of global variables - try to avoid them.
2. You a goto - forget it even exists, use a while loop instead.
3. set your indenting to 4 spaces rather than 8 - much better I think. Maybe your formatting isn't coming through properly - not your fault possibly.
4. Consider putting this type of thing into functions:
This should make your code much easier to read.
Can you do the above code with &&'s instead?
5. You can declare & initialise an array like this:
The compiler counts how many items are in the array.
HTH
Just some style points:
1. You have a lot of global variables - try to avoid them.
2. You a goto - forget it even exists, use a while loop instead.
3. set your indenting to 4 spaces rather than 8 - much better I think. Maybe your formatting isn't coming through properly - not your fault possibly.
4. Consider putting this type of thing into functions:
|
|
This should make your code much easier to read.
Can you do the above code with &&'s instead?
|
|
5. You can declare & initialise an array like this:
|
|
The compiler counts how many items are in the array.
HTH
Last edited on
Totally removed
This is my code now:
int optposy[1];This is my code now:
|
|
Last edited on
OK looks a bit better now - though still some issues:
You still have the goto loop - it looks like never ending. Use a while loop with some condition to end. Goto's are really really bad - don't use them ever!!
Indentation - still is a 8 chars. The code is 2 screens wide on my system. There is a sort of rule that says code shouldn't be more than 80 chars per line, this is so it fits in one screen, and can be printed easily. It is possible to "fold" you lines of code, just press enter and continue on the next line - doesn't make any difference to the compiler.
This is at least unnecessary:
void means that the function doesn't return anything, so putting a return statement is meaningless.
You still have lots of global variables, I know it seems easier to do it this way, but it is bad form and can lead to all kinds of problems. At least put them in main, and send whichever ones are necessary to the functions. If you need to change the value of some of them, send a pointer or reference to the function, change the value in the function, the changed value of the variable will still be there in main().
With the if statements - if (conditional) expression. Put the expression part on it's own line.
These if statements could still be put into functions. The functions would be short (2 or 3 lines, if you fold them), but it will make the code easier to read.
With variables, it's a good idea to initialise them to something (even 0) when you declare them - it will save you one day. Uninitialised variables are one of the biggest source of errors. Your variables are OK, this is just a handy hint for the future.
Could tedit be a bool type?
Could all this code in main be in a switch statement? I am guessing you don't need to test each one, just select one value of k
Here is what the switch could look like;
Hope this helps
You still have the goto loop - it looks like never ending. Use a while loop with some condition to end. Goto's are really really bad - don't use them ever!!
Indentation - still is a 8 chars. The code is 2 screens wide on my system. There is a sort of rule that says code shouldn't be more than 80 chars per line, this is so it fits in one screen, and can be printed easily. It is possible to "fold" you lines of code, just press enter and continue on the next line - doesn't make any difference to the compiler.
This is at least unnecessary:
|
|
void means that the function doesn't return anything, so putting a return statement is meaningless.
You still have lots of global variables, I know it seems easier to do it this way, but it is bad form and can lead to all kinds of problems. At least put them in main, and send whichever ones are necessary to the functions. If you need to change the value of some of them, send a pointer or reference to the function, change the value in the function, the changed value of the variable will still be there in main().
With the if statements - if (conditional) expression. Put the expression part on it's own line.
These if statements could still be put into functions. The functions would be short (2 or 3 lines, if you fold them), but it will make the code easier to read.
With variables, it's a good idea to initialise them to something (even 0) when you declare them - it will save you one day. Uninitialised variables are one of the biggest source of errors. Your variables are OK, this is just a handy hint for the future.
Could tedit be a bool type?
Could all this code in main be in a switch statement? I am guessing you don't need to test each one, just select one value of k
|
|
Here is what the switch could look like;
|
|
Hope this helps
Goto's removed!!
A wire connection issue has been fixed.Yay
Not the size of to screens, I think :\.
Unnecessary
And here's my code so far:
I have not tried it yet but
could be used to end the function before the last line.
A wire connection issue has been fixed.Yay
Not the size of to screens, I think :\.
Unnecessary
return; removed.And here's my code so far:
|
|
I have not tried it yet but
return;could be used to end the function before the last line.
Last edited on
OK, goto removed, however you have
With the indenting, you still have it at 8, can you set the tabs to be equal to 4 spaces, so it looks like this:
With these if statements:
change it so the action to be carried out is on it's own line - you have done the others just missed these ones. Like this:
I put braces around single if statement action expressions as a defensive measure - even though they are unnecessary, it will save you one day when you add more code.
That was why I suggested you remove them, the functions don't return anything, so this doesn't make sense.
Now, have you thought about how to not have all those global variables? I gave some clues earlier.
The default: label in the switch statement is to catch anything that doesn't match any of the other cases - usually some sort of error. So you should have some code there to handle that situation.
HTH
while(true){ which is an infinite loop - can you think of an ending condition to put there instead of (true)With the indenting, you still have it at 8, can you set the tabs to be equal to 4 spaces, so it looks like this:
|
|
With these if statements:
|
|
change it so the action to be carried out is on it's own line - you have done the others just missed these ones. Like this:
|
|
I put braces around single if statement action expressions as a defensive measure - even though they are unnecessary, it will save you one day when you add more code.
| I have not tried it yet but return; could be used to end the function before the last line. |
That was why I suggested you remove them, the functions don't return anything, so this doesn't make sense.
Now, have you thought about how to not have all those global variables? I gave some clues earlier.
The default: label in the switch statement is to catch anything that doesn't match any of the other cases - usually some sort of error. So you should have some code there to handle that situation.
HTH
Last edited on
With the updatewires function:
The first condition is either
The second condition is either
The third condition is either
The fourth condition is either
Can you think of a better way of combining these tests? Hint put all the left ones together, all the right ones together etc.
The first condition is either
w[curr1][curr+1]==0 or w[curr1][curr+1]>0 The second condition is either
w[curr1][curr-1]==0 or w[curr1][curr-1]>0 The third condition is either
w[curr1+1][curr]==0 or w[curr1+1][curr]>0The fourth condition is either
w[curr1-1][curr]==0 or w[curr1-1][curr]>0Can you think of a better way of combining these tests? Hint put all the left ones together, all the right ones together etc.
Topic archived. No new replies allowed.