What is wrong with my for loop in trying to store words from a file into an array?

[Ilithiya]

Here is my code. All of my functions are fine except for "Function: populateArray" where I have to store the words from a file into an array (the array has a limit of 1000). What is wrong with my code that I keep getting a compiling error & what do I need to do to fix it?

#include<iostream>
#include<fstream>
using namespace std;

// Function Prototypes
void readFilename(ifstream&, string&);
void countNumberLines(ifstream&, int&);
void countNumberChars(ifstream&, int&);
void populateArray(ifstream&, string[]);

int main()
{
  // Variables
  ifstream inFile;
  string filename;
  int countLines;
  int countChars;
  char ch;
  string words[1000];

  // Function Calls
  readFilename(inFile, filename);
  countNumberLines(inFile, countLines);
  countNumberChars(inFile, countChars);
  populateArray(inFile, words);

  return 0;
}

// Function: readFilename
void readFilename(ifstream &inFile, string &filename)
{
  // Reads in file name.
  cout << "Please enter the file name you wish to open." << endl;
  getline(cin, filename);
  inFile.open(filename.c_str());

  // Displays error message if file is not found.
  if (!inFile)
    {
      cout << "This file did not open properly and the program will now terminate.\nPlease make sure the spelling of the file is correct." << endl;
    }
}

// Function: countCharsLines
void countCharsLines(ifstream &inFile, int &countLines, int &\
countChars, char &ch)
{
  string line;
  countLines = 0;
  countChars = 0;

  while(!inFile.eof())
    {
      getline(inFile,line);
      countLines++;
    }

  inFile.clear();
  inFile.seekg(0, ios::beg);

  while(!inFile.eof())
    {
      ch = inFile.get();
      countChars++;
    }

  inFile.close();
}

// Function: populateArray
void populateArray(ifstream &inFile, string words[])
{
  for(int i=0;i<=1000;i++)
    {
      inFile >> words[i];
    }
  inFile.close();
}

And here is the compiling error that I'm getting. Not sure what I'm doing wrong.

Undefined first referenced
symbol in file
countNumberChars(std::basic_ifstream<char, std::char_traits<char> >&,

int&)/var/tmp//ccTJqJoK.o
countNumberLines(std::basic_ifstream<char, std::char_traits<char> >&,

int&)/var/tmp//ccTJqJoK.o
ld: fatal: Symbol referencing errors. No output written to a.out
collect2: ld returned 1 exit status

[vlad from moscow]

You declared function

void countNumberChars(ifstream&, int&);

but did not define it though you are calling it in the code

countNumberChars(inFile, countChars);

[soranz]

Hi !
Line 7, 9 have function declarations but no function definitions :/ I think u mean to delete these declarations (or at least comment out for now) because u have a merged version on line 46.
In contrast line 46 has the definition of a function but no declaration. There's also a syntac error at the end of that line.

In main(), lines 23, 24 are calling those same functions from line 7 and 9 which don't have a definition...Like 7 and 9, u'll want to comment these out in favor of calling the function whose definition is on line 46.

Remember that each function declaration must have an exactly matching definition. U can't have 1 without the other or u'll get those compiler errors.

char &ch doesn't need to be passed into the function on line 46 either since its purpose is complete when the function is completed. Just declare it locally.

Hope this helps !

[sigmablack]

the purpose of making functions is to make things easier and simpler not to complicate them.. i can see that if you perform 'read file' and 'count characters/lines' in the same function then it would be better..

[soranz]

Yeh, I said that too in my reply to a previous thread about this same code where there were 3 separate functions to read file, count chars and count lines. Now there's (almost) 2.
1 step at a time ~