error C2078: too many initializers

Bishopssix (30)
I want to change this to use user defined functions working on the first and i get this error, not sure how to fix it.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
 
 #include <iostream>

using namespace std;

const int SENTINEL = -99;

	// Declaring variables
	char letter;    //letter chosen from the menu
	int i;		    //quantity of numbers user will enter	
	int counter;	//loop control variables
	int number;     // variable to store new number
	int largest;     // variable to store largest number
	int smallest; 
	int number1;
	int largest2;
	int biggestNumber (number1, largest2);

int main ()
{

	// Initializing variables
	largest = -99999999999;
	smallest = 99999999999;
	// Big loop here for the condition of the Application running
	do
	{
		//displaying Menu
		cout << "Please Select One of the Following Choices" << endl;
		cout << "A: Find the largest number with a known quantity of number " << endl;
		cout << "B: Find the smallest number with an unknown quantity of number " << endl;
		cout << "C: Quit" << endl;	
		cout << "Please enter your choice: ";
		cin >> letter;
		cout << endl;
		
		switch (letter)
		{
		case 'A':
		case 'a':
				cout << "How many numbers would you like to enter"<< " ";
				cin >> i;
				cout << endl; 
				cout << "Please enter your numbers" << endl;
				for (counter = 1; counter <= i; counter++)
				{
					cin >> number;
				
				if	biggestNumber (number, largest)
					largest = number;
				}
				cout << "The largest number you entered is" << " " << largest;
				cout << " ";
				cout << endl;
				break;

		case 'B':
		case 'b':
			cout << "Please enter your numbers with your last number being" << " " << SENTINEL << endl;
			cin >> number;
			while (number != SENTINEL)
			{
					if (number < smallest)
						smallest = number;
					cin >> number;
			}
			cout << "The smallest number you entered is" << " " << smallest << endl;
		}
	}
	while (letter != 'C' && letter != 'c');

	cout << endl;

     int biggestNumber
	(
	(number1 > largest2)
	)

	;return 0;
}
Bishopssix (30)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
 
 #include <iostream>

using namespace std;

const int SENTINEL = -99;

	int biggestNumber (int, int);

int main ()
{
	// Declaring variables
	;char letter;    //letter chosen from the menu
	int i;		    //quantity of numbers user will enter	
	int counter;	//loop control variables
	int number;     // variable to store new number
	int largest;     // variable to store largest number
	int smallest; 
	int number1;
	int largest2;





	// Initializing variables
	largest = -99999999999;
	smallest = 99999999999;
	// Big loop here for the condition of the Application running
	do
	{
		//displaying Menu
		cout << "Please Select One of the Following Choices" << endl;
		cout << "A: Find the largest number with a known quantity of number " << endl;
		cout << "B: Find the smallest number with an unknown quantity of number " << endl;
		cout << "C: Quit" << endl;	
		cout << "Please enter your choice: ";
		cin >> letter;
		cout << endl;
		
		switch (letter)
		{
		case 'A':
		case 'a':
				cout << "How many numbers would you like to enter"<< " ";
				cin >> i;
				cout << endl; 
				cout << "Please enter your numbers" << endl;
				for (counter = 1; counter <= i; counter++)
				{
					cin >> number;
				
				if	biggestNumber (number, largest)
					largest = number;
				}
				cout << "The largest number you entered is" << " " << largest;
				cout << " ";
				cout << endl;
				break;

		case 'B':
		case 'b':
			cout << "Please enter your numbers with your last number being" << " " << SENTINEL << endl;
			cin >> number;
			while (number != SENTINEL)
			{
					if (number < smallest)
						smallest = number;
					cin >> number;
			}
			cout << "The smallest number you entered is" << " " << smallest << endl;
		}
	}
	while (letter != 'C' && letter != 'c');

	cout << endl;

     int biggestNumber
	(
	(number1 > largest2)
	)

	;return 0;
}


error C2061: syntax error : identifier 'biggestNumber'

is the only error i got now if anyone can help fix that
helios (17607)
Line 48: No () around the if condition.
Lines 73-76: Function definition inside another function. The definition itself would be wrong even if this wasn't so. Badly formed parameter list. Missing function body.

Reread your source material on functions.
Last edited on
Bishopssix (30)
i fixed it now

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
 
 

  #include <iostream>

using namespace std;

const int SENTINEL = -99;

    // Declaring variables
    char letter;    //letter chosen from the menu
    int i;            //quantity of numbers user will enter
    int counter;    //loop control variables
    int number;     // variable to store new number
    int largest;     // variable to store largest number
    int smallest;
    int number1;
    int largest2;
	int number2;
	int smallest2;
	int smallestNumber (int number2, int smallest2);
    int biggestNumber (int number1, int largest2);  // << declare parameters as ints

int main ()
{

    // Initializing variables
    largest = -999999999;      // << changed these so they will fit an int
    smallest = 999999999;
    // Big loop here for the condition of the Application running
    do
    {
        //displaying Menu
        cout << "Please Select One of the Following Choices" << endl;
        cout << "A: Find the largest number with a known quantity of number " << endl;
        cout << "B: Find the smallest number with an unknown quantity of number " << endl;
        cout << "C: Quit" << endl;
        cout << "Please enter your choice: ";
        cin >> letter;
        cout << endl;

        switch (letter)
        {
        case 'A':
        case 'a':
                cout << "How many numbers would you like to enter"<< " ";
                cin >> i;
                cout << endl;
                cout << "Please enter your numbers" << endl;
                for (counter = 1; counter <= i; counter++)
                {
                    cin >> number;

                if  (  biggestNumber (number, largest))  // () added
                    largest = number;
                }
                cout << "The largest number you entered is" << " " << largest;
                cout << " ";
                cout << endl;
                break;

        case 'B':
        case 'b':
            cout << "Please enter your numbers with your last number being" << " " << SENTINEL << endl;
            cin >> number;
            while (number != SENTINEL)
            {
                    if (  smallestNumber (number, largest))
                        smallest = number;
                    cin >> number;
            }
            cout << "The smallest number you entered is" << " " << smallest << endl;
        }
    }
    while (letter != 'C' && letter != 'c');

    cout << endl;

//     int biggestNumber    << moved
  //  (
  //  (number1 > largest2)
  //  )

;return 0;
}

   // your function goes here not inside main()
    int biggestNumber (int number1, int largest2)
    {
    // is this what you want it to do?
    if(number1 > largest2) return number1; else return largest2;
    }

	int smallestNumber (int number2, int smallest2)
	{
	if(number2 < smallest2) return smallest2; else return smallest2;
	}


helios (17607)
*Never* but the else statement in the same line as the if statement. It makes code much harder to read.
In fact, it's not recommendable to put the block in the same line as the statement.

There's an extra semicolon on line 83.
Last edited on
Topic archived. No new replies allowed.