Reading a text file into three parallel arrays

[metaphoricalsimile]

This just doesn't seem to be working. It compiles, asks for a file name, but then doesn't do anything.

#include <iostream>
#include <iomanip>
#include <fstream>
#include <string>

using namespace std;

// Declare array size
const int ARRAY_SIZE = 1000;

// Arrays are declared outside of main, to be used by the entire program
string city[ARRAY_SIZE];
double lowTemp[ARRAY_SIZE];
double highTemp[ARRAY_SIZE];

int loadData(int sz);
void showAll (int count);

void main()
{
	cout << loadData(ARRAY_SIZE);

	showAll(loadData(ARRAY_SIZE));

	system ("pause.");
}
// This function reads the data and stores it in the parallel arrays
int loadData(int sz)
{
	cout << "Please enter the file path name: " << endl;

	ifstream inFile;

	string path;

	cin >> path;

	string inFileName = path;

	inFile.open(inFileName.c_str());

	int count = 0;

	while (!inFile.eof())
	{
		for (; count < sz; count ++)
		{
			inFile >> city[count] >> lowTemp[count] >> highTemp[count];
		}
	}

	return count;

	// Close the two files
    inFile.close();
    

    // This next line seems to be required to put the file
    // in a state where it can be opened again. May also
    // have to do for outFile.
    inFile.clear(std::ios_base::goodbit);
}

void showAll(int count)
{
	for(int i = 0; i <= count; i++)
		cout << city[i] << "(" << lowTemp[i] << ", " << highTemp[i] << ")" << endl;
}

[coder777]

Line 46 reads the data sz time. Not matter whether there's enough data or not

Line 66 goes out of bounds. it must be i < count

Line 55 and 61 don't do anything (because the function returns on line 52)

On Line 40 you don't check if that file could be opened.

If that file cannot be opened you should see at least 1000 times "(0,0)"

[soranz]

system ("pause."); = bad
This is c++ so use cin.get() ;)

You're doing it backwards. Try:

ofstream outFile;
outFile.open("my file.txt");   //notice the .txt

outFile << "this will be printed to file" << endl;

outFile.close();

Think of it as the familiar 'cout' which prints things out to screen. outFile prints things out to the specified file.

Note that the member function .clear() is not needed in your case. This is used to reset the bits if you made your ofstream object act like an ifstream (or vice versa).

[Gaminic]

Just a side note: this is a big waste:

	cout << loadData(ARRAY_SIZE);

	showAll(loadData(ARRAY_SIZE));

You're reading in the data twice, just because you need the "count" twice? That's crazy! Especially because it will stop at "sz" anyway!